diff options
author | Nick Piggin <npiggin@suse.de> | 2008-04-29 08:48:33 -0400 |
---|---|---|
committer | Jens Axboe <jens.axboe@oracle.com> | 2008-04-29 08:48:33 -0400 |
commit | 75ad23bc0fcb4f992a5d06982bf0857ab1738e9e (patch) | |
tree | 8668ef63b1f420252ae41aed9e13737d49fd8054 /drivers/md/dm-table.c | |
parent | 68154e90c9d1492d570671ae181d9a8f8530da55 (diff) |
block: make queue flags non-atomic
We can save some atomic ops in the IO path, if we clearly define
the rules of how to modify the queue flags.
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
Diffstat (limited to 'drivers/md/dm-table.c')
-rw-r--r-- | drivers/md/dm-table.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/drivers/md/dm-table.c b/drivers/md/dm-table.c index 51be53344214..73326e7c54bf 100644 --- a/drivers/md/dm-table.c +++ b/drivers/md/dm-table.c | |||
@@ -873,10 +873,13 @@ void dm_table_set_restrictions(struct dm_table *t, struct request_queue *q) | |||
873 | q->max_hw_sectors = t->limits.max_hw_sectors; | 873 | q->max_hw_sectors = t->limits.max_hw_sectors; |
874 | q->seg_boundary_mask = t->limits.seg_boundary_mask; | 874 | q->seg_boundary_mask = t->limits.seg_boundary_mask; |
875 | q->bounce_pfn = t->limits.bounce_pfn; | 875 | q->bounce_pfn = t->limits.bounce_pfn; |
876 | /* XXX: the below will probably go bug. must ensure there can be no | ||
877 | * concurrency on queue_flags, and use the unlocked versions... | ||
878 | */ | ||
876 | if (t->limits.no_cluster) | 879 | if (t->limits.no_cluster) |
877 | q->queue_flags &= ~(1 << QUEUE_FLAG_CLUSTER); | 880 | queue_flag_clear(QUEUE_FLAG_CLUSTER, q); |
878 | else | 881 | else |
879 | q->queue_flags |= (1 << QUEUE_FLAG_CLUSTER); | 882 | queue_flag_set(QUEUE_FLAG_CLUSTER, q); |
880 | 883 | ||
881 | } | 884 | } |
882 | 885 | ||