diff options
| author | Jonathan Brassow <jbrassow@redhat.com> | 2006-06-26 03:27:30 -0400 |
|---|---|---|
| committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-06-26 12:58:35 -0400 |
| commit | ce503f59ae899c3e75a8a1cf46f2d44c0c5b5c7c (patch) | |
| tree | 7bec805d077c3a7f47f7a1965a1a8020082c5544 /drivers/md/dm-raid1.c | |
| parent | 8a835f11bce68ed990533e49b5dedb00bee46d71 (diff) | |
[PATCH] dm kcopyd: error accumulation fix
kcopyd should accumulate errors - otherwise I/O failures may be ignored
unintentionally.
And invert 'success' (used in a future patch), using a more intuitive
!(read_err || write_err).
Signed-off-by: Jonathan Brassow <jbrassow@redhat.com>
Signed-off-by: Alasdair G Kergon <agk@redhat.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'drivers/md/dm-raid1.c')
| -rw-r--r-- | drivers/md/dm-raid1.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/md/dm-raid1.c b/drivers/md/dm-raid1.c index 84f2ed6d9c5b..6ae42f1d76ae 100644 --- a/drivers/md/dm-raid1.c +++ b/drivers/md/dm-raid1.c | |||
| @@ -602,7 +602,7 @@ static void recovery_complete(int read_err, unsigned int write_err, | |||
| 602 | struct region *reg = (struct region *) context; | 602 | struct region *reg = (struct region *) context; |
| 603 | 603 | ||
| 604 | /* FIXME: better error handling */ | 604 | /* FIXME: better error handling */ |
| 605 | rh_recovery_end(reg, read_err || write_err); | 605 | rh_recovery_end(reg, !(read_err || write_err)); |
| 606 | } | 606 | } |
| 607 | 607 | ||
| 608 | static int recover(struct mirror_set *ms, struct region *reg) | 608 | static int recover(struct mirror_set *ms, struct region *reg) |