aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/md/dm-mpath.c
diff options
context:
space:
mode:
authorMike Snitzer <snitzer@redhat.com>2014-07-08 11:55:09 -0400
committerMike Snitzer <snitzer@redhat.com>2014-08-01 12:30:31 -0400
commit6afbc01d75c0266d7da32e2ec1f54d579a35703d (patch)
tree38e4a407005087bd95f87bb7ab69e2608fa602d0 /drivers/md/dm-mpath.c
parent97e7cdf12ba324b599d404172c5899185ef2bbde (diff)
dm mpath: eliminate pg_ready() wrapper
pg_ready() is not comprehensive in its logic and only serves to obfuscate code. Replace pg_ready() with the appropriate logic in multipath_map(). Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Diffstat (limited to 'drivers/md/dm-mpath.c')
-rw-r--r--drivers/md/dm-mpath.c6
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/md/dm-mpath.c b/drivers/md/dm-mpath.c
index f4167b013d99..833d7e752f06 100644
--- a/drivers/md/dm-mpath.c
+++ b/drivers/md/dm-mpath.c
@@ -373,8 +373,6 @@ static int __must_push_back(struct multipath *m)
373 dm_noflush_suspending(m->ti))); 373 dm_noflush_suspending(m->ti)));
374} 374}
375 375
376#define pg_ready(m) (!(m)->queue_io && !(m)->pg_init_required)
377
378/* 376/*
379 * Map cloned requests 377 * Map cloned requests
380 */ 378 */
@@ -402,11 +400,11 @@ static int multipath_map(struct dm_target *ti, struct request *clone,
402 if (!__must_push_back(m)) 400 if (!__must_push_back(m))
403 r = -EIO; /* Failed */ 401 r = -EIO; /* Failed */
404 goto out_unlock; 402 goto out_unlock;
405 } 403 } else if (m->queue_io || m->pg_init_required) {
406 if (!pg_ready(m)) {
407 __pg_init_all_paths(m); 404 __pg_init_all_paths(m);
408 goto out_unlock; 405 goto out_unlock;
409 } 406 }
407
410 if (set_mapinfo(m, map_context) < 0) 408 if (set_mapinfo(m, map_context) < 0)
411 /* ENOMEM, requeue */ 409 /* ENOMEM, requeue */
412 goto out_unlock; 410 goto out_unlock;