aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/md/dm-log.c
diff options
context:
space:
mode:
authorDan Carpenter <error27@gmail.com>2011-01-13 15:00:00 -0500
committerAlasdair G Kergon <agk@redhat.com>2011-01-13 15:00:00 -0500
commitdbc883f1570d992ba926a8c9e22140ba473c6cc1 (patch)
tree1a6bfde475cbbe2a978a13b9e2f2a8fec959d7fe /drivers/md/dm-log.c
parentb83b2f295aec418c7501c05df4dfd168a79d165a (diff)
dm log: use PTR_ERR value instead of ENOMEM
It's nicer to return the PTR_ERR() value instead of just returning -ENOMEM. In the current code the PTR_ERR() value is always equal to -ENOMEM so this doesn't actually affect anything, but still... In addition, dm_dirty_log_create() doesn't check for a specific -ENOMEM return. So this change is safe relative to potential for a non -ENOMEM return in the future. Signed-off-by: Dan Carpenter <error27@gmail.com> Acked-by: Jonathan Brassow <jbrassow@redhat.com> Signed-off-by: Mike Snitzer <snitzer@redhat.com> Signed-off-by: Alasdair G Kergon <agk@redhat.com>
Diffstat (limited to 'drivers/md/dm-log.c')
-rw-r--r--drivers/md/dm-log.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/md/dm-log.c b/drivers/md/dm-log.c
index 33420e68d153..6951536ea29c 100644
--- a/drivers/md/dm-log.c
+++ b/drivers/md/dm-log.c
@@ -455,7 +455,7 @@ static int create_log_context(struct dm_dirty_log *log, struct dm_target *ti,
455 r = PTR_ERR(lc->io_req.client); 455 r = PTR_ERR(lc->io_req.client);
456 DMWARN("couldn't allocate disk io client"); 456 DMWARN("couldn't allocate disk io client");
457 kfree(lc); 457 kfree(lc);
458 return -ENOMEM; 458 return r;
459 } 459 }
460 460
461 lc->disk_header = vmalloc(buf_size); 461 lc->disk_header = vmalloc(buf_size);