diff options
author | Linus Torvalds <torvalds@linux-foundation.org> | 2012-12-21 20:08:06 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2012-12-21 20:08:06 -0500 |
commit | b49249d10324d0fd6fb29725c2807dfd80d0edbc (patch) | |
tree | 9a8fa724e6c9f9283530979c6e32a311c74999d5 /drivers/md/dm-io.c | |
parent | 10532b560bacf23766f9c7dc09778b31b198ff45 (diff) | |
parent | 45e621d45e24ffc4cb2b2935e8438987b860063a (diff) |
Merge tag 'dm-3.8-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/agk/linux-dm
Pull dm update from Alasdair G Kergon:
"Miscellaneous device-mapper fixes, cleanups and performance
improvements.
Of particular note:
- Disable broken WRITE SAME support in all targets except linear and
striped. Use it when kcopyd is zeroing blocks.
- Remove several mempools from targets by moving the data into the
bio's new front_pad area(which dm calls 'per_bio_data').
- Fix a race in thin provisioning if discards are misused.
- Prevent userspace from interfering with the ioctl parameters and
use kmalloc for the data buffer if it's small instead of vmalloc.
- Throttle some annoying error messages when I/O fails."
* tag 'dm-3.8-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/agk/linux-dm: (36 commits)
dm stripe: add WRITE SAME support
dm: remove map_info
dm snapshot: do not use map_context
dm thin: dont use map_context
dm raid1: dont use map_context
dm flakey: dont use map_context
dm raid1: rename read_record to bio_record
dm: move target request nr to dm_target_io
dm snapshot: use per_bio_data
dm verity: use per_bio_data
dm raid1: use per_bio_data
dm: introduce per_bio_data
dm kcopyd: add WRITE SAME support to dm_kcopyd_zero
dm linear: add WRITE SAME support
dm: add WRITE SAME support
dm: prepare to support WRITE SAME
dm ioctl: use kmalloc if possible
dm ioctl: remove PF_MEMALLOC
dm persistent data: improve improve space map block alloc failure message
dm thin: use DMERR_LIMIT for errors
...
Diffstat (limited to 'drivers/md/dm-io.c')
-rw-r--r-- | drivers/md/dm-io.c | 23 |
1 files changed, 18 insertions, 5 deletions
diff --git a/drivers/md/dm-io.c b/drivers/md/dm-io.c index 1c46f97d6664..ea49834377c8 100644 --- a/drivers/md/dm-io.c +++ b/drivers/md/dm-io.c | |||
@@ -287,7 +287,8 @@ static void do_region(int rw, unsigned region, struct dm_io_region *where, | |||
287 | unsigned num_bvecs; | 287 | unsigned num_bvecs; |
288 | sector_t remaining = where->count; | 288 | sector_t remaining = where->count; |
289 | struct request_queue *q = bdev_get_queue(where->bdev); | 289 | struct request_queue *q = bdev_get_queue(where->bdev); |
290 | sector_t discard_sectors; | 290 | unsigned short logical_block_size = queue_logical_block_size(q); |
291 | sector_t num_sectors; | ||
291 | 292 | ||
292 | /* | 293 | /* |
293 | * where->count may be zero if rw holds a flush and we need to | 294 | * where->count may be zero if rw holds a flush and we need to |
@@ -297,7 +298,7 @@ static void do_region(int rw, unsigned region, struct dm_io_region *where, | |||
297 | /* | 298 | /* |
298 | * Allocate a suitably sized-bio. | 299 | * Allocate a suitably sized-bio. |
299 | */ | 300 | */ |
300 | if (rw & REQ_DISCARD) | 301 | if ((rw & REQ_DISCARD) || (rw & REQ_WRITE_SAME)) |
301 | num_bvecs = 1; | 302 | num_bvecs = 1; |
302 | else | 303 | else |
303 | num_bvecs = min_t(int, bio_get_nr_vecs(where->bdev), | 304 | num_bvecs = min_t(int, bio_get_nr_vecs(where->bdev), |
@@ -310,9 +311,21 @@ static void do_region(int rw, unsigned region, struct dm_io_region *where, | |||
310 | store_io_and_region_in_bio(bio, io, region); | 311 | store_io_and_region_in_bio(bio, io, region); |
311 | 312 | ||
312 | if (rw & REQ_DISCARD) { | 313 | if (rw & REQ_DISCARD) { |
313 | discard_sectors = min_t(sector_t, q->limits.max_discard_sectors, remaining); | 314 | num_sectors = min_t(sector_t, q->limits.max_discard_sectors, remaining); |
314 | bio->bi_size = discard_sectors << SECTOR_SHIFT; | 315 | bio->bi_size = num_sectors << SECTOR_SHIFT; |
315 | remaining -= discard_sectors; | 316 | remaining -= num_sectors; |
317 | } else if (rw & REQ_WRITE_SAME) { | ||
318 | /* | ||
319 | * WRITE SAME only uses a single page. | ||
320 | */ | ||
321 | dp->get_page(dp, &page, &len, &offset); | ||
322 | bio_add_page(bio, page, logical_block_size, offset); | ||
323 | num_sectors = min_t(sector_t, q->limits.max_write_same_sectors, remaining); | ||
324 | bio->bi_size = num_sectors << SECTOR_SHIFT; | ||
325 | |||
326 | offset = 0; | ||
327 | remaining -= num_sectors; | ||
328 | dp->next_page(dp); | ||
316 | } else while (remaining) { | 329 | } else while (remaining) { |
317 | /* | 330 | /* |
318 | * Try and add as many pages as possible. | 331 | * Try and add as many pages as possible. |