diff options
author | Joe Thornber <ejt@redhat.com> | 2014-11-24 09:05:16 -0500 |
---|---|---|
committer | Mike Snitzer <snitzer@redhat.com> | 2014-12-01 11:30:09 -0500 |
commit | 2572629a1318eb9e13e70fa59756d7bcfb80319e (patch) | |
tree | 7162438bb121f9e4c101425d36c246ce3cb5e935 /drivers/md/dm-cache-target.c | |
parent | 8001e87d0ee98787c46f14f5f4f97aced70f119f (diff) |
dm cache: fix some issues with the new discard range support
Commit 7ae34e777 ("dm cache: improve discard support") needed to also:
- discontinue having DM core split the discard bios on cache block
boundaries
- calculate the cache's discard_nr_blocks relative to the determined
discard_block_size rather than using oblock_to_dblock()
Signed-off-by: Joe Thornber <ejt@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Diffstat (limited to 'drivers/md/dm-cache-target.c')
-rw-r--r-- | drivers/md/dm-cache-target.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/md/dm-cache-target.c b/drivers/md/dm-cache-target.c index abdd45d07bf6..41e7cfdb450d 100644 --- a/drivers/md/dm-cache-target.c +++ b/drivers/md/dm-cache-target.c | |||
@@ -2338,8 +2338,7 @@ static int cache_create(struct cache_args *ca, struct cache **result) | |||
2338 | ti->num_discard_bios = 1; | 2338 | ti->num_discard_bios = 1; |
2339 | ti->discards_supported = true; | 2339 | ti->discards_supported = true; |
2340 | ti->discard_zeroes_data_unsupported = true; | 2340 | ti->discard_zeroes_data_unsupported = true; |
2341 | /* Discard bios must be split on a block boundary */ | 2341 | ti->split_discard_bios = false; |
2342 | ti->split_discard_bios = true; | ||
2343 | 2342 | ||
2344 | cache->features = ca->features; | 2343 | cache->features = ca->features; |
2345 | ti->per_bio_data_size = get_per_bio_data_size(cache); | 2344 | ti->per_bio_data_size = get_per_bio_data_size(cache); |
@@ -2440,7 +2439,8 @@ static int cache_create(struct cache_args *ca, struct cache **result) | |||
2440 | cache->discard_block_size = | 2439 | cache->discard_block_size = |
2441 | calculate_discard_block_size(cache->sectors_per_block, | 2440 | calculate_discard_block_size(cache->sectors_per_block, |
2442 | cache->origin_sectors); | 2441 | cache->origin_sectors); |
2443 | cache->discard_nr_blocks = oblock_to_dblock(cache, cache->origin_blocks); | 2442 | cache->discard_nr_blocks = to_dblock(dm_sector_div_up(cache->origin_sectors, |
2443 | cache->discard_block_size)); | ||
2444 | cache->discard_bitset = alloc_bitset(from_dblock(cache->discard_nr_blocks)); | 2444 | cache->discard_bitset = alloc_bitset(from_dblock(cache->discard_nr_blocks)); |
2445 | if (!cache->discard_bitset) { | 2445 | if (!cache->discard_bitset) { |
2446 | *error = "could not allocate discard bitset"; | 2446 | *error = "could not allocate discard bitset"; |