Merge master.kernel.org:/pub/scm/linux/kernel/git/torvalds/linux-2.6

Conflicts:

	drivers/macintosh/adbhid.c

18 files changed, 61 insertions, 290 deletions

diff --git a/drivers/macintosh/Kconfig b/drivers/macintosh/Kconfig
index 20da011d40d0..77f50b63a970 100644
--- a/drivers/macintosh/Kconfig
+++ b/drivers/macintosh/Kconfig
@@ -3,6 +3,11 @@ menuconfig MACINTOSH_DRIVERS
         bool "Macintosh device drivers"
         depends on PPC || MAC || X86
         default y if (PPC_PMAC || MAC)
+        ---help---
+          Say Y here to get to see options for devices used with Macintosh
+          computers. This option alone does not add any kernel code.
+
+          If you say N, all options in this submenu will be skipped and disabled.
 
 if MACINTOSH_DRIVERS
 
diff --git a/drivers/macintosh/adb-iop.c b/drivers/macintosh/adb-iop.c
index 17ef5d3c01b4..444696625171 100644
--- a/drivers/macintosh/adb-iop.c
+++ b/drivers/macintosh/adb-iop.c
@@ -19,7 +19,6 @@
 #include <linux/init.h>
 #include <linux/proc_fs.h>
 
-#include <asm/bootinfo.h> 
 #include <asm/macintosh.h> 
 #include <asm/macints.h> 
 #include <asm/mac_iop.h>
diff --git a/drivers/macintosh/adb.c b/drivers/macintosh/adb.c
index bc77c5e2ca9f..5c742a526082 100644
--- a/drivers/macintosh/adb.c
+++ b/drivers/macintosh/adb.c
@@ -89,7 +89,7 @@ static int sleepy_trackpad;
 static int autopoll_devs;
 int __adb_probe_sync;
 
-#ifdef CONFIG_PM
+#ifdef CONFIG_PM_SLEEP
 static void adb_notify_sleep(struct pmu_sleep_notifier *self, int when);
 static struct pmu_sleep_notifier adb_sleep_notifier = {
         adb_notify_sleep,
@@ -313,7 +313,7 @@ int __init adb_init(void)
                 printk(KERN_WARNING "Warning: no ADB interface detected\n");
                 adb_controller = NULL;
         } else {
-#ifdef CONFIG_PM
+#ifdef CONFIG_PM_SLEEP
                 pmu_register_sleep_notifier(&adb_sleep_notifier);
 #endif /* CONFIG_PM */
 #ifdef CONFIG_PPC
diff --git a/drivers/macintosh/adbhid.c b/drivers/macintosh/adbhid.c
index 9ff2189d2e2a..8cce016b3d09 100644
--- a/drivers/macintosh/adbhid.c
+++ b/drivers/macintosh/adbhid.c
@@ -75,7 +75,7 @@ static struct notifier_block adbhid_adb_notifier = {
 #define ADB_KEY_POWER_OLD       0x7e
 #define ADB_KEY_POWER           0x7f
 
-u8 adb_to_linux_keycodes[128] = {
+u16 adb_to_linux_keycodes[128] = {
         /* 0x00 */ KEY_A,               /*  30 */
         /* 0x01 */ KEY_S,               /*  31 */
         /* 0x02 */ KEY_D,               /*  32 */
@@ -139,7 +139,7 @@ u8 adb_to_linux_keycodes[128] = {
         /* 0x3c */ KEY_RIGHT,           /* 106 */
         /* 0x3d */ KEY_DOWN,            /* 108 */
         /* 0x3e */ KEY_UP,              /* 103 */
-        /* 0x3f */ 0,
+        /* 0x3f */ KEY_FN,              /* 0x1d0 */
         /* 0x40 */ 0,
         /* 0x41 */ KEY_KPDOT,           /*  83 */
         /* 0x42 */ 0,
@@ -213,7 +213,7 @@ struct adbhid {
         int original_handler_id;
         int current_handler_id;
         int mouse_kind;
-        unsigned char *keycode;
+        u16 *keycode;
         char name[64];
         char phys[32];
         int flags;
@@ -334,7 +334,7 @@ adbhid_input_keycode(int id, int scancode, int repeat)
                         keycode = ADB_KEY_POWER;
                 }
                 break;
-        case ADB_KEY_POWER: 
+        case ADB_KEY_POWER:
                 /* Fn + Command will produce a bogus "power" keycode */
                 if (ahid->flags & FLAG_FN_KEY_PRESSED) {
                         keycode = ADB_KEY_CMD;
@@ -359,8 +359,7 @@ adbhid_input_keycode(int id, int scancode, int repeat)
                         }
                 } else
                         ahid->flags |= FLAG_FN_KEY_PRESSED;
-                /* Swallow the key press */
-                return;
+                break;
         case ADB_KEY_DEL:
                 /* Emulate Fn+delete = forward delete */
                 if (ahid->flags & FLAG_FN_KEY_PRESSED) {
@@ -374,9 +373,9 @@ adbhid_input_keycode(int id, int scancode, int repeat)
 #endif /* CONFIG_PPC_PMAC */
         }
 
-        if (adbhid[id]->keycode[keycode]) {
-                input_report_key(adbhid[id]->input,
-                                 adbhid[id]->keycode[keycode], !up_flag);
+        key = adbhid[id]->keycode[keycode];
+        if (key) {
+                input_report_key(adbhid[id]->input, key, !up_flag);
                 input_sync(adbhid[id]->input);
         } else
                 printk(KERN_INFO "Unhandled ADB key (scancode %#02x) %s.\n", keycode,
@@ -795,8 +794,8 @@ adbhid_input_register(int id, int default_id, int original_handler_id,
                 input_dev->evbit[0] = BIT(EV_KEY) | BIT(EV_LED) | BIT(EV_REP);
                 input_dev->ledbit[0] = BIT(LED_SCROLLL) | BIT(LED_CAPSL) | BIT(LED_NUML);
                 input_dev->event = adbhid_kbd_event;
-                input_dev->keycodemax = 127;
-                input_dev->keycodesize = 1;
+                input_dev->keycodemax = KEY_FN;
+                input_dev->keycodesize = sizeof(hid->keycode[0]);
                 break;
 
         case ADB_MOUSE:
diff --git a/drivers/macintosh/ans-lcd.c b/drivers/macintosh/ans-lcd.c
index e54c4d9f6365..73c50bc02095 100644
--- a/drivers/macintosh/ans-lcd.c
+++ b/drivers/macintosh/ans-lcd.c
@@ -14,9 +14,10 @@
 #include <asm/uaccess.h>
 #include <asm/sections.h>
 #include <asm/prom.h>
-#include <asm/ans-lcd.h>
 #include <asm/io.h>
 
+#include "ans-lcd.h"
+
 #define ANSLCD_ADDR             0xf301c000
 #define ANSLCD_CTRL_IX 0x00
 #define ANSLCD_DATA_IX 0x10
diff --git a/drivers/macintosh/ans-lcd.h b/drivers/macintosh/ans-lcd.h
new file mode 100644
index 000000000000..d795b9fd2db6
--- /dev/null
+++ b/drivers/macintosh/ans-lcd.h
@@ -0,0 +1,11 @@
+#ifndef _PPC_ANS_LCD_H
+#define _PPC_ANS_LCD_H
+
+#define ANSLCD_MINOR            156
+
+#define ANSLCD_CLEAR            0x01
+#define ANSLCD_SENDCTRL         0x02
+#define ANSLCD_SETSHORTDELAY    0x03
+#define ANSLCD_SETLONGDELAY     0x04
+
+#endif
diff --git a/drivers/macintosh/mac_hid.c b/drivers/macintosh/mac_hid.c
index 76c1e8e4a487..33dee3a773ed 100644
--- a/drivers/macintosh/mac_hid.c
+++ b/drivers/macintosh/mac_hid.c
@@ -13,6 +13,7 @@
 #include <linux/sysctl.h>
 #include <linux/input.h>
 #include <linux/module.h>
+#include <linux/kbd_kern.h>
 
 
 static struct input_dev *emumousebtn;
diff --git a/drivers/macintosh/macio_asic.c b/drivers/macintosh/macio_asic.c
index c96b7fe882a4..ec9e5f32f0ae 100644
--- a/drivers/macintosh/macio_asic.c
+++ b/drivers/macintosh/macio_asic.c
@@ -365,10 +365,9 @@ static struct macio_dev * macio_add_one_device(struct macio_chip *chip,
         if (np == NULL)
                 return NULL;
 
-        dev = kmalloc(sizeof(*dev), GFP_KERNEL);
+        dev = kzalloc(sizeof(*dev), GFP_KERNEL);
         if (!dev)
                 return NULL;
-        memset(dev, 0, sizeof(*dev));
 
         dev->bus = &chip->lbus;
         dev->media_bay = in_bay;
diff --git a/drivers/macintosh/rack-meter.c b/drivers/macintosh/rack-meter.c
index 4177ff004753..2c21d4f25cc8 100644
--- a/drivers/macintosh/rack-meter.c
+++ b/drivers/macintosh/rack-meter.c
@@ -30,7 +30,6 @@
 #include <asm/machdep.h>
 #include <asm/pmac_feature.h>
 #include <asm/dbdma.h>
-#include <asm/dbdma.h>
 #include <asm/macio.h>
 #include <asm/keylargo.h>
 
diff --git a/drivers/macintosh/smu.c b/drivers/macintosh/smu.c
index f8e1a135bf9d..d409f6759482 100644
--- a/drivers/macintosh/smu.c
+++ b/drivers/macintosh/smu.c
@@ -1053,10 +1053,9 @@ static int smu_open(struct inode *inode, struct file *file)
         struct smu_private *pp;
         unsigned long flags;
 
-        pp = kmalloc(sizeof(struct smu_private), GFP_KERNEL);
+        pp = kzalloc(sizeof(struct smu_private), GFP_KERNEL);
         if (pp == 0)
                 return -ENOMEM;
-        memset(pp, 0, sizeof(struct smu_private));
         spin_lock_init(&pp->lock);
         pp->mode = smu_file_commands;
         init_waitqueue_head(&pp->wait);
diff --git a/drivers/macintosh/therm_adt746x.c b/drivers/macintosh/therm_adt746x.c
index f25685b9b7cf..276945d51513 100644
--- a/drivers/macintosh/therm_adt746x.c
+++ b/drivers/macintosh/therm_adt746x.c
@@ -379,13 +379,10 @@ static int attach_one_thermostat(struct i2c_adapter *adapter, int addr,
         if (thermostat)
                 return 0;
 
-        th = (struct thermostat *)
-                kmalloc(sizeof(struct thermostat), GFP_KERNEL);
-
+        th = kzalloc(sizeof(struct thermostat), GFP_KERNEL);
         if (!th)
                 return -ENOMEM;
 
-        memset(th, 0, sizeof(*th));
         th->clt.addr = addr;
         th->clt.adapter = adapter;
         th->clt.driver = &thermostat_driver;
diff --git a/drivers/macintosh/therm_pm72.c b/drivers/macintosh/therm_pm72.c
index dbb22403979f..e43554e754a4 100644
--- a/drivers/macintosh/therm_pm72.c
+++ b/drivers/macintosh/therm_pm72.c
@@ -318,10 +318,9 @@ static struct i2c_client *attach_i2c_chip(int id, const char *name)
         if (adap == NULL)
                 return NULL;
 
-        clt = kmalloc(sizeof(struct i2c_client), GFP_KERNEL);
+        clt = kzalloc(sizeof(struct i2c_client), GFP_KERNEL);
         if (clt == NULL)
                 return NULL;
-        memset(clt, 0, sizeof(struct i2c_client));
 
         clt->addr = (id >> 1) & 0x7f;
         clt->adapter = adap;
@@ -1770,7 +1769,8 @@ static int call_critical_overtemp(void)
                                 "PATH=/sbin:/usr/sbin:/bin:/usr/bin",
                                 NULL };
 
-        return call_usermodehelper(critical_overtemp_path, argv, envp, 0);
+        return call_usermodehelper(critical_overtemp_path,
+                                   argv, envp, UMH_WAIT_EXEC);
 }
 
 
diff --git a/drivers/macintosh/therm_windtunnel.c b/drivers/macintosh/therm_windtunnel.c
index 3d0354e96a97..5452da1bb1a5 100644
--- a/drivers/macintosh/therm_windtunnel.c
+++ b/drivers/macintosh/therm_windtunnel.c
@@ -431,9 +431,8 @@ do_probe( struct i2c_adapter *adapter, int addr, int kind )
                                      | I2C_FUNC_SMBUS_WRITE_BYTE) )
                 return 0;
 
-        if( !(cl=kmalloc(sizeof(*cl), GFP_KERNEL)) )
+        if( !(cl=kzalloc(sizeof(*cl), GFP_KERNEL)) )
                 return -ENOMEM;
-        memset( cl, 0, sizeof(struct i2c_client) );
 
         cl->addr = addr;
         cl->adapter = adapter;
diff --git a/drivers/macintosh/via-pmu.c b/drivers/macintosh/via-pmu.c
index 157080b3b468..f7c509b7a8ea 100644
--- a/drivers/macintosh/via-pmu.c
+++ b/drivers/macintosh/via-pmu.c
@@ -152,10 +152,10 @@ static spinlock_t pmu_lock;
 static u8 pmu_intr_mask;
 static int pmu_version;
 static int drop_interrupts;
-#if defined(CONFIG_PM) && defined(CONFIG_PPC32)
+#if defined(CONFIG_PM_SLEEP) && defined(CONFIG_PPC32)
 static int option_lid_wakeup = 1;
-#endif /* CONFIG_PM && CONFIG_PPC32 */
-#if (defined(CONFIG_PM)&&defined(CONFIG_PPC32))||defined(CONFIG_PMAC_BACKLIGHT_LEGACY)
+#endif /* CONFIG_PM_SLEEP && CONFIG_PPC32 */
+#if (defined(CONFIG_PM_SLEEP)&&defined(CONFIG_PPC32))||defined(CONFIG_PMAC_BACKLIGHT_LEGACY)
 static int sleep_in_progress;
 #endif
 static unsigned long async_req_locks;
@@ -410,7 +410,7 @@ static int __init via_pmu_start(void)
 
         irq = irq_of_parse_and_map(vias, 0);
         if (irq == NO_IRQ) {
-                printk(KERN_ERR "via-pmu: can't map interruptn");
+                printk(KERN_ERR "via-pmu: can't map interrupt\n");
                 return -ENODEV;
         }
         if (request_irq(irq, via_pmu_interrupt, 0, "VIA-PMU", (void *)0)) {
@@ -875,7 +875,7 @@ proc_read_options(char *page, char **start, off_t off,
 {
         char *p = page;
 
-#if defined(CONFIG_PM) && defined(CONFIG_PPC32)
+#if defined(CONFIG_PM_SLEEP) && defined(CONFIG_PPC32)
         if (pmu_kind == PMU_KEYLARGO_BASED &&
             pmac_call_feature(PMAC_FTR_SLEEP_STATE,NULL,0,-1) >= 0)
                 p += sprintf(p, "lid_wakeup=%d\n", option_lid_wakeup);
@@ -916,7 +916,7 @@ proc_write_options(struct file *file, const char __user *buffer,
         *(val++) = 0;
         while(*val == ' ')
                 val++;
-#if defined(CONFIG_PM) && defined(CONFIG_PPC32)
+#if defined(CONFIG_PM_SLEEP) && defined(CONFIG_PPC32)
         if (pmu_kind == PMU_KEYLARGO_BASED &&
             pmac_call_feature(PMAC_FTR_SLEEP_STATE,NULL,0,-1) >= 0)
                 if (!strcmp(label, "lid_wakeup"))
@@ -1738,7 +1738,7 @@ pmu_present(void)
         return via != 0;
 }
 
-#ifdef CONFIG_PM
+#ifdef CONFIG_PM_SLEEP
 
 static LIST_HEAD(sleep_notifiers);
 
@@ -1769,9 +1769,9 @@ pmu_unregister_sleep_notifier(struct pmu_sleep_notifier* n)
         return 0;
 }
 EXPORT_SYMBOL(pmu_unregister_sleep_notifier);
-#endif /* CONFIG_PM */
+#endif /* CONFIG_PM_SLEEP */
 
-#if defined(CONFIG_PM) && defined(CONFIG_PPC32)
+#if defined(CONFIG_PM_SLEEP) && defined(CONFIG_PPC32)
 
 /* Sleep is broadcast last-to-first */
 static void broadcast_sleep(int when)
@@ -2390,7 +2390,7 @@ powerbook_sleep_3400(void)
         return 0;
 }
 
-#endif /* CONFIG_PM && CONFIG_PPC32 */
+#endif /* CONFIG_PM_SLEEP && CONFIG_PPC32 */
 
 /*
  * Support for /dev/pmu device
@@ -2573,7 +2573,7 @@ pmu_ioctl(struct inode * inode, struct file *filp,
         int error = -EINVAL;
 
         switch (cmd) {
-#if defined(CONFIG_PM) && defined(CONFIG_PPC32)
+#if defined(CONFIG_PM_SLEEP) && defined(CONFIG_PPC32)
         case PMU_IOC_SLEEP:
                 if (!capable(CAP_SYS_ADMIN))
                         return -EACCES;
@@ -2601,7 +2601,7 @@ pmu_ioctl(struct inode * inode, struct file *filp,
                         return put_user(0, argp);
                 else
                         return put_user(1, argp);
-#endif /* CONFIG_PM && CONFIG_PPC32 */
+#endif /* CONFIG_PM_SLEEP && CONFIG_PPC32 */
 
 #ifdef CONFIG_PMAC_BACKLIGHT_LEGACY
         /* Compatibility ioctl's for backlight */
@@ -2757,7 +2757,7 @@ pmu_polled_request(struct adb_request *req)
  * to do suspend-to-disk.
  */
 
-#if defined(CONFIG_PM) && defined(CONFIG_PPC32)
+#if defined(CONFIG_PM_SLEEP) && defined(CONFIG_PPC32)
 
 int pmu_sys_suspended;
 
@@ -2792,7 +2792,7 @@ static int pmu_sys_resume(struct sys_device *sysdev)
         return 0;
 }
 
-#endif /* CONFIG_PM && CONFIG_PPC32 */
+#endif /* CONFIG_PM_SLEEP && CONFIG_PPC32 */
 
 static struct sysdev_class pmu_sysclass = {
         set_kset_name("pmu"),
@@ -2803,10 +2803,10 @@ static struct sys_device device_pmu = {
 };
 
 static struct sysdev_driver driver_pmu = {
-#if defined(CONFIG_PM) && defined(CONFIG_PPC32)
+#if defined(CONFIG_PM_SLEEP) && defined(CONFIG_PPC32)
         .suspend        = &pmu_sys_suspend,
         .resume         = &pmu_sys_resume,
-#endif /* CONFIG_PM && CONFIG_PPC32 */
+#endif /* CONFIG_PM_SLEEP && CONFIG_PPC32 */
 };
 
 static int __init init_pmu_sysfs(void)
@@ -2841,10 +2841,10 @@ EXPORT_SYMBOL(pmu_wait_complete);
 EXPORT_SYMBOL(pmu_suspend);
 EXPORT_SYMBOL(pmu_resume);
 EXPORT_SYMBOL(pmu_unlock);
-#if defined(CONFIG_PM) && defined(CONFIG_PPC32)
+#if defined(CONFIG_PM_SLEEP) && defined(CONFIG_PPC32)
 EXPORT_SYMBOL(pmu_enable_irled);
 EXPORT_SYMBOL(pmu_battery_count);
 EXPORT_SYMBOL(pmu_batteries);
 EXPORT_SYMBOL(pmu_power_flags);
-#endif /* CONFIG_PM && CONFIG_PPC32 */
+#endif /* CONFIG_PM_SLEEP && CONFIG_PPC32 */
 
diff --git a/drivers/macintosh/via-pmu68k.c b/drivers/macintosh/via-pmu68k.c
index dfdf11c1eec4..e2f84da09e7c 100644
--- a/drivers/macintosh/via-pmu68k.c
+++ b/drivers/macintosh/via-pmu68k.c
@@ -818,243 +818,3 @@ pmu_present(void)
 {
         return (pmu_kind != PMU_UNKNOWN);
 }
-
-#if 0 /* needs some work for 68K */
-
-/*
- * This struct is used to store config register values for
- * PCI devices which may get powered off when we sleep.
- */
-static struct pci_save {
-        u16     command;
-        u16     cache_lat;
-        u16     intr;
-} *pbook_pci_saves;
-static int n_pbook_pci_saves;
-
-static inline void
-pbook_pci_save(void)
-{
-        int npci;
-        struct pci_dev *pd = NULL;
-        struct pci_save *ps;
-
-        npci = 0;
-        while ((pd = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, pd)) != NULL)
-                ++npci;
-        n_pbook_pci_saves = npci;
-        if (npci == 0)
-                return;
-        ps = kmalloc(npci * sizeof(*ps), GFP_KERNEL);
-        pbook_pci_saves = ps;
-        if (ps == NULL)
-                return;
-
-        pd = NULL;
-        while ((pd = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, pd)) != NULL) {
-                pci_read_config_word(pd, PCI_COMMAND, &ps->command);
-                pci_read_config_word(pd, PCI_CACHE_LINE_SIZE, &ps->cache_lat);
-                pci_read_config_word(pd, PCI_INTERRUPT_LINE, &ps->intr);
-                ++ps;
-                --npci;
-        }
-}
-
-static inline void
-pbook_pci_restore(void)
-{
-        u16 cmd;
-        struct pci_save *ps = pbook_pci_saves;
-        struct pci_dev *pd = NULL;
-        int j;
-
-        while ((pd = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, pd)) != NULL) {
-                if (ps->command == 0)
-                        continue;
-                pci_read_config_word(pd, PCI_COMMAND, &cmd);
-                if ((ps->command & ~cmd) == 0)
-                        continue;
-                switch (pd->hdr_type) {
-                case PCI_HEADER_TYPE_NORMAL:
-                        for (j = 0; j < 6; ++j)
-                                pci_write_config_dword(pd,
-                                        PCI_BASE_ADDRESS_0 + j*4,
-                                        pd->resource[j].start);
-                        pci_write_config_dword(pd, PCI_ROM_ADDRESS,
-                               pd->resource[PCI_ROM_RESOURCE].start);
-                        pci_write_config_word(pd, PCI_CACHE_LINE_SIZE,
-                                ps->cache_lat);
-                        pci_write_config_word(pd, PCI_INTERRUPT_LINE,
-                                ps->intr);
-                        pci_write_config_word(pd, PCI_COMMAND, ps->command);
-                        break;
-                        /* other header types not restored at present */
-                }
-        }
-}
-
-/*
- * Put the powerbook to sleep.
- */
-#define IRQ_ENABLE      ((unsigned int *)0xf3000024)
-#define MEM_CTRL        ((unsigned int *)0xf8000070)
-
-int powerbook_sleep(void)
-{
-        int ret, i, x;
-        static int save_backlight;
-        static unsigned int save_irqen;
-        unsigned long msr;
-        unsigned int hid0;
-        unsigned long p, wait;
-        struct adb_request sleep_req;
-
-        /* Notify device drivers */
-        ret = blocking_notifier_call_chain(&sleep_notifier_list,
-                        PBOOK_SLEEP, NULL);
-        if (ret & NOTIFY_STOP_MASK)
-                return -EBUSY;
-
-        /* Sync the disks. */
-        /* XXX It would be nice to have some way to ensure that
-         * nobody is dirtying any new buffers while we wait. */
-        sys_sync();
-
-        /* Turn off the display backlight */
-        save_backlight = backlight_enabled;
-        if (save_backlight)
-                pmu_enable_backlight(0);
-
-        /* Give the disks a little time to actually finish writing */
-        for (wait = jiffies + (HZ/4); time_before(jiffies, wait); )
-                mb();
-
-        /* Disable all interrupts except pmu */
-        save_irqen = in_le32(IRQ_ENABLE);
-        for (i = 0; i < 32; ++i)
-                if (i != vias->intrs[0].line && (save_irqen & (1 << i)))
-                        disable_irq(i);
-        asm volatile("mtdec %0" : : "r" (0x7fffffff));
-
-        /* Save the state of PCI config space for some slots */
-        pbook_pci_save();
-
-        /* Set the memory controller to keep the memory refreshed
-           while we're asleep */
-        for (i = 0x403f; i >= 0x4000; --i) {
-                out_be32(MEM_CTRL, i);
-                do {
-                        x = (in_be32(MEM_CTRL) >> 16) & 0x3ff;
-                } while (x == 0);
-                if (x >= 0x100)
-                        break;
-        }
-
-        /* Ask the PMU to put us to sleep */
-        pmu_request(&sleep_req, NULL, 5, PMU_SLEEP, 'M', 'A', 'T', 'T');
-        while (!sleep_req.complete)
-                mb();
-        /* displacement-flush the L2 cache - necessary? */
-        for (p = KERNELBASE; p < KERNELBASE + 0x100000; p += 0x1000)
-                i = *(volatile int *)p;
-        asleep = 1;
-
-        /* Put the CPU into sleep mode */
-        asm volatile("mfspr %0,1008" : "=r" (hid0) :);
-        hid0 = (hid0 & ~(HID0_NAP | HID0_DOZE)) | HID0_SLEEP;
-        asm volatile("mtspr 1008,%0" : : "r" (hid0));
-        local_save_flags(msr);
-        msr |= MSR_POW | MSR_EE;
-        local_irq_restore(msr);
-        udelay(10);
-
-        /* OK, we're awake again, start restoring things */
-        out_be32(MEM_CTRL, 0x3f);
-        pbook_pci_restore();
-
-        /* wait for the PMU interrupt sequence to complete */
-        while (asleep)
-                mb();
-
-        /* reenable interrupts */
-        for (i = 0; i < 32; ++i)
-                if (i != vias->intrs[0].line && (save_irqen & (1 << i)))
-                        enable_irq(i);
-
-        /* Notify drivers */
-        blocking_notifier_call_chain(&sleep_notifier_list, PBOOK_WAKE, NULL);
-
-        /* reenable ADB autopoll */
-        pmu_adb_autopoll(adb_dev_map);
-
-        /* Turn on the screen backlight, if it was on before */
-        if (save_backlight)
-                pmu_enable_backlight(1);
-
-        /* Wait for the hard disk to spin up */
-
-        return 0;
-}
-
-/*
- * Support for /dev/pmu device
- */
-static int pmu_open(struct inode *inode, struct file *file)
-{
-        return 0;
-}
-
-static ssize_t pmu_read(struct file *file, char *buf,
-                        size_t count, loff_t *ppos)
-{
-        return 0;
-}
-
-static ssize_t pmu_write(struct file *file, const char *buf,
-                         size_t count, loff_t *ppos)
-{
-        return 0;
-}
-
-static int pmu_ioctl(struct inode * inode, struct file *filp,
-                     u_int cmd, u_long arg)
-{
-        int error;
-        __u32 value;
-
-        switch (cmd) {
-            case PMU_IOC_SLEEP:
-                return -ENOSYS;
-            case PMU_IOC_GET_BACKLIGHT:
-                return put_user(backlight_level, (__u32 *)arg);
-            case PMU_IOC_SET_BACKLIGHT:
-                error = get_user(value, (__u32 *)arg);
-                if (!error)
-                        pmu_set_brightness(value);
-                return error;
-            case PMU_IOC_GET_MODEL:
-                return put_user(pmu_kind, (__u32 *)arg);
-        }
-        return -EINVAL;
-}
-
-static const struct file_operations pmu_device_fops = {
-        .read           = pmu_read,
-        .write          = pmu_write,
-        .ioctl          = pmu_ioctl,
-        .open           = pmu_open,
-};
-
-static struct miscdevice pmu_device = {
-        PMU_MINOR, "pmu", &pmu_device_fops
-};
-
-void pmu_device_init(void)
-{
-        if (!via)
-                return;
-        if (misc_register(&pmu_device) < 0)
-                printk(KERN_ERR "via-pmu68k: cannot register misc device.\n");
-}
-#endif /* CONFIG_PMAC_PBOOK */
-
diff --git a/drivers/macintosh/windfarm_core.c b/drivers/macintosh/windfarm_core.c
index e18d265d5d33..516d943227e2 100644
--- a/drivers/macintosh/windfarm_core.c
+++ b/drivers/macintosh/windfarm_core.c
@@ -80,7 +80,8 @@ int wf_critical_overtemp(void)
                                 "PATH=/sbin:/usr/sbin:/bin:/usr/bin",
                                 NULL };
 
-        return call_usermodehelper(critical_overtemp_path, argv, envp, 0);
+        return call_usermodehelper(critical_overtemp_path,
+                                   argv, envp, UMH_WAIT_EXEC);
 }
 EXPORT_SYMBOL_GPL(wf_critical_overtemp);
 
diff --git a/drivers/macintosh/windfarm_lm75_sensor.c b/drivers/macintosh/windfarm_lm75_sensor.c
index a0fabf3c2008..7e10c3ab4d50 100644
--- a/drivers/macintosh/windfarm_lm75_sensor.c
+++ b/drivers/macintosh/windfarm_lm75_sensor.c
@@ -117,10 +117,9 @@ static struct wf_lm75_sensor *wf_lm75_create(struct i2c_adapter *adapter,
         DBG("wf_lm75: creating  %s device at address 0x%02x\n",
             ds1775 ? "ds1775" : "lm75", addr);
 
-        lm = kmalloc(sizeof(struct wf_lm75_sensor), GFP_KERNEL);
+        lm = kzalloc(sizeof(struct wf_lm75_sensor), GFP_KERNEL);
         if (lm == NULL)
                 return NULL;
-        memset(lm, 0, sizeof(struct wf_lm75_sensor));
 
         /* Usual rant about sensor names not beeing very consistent in
          * the device-tree, oh well ...
diff --git a/drivers/macintosh/windfarm_smu_sat.c b/drivers/macintosh/windfarm_smu_sat.c
index 351982bcec1b..f449d775cdf4 100644
--- a/drivers/macintosh/windfarm_smu_sat.c
+++ b/drivers/macintosh/windfarm_smu_sat.c
@@ -380,10 +380,12 @@ static int __init sat_sensors_init(void)
         return i2c_add_driver(&wf_sat_driver);
 }
 
+#if 0   /* uncomment when module_exit() below is uncommented */
 static void __exit sat_sensors_exit(void)
 {
         i2c_del_driver(&wf_sat_driver);
 }
+#endif
 
 module_init(sat_sensors_init);
 /*module_exit(sat_sensors_exit); Uncomment when cleanup is implemented */