diff options
author | Peter Zijlstra <a.p.zijlstra@chello.nl> | 2006-10-01 02:28:10 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-10-01 03:39:24 -0400 |
commit | 6e9a4738c9fadb7cbdcabc1e3b415159f3741ed9 (patch) | |
tree | 0e470bb8cd431d59698da5a6999ff35a347619a3 /drivers/macintosh | |
parent | 397d6140e93156ecb9cafcd9be0db10ff3c12ab3 (diff) |
[PATCH] completions: lockdep annotate on stack completions
All on stack DECLARE_COMPLETIONs should be replaced by:
DECLARE_COMPLETION_ONSTACK
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Acked-by: Ingo Molnar <mingo@elte.hu>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'drivers/macintosh')
-rw-r--r-- | drivers/macintosh/smu.c | 4 | ||||
-rw-r--r-- | drivers/macintosh/windfarm_smu_controls.c | 2 | ||||
-rw-r--r-- | drivers/macintosh/windfarm_smu_sensors.c | 2 |
3 files changed, 4 insertions, 4 deletions
diff --git a/drivers/macintosh/smu.c b/drivers/macintosh/smu.c index 090e40fc5013..c0f9d82e4662 100644 --- a/drivers/macintosh/smu.c +++ b/drivers/macintosh/smu.c | |||
@@ -870,7 +870,7 @@ int smu_queue_i2c(struct smu_i2c_cmd *cmd) | |||
870 | 870 | ||
871 | static int smu_read_datablock(u8 *dest, unsigned int addr, unsigned int len) | 871 | static int smu_read_datablock(u8 *dest, unsigned int addr, unsigned int len) |
872 | { | 872 | { |
873 | DECLARE_COMPLETION(comp); | 873 | DECLARE_COMPLETION_ONSTACK(comp); |
874 | unsigned int chunk; | 874 | unsigned int chunk; |
875 | struct smu_cmd cmd; | 875 | struct smu_cmd cmd; |
876 | int rc; | 876 | int rc; |
@@ -917,7 +917,7 @@ static int smu_read_datablock(u8 *dest, unsigned int addr, unsigned int len) | |||
917 | 917 | ||
918 | static struct smu_sdbp_header *smu_create_sdb_partition(int id) | 918 | static struct smu_sdbp_header *smu_create_sdb_partition(int id) |
919 | { | 919 | { |
920 | DECLARE_COMPLETION(comp); | 920 | DECLARE_COMPLETION_ONSTACK(comp); |
921 | struct smu_simple_cmd cmd; | 921 | struct smu_simple_cmd cmd; |
922 | unsigned int addr, len, tlen; | 922 | unsigned int addr, len, tlen; |
923 | struct smu_sdbp_header *hdr; | 923 | struct smu_sdbp_header *hdr; |
diff --git a/drivers/macintosh/windfarm_smu_controls.c b/drivers/macintosh/windfarm_smu_controls.c index bff1f372f188..31b750d61206 100644 --- a/drivers/macintosh/windfarm_smu_controls.c +++ b/drivers/macintosh/windfarm_smu_controls.c | |||
@@ -56,7 +56,7 @@ static int smu_set_fan(int pwm, u8 id, u16 value) | |||
56 | { | 56 | { |
57 | struct smu_cmd cmd; | 57 | struct smu_cmd cmd; |
58 | u8 buffer[16]; | 58 | u8 buffer[16]; |
59 | DECLARE_COMPLETION(comp); | 59 | DECLARE_COMPLETION_ONSTACK(comp); |
60 | int rc; | 60 | int rc; |
61 | 61 | ||
62 | /* Fill SMU command structure */ | 62 | /* Fill SMU command structure */ |
diff --git a/drivers/macintosh/windfarm_smu_sensors.c b/drivers/macintosh/windfarm_smu_sensors.c index defe9922ebd1..01b4c50143dd 100644 --- a/drivers/macintosh/windfarm_smu_sensors.c +++ b/drivers/macintosh/windfarm_smu_sensors.c | |||
@@ -67,7 +67,7 @@ static void smu_ads_release(struct wf_sensor *sr) | |||
67 | static int smu_read_adc(u8 id, s32 *value) | 67 | static int smu_read_adc(u8 id, s32 *value) |
68 | { | 68 | { |
69 | struct smu_simple_cmd cmd; | 69 | struct smu_simple_cmd cmd; |
70 | DECLARE_COMPLETION(comp); | 70 | DECLARE_COMPLETION_ONSTACK(comp); |
71 | int rc; | 71 | int rc; |
72 | 72 | ||
73 | rc = smu_queue_simple(&cmd, SMU_CMD_READ_ADC, 1, | 73 | rc = smu_queue_simple(&cmd, SMU_CMD_READ_ADC, 1, |