diff options
author | Aaro Koskinen <aaro.koskinen@iki.fi> | 2013-07-20 20:30:11 -0400 |
---|---|---|
committer | Benjamin Herrenschmidt <benh@kernel.crashing.org> | 2013-07-31 23:11:47 -0400 |
commit | fe956a1d4081ce1a959f87df397a15e252201f10 (patch) | |
tree | 236b73915ded48c90f525223c541d0460ba5c03c /drivers/macintosh | |
parent | 3be7db6ab45b21345386d1a466da133b19cde5e4 (diff) |
powerpc/windfarm: Fix noisy slots-fan on Xserve (rm31)
slots-fan on G5 Xserve is always running at full speed with windfarm_rm31
driver, resulting in a very high acoustic noise level. It seems the fan
parameters are incorrect, and have been copied from the Drive Bay fan
(RPM, not present on rm31) of the legacy therm_pm72 driver. This patch
changes the parameters to match the Slots fan (PWM) of therm_pm72. With
the patch, slots-fan speed drops from 99% to 19% during normal use,
and slots-temp settle to ~42'C.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
CC: <stable@vger.kernel.org>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Diffstat (limited to 'drivers/macintosh')
-rw-r--r-- | drivers/macintosh/windfarm_rm31.c | 18 |
1 files changed, 9 insertions, 9 deletions
diff --git a/drivers/macintosh/windfarm_rm31.c b/drivers/macintosh/windfarm_rm31.c index 0b9a79b2f48a..82fc86a90c1a 100644 --- a/drivers/macintosh/windfarm_rm31.c +++ b/drivers/macintosh/windfarm_rm31.c | |||
@@ -439,15 +439,15 @@ static void backside_setup_pid(void) | |||
439 | 439 | ||
440 | /* Slots fan */ | 440 | /* Slots fan */ |
441 | static const struct wf_pid_param slots_param = { | 441 | static const struct wf_pid_param slots_param = { |
442 | .interval = 5, | 442 | .interval = 1, |
443 | .history_len = 2, | 443 | .history_len = 20, |
444 | .gd = 30 << 20, | 444 | .gd = 0, |
445 | .gp = 5 << 20, | 445 | .gp = 0, |
446 | .gr = 0, | 446 | .gr = 0x00100000, |
447 | .itarget = 40 << 16, | 447 | .itarget = 3200000, |
448 | .additive = 1, | 448 | .additive = 0, |
449 | .min = 300, | 449 | .min = 20, |
450 | .max = 4000, | 450 | .max = 100, |
451 | }; | 451 | }; |
452 | 452 | ||
453 | static void slots_fan_tick(void) | 453 | static void slots_fan_tick(void) |