diff options
| author | David Woodhouse <dwmw2@infradead.org> | 2006-09-29 04:58:37 -0400 |
|---|---|---|
| committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-09-29 12:18:03 -0400 |
| commit | 4efd587bf9f9a97608b1fcecc78a4a046c37e9b1 (patch) | |
| tree | ee626d2ce4af18c0296df3f257079b76f71ae76d /drivers/macintosh | |
| parent | 910067d188d56d80801b71b0ca1f73aa400c7b8c (diff) | |
[PATCH] Fix uninitialised spinlock in via-pmu-backlight code.
The uninitialised pmu_backlight_lock causes the current Fedora test kernel
(which has spinlock debugging enabled) to panic on suspend.
This is suboptimal, so I fixed it.
Signed-off-by: David Woodhouse <dwmw2@infradead.org>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Acked-by: Michael Hanselmann <linux-kernel@hansmi.ch>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'drivers/macintosh')
| -rw-r--r-- | drivers/macintosh/via-pmu-backlight.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/macintosh/via-pmu-backlight.c b/drivers/macintosh/via-pmu-backlight.c index a82f313d9dc9..6c29fe727c0f 100644 --- a/drivers/macintosh/via-pmu-backlight.c +++ b/drivers/macintosh/via-pmu-backlight.c | |||
| @@ -16,7 +16,7 @@ | |||
| 16 | #define MAX_PMU_LEVEL 0xFF | 16 | #define MAX_PMU_LEVEL 0xFF |
| 17 | 17 | ||
| 18 | static struct backlight_properties pmu_backlight_data; | 18 | static struct backlight_properties pmu_backlight_data; |
| 19 | static spinlock_t pmu_backlight_lock; | 19 | static DEFINE_SPINLOCK(pmu_backlight_lock); |
| 20 | static int sleeping; | 20 | static int sleeping; |
| 21 | static u8 bl_curve[FB_BACKLIGHT_LEVELS]; | 21 | static u8 bl_curve[FB_BACKLIGHT_LEVELS]; |
| 22 | 22 | ||