diff options
author | Josef Bacik <josef@redhat.com> | 2011-07-18 13:21:39 -0400 |
---|---|---|
committer | Al Viro <viro@zeniv.linux.org.uk> | 2011-07-20 20:47:58 -0400 |
commit | 22735068d53c7115e384bc88dea95b17e76a6839 (patch) | |
tree | c531b0ca2ccf472c8abfede626535fcf07357624 /drivers/macintosh/nvram.c | |
parent | 06222e491e663dac939f04b125c9dc52126a75c4 (diff) |
drivers: fix up various ->llseek() implementations
Fix up a few ->llseek() implementations that won't deal with SEEK_HOLE/SEEK_DATA
properly. Make them future proof so that if we ever add new options they will
return -EINVAL. Thanks,
Signed-off-by: Josef Bacik <josef@redhat.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'drivers/macintosh/nvram.c')
-rw-r--r-- | drivers/macintosh/nvram.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/macintosh/nvram.c b/drivers/macintosh/nvram.c index a271c8218d82..f0e03e7937e3 100644 --- a/drivers/macintosh/nvram.c +++ b/drivers/macintosh/nvram.c | |||
@@ -21,12 +21,16 @@ | |||
21 | static loff_t nvram_llseek(struct file *file, loff_t offset, int origin) | 21 | static loff_t nvram_llseek(struct file *file, loff_t offset, int origin) |
22 | { | 22 | { |
23 | switch (origin) { | 23 | switch (origin) { |
24 | case 0: | ||
25 | break; | ||
24 | case 1: | 26 | case 1: |
25 | offset += file->f_pos; | 27 | offset += file->f_pos; |
26 | break; | 28 | break; |
27 | case 2: | 29 | case 2: |
28 | offset += NVRAM_SIZE; | 30 | offset += NVRAM_SIZE; |
29 | break; | 31 | break; |
32 | default: | ||
33 | offset = -1; | ||
30 | } | 34 | } |
31 | if (offset < 0) | 35 | if (offset < 0) |
32 | return -EINVAL; | 36 | return -EINVAL; |