diff options
author | Bjorn Helgaas <bjorn.helgaas@hp.com> | 2006-03-22 02:20:28 -0500 |
---|---|---|
committer | Paul Mackerras <paulus@samba.org> | 2006-03-22 22:41:04 -0500 |
commit | d56a3e380085bf45cc2adba80c4e6490ba644231 (patch) | |
tree | f5eba0a77b9b1f4bf7f28952b653467cf1f523af /drivers/macintosh/macio_asic.c | |
parent | 6ea671a12f66b9d4d0f35fce957a71a6849295f2 (diff) |
[PATCH] macintosh: tidy-up driver_register() return values
Remove the assumption that driver_register() returns the number of devices
bound to the driver. In fact, it returns zero for success or a negative
error value.
All callers of macio_register_driver() either ignore the return value or
return it as the return value of a module_init() function.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Paul Mackerras <paulus@samba.org>
Diffstat (limited to 'drivers/macintosh/macio_asic.c')
-rw-r--r-- | drivers/macintosh/macio_asic.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/drivers/macintosh/macio_asic.c b/drivers/macintosh/macio_asic.c index 69596f6438e9..431bd37225a1 100644 --- a/drivers/macintosh/macio_asic.c +++ b/drivers/macintosh/macio_asic.c | |||
@@ -550,15 +550,12 @@ static void macio_pci_add_devices(struct macio_chip *chip) | |||
550 | */ | 550 | */ |
551 | int macio_register_driver(struct macio_driver *drv) | 551 | int macio_register_driver(struct macio_driver *drv) |
552 | { | 552 | { |
553 | int count = 0; | ||
554 | |||
555 | /* initialize common driver fields */ | 553 | /* initialize common driver fields */ |
556 | drv->driver.name = drv->name; | 554 | drv->driver.name = drv->name; |
557 | drv->driver.bus = &macio_bus_type; | 555 | drv->driver.bus = &macio_bus_type; |
558 | 556 | ||
559 | /* register with core */ | 557 | /* register with core */ |
560 | count = driver_register(&drv->driver); | 558 | return driver_register(&drv->driver); |
561 | return count ? count : 1; | ||
562 | } | 559 | } |
563 | 560 | ||
564 | /** | 561 | /** |