diff options
| author | Rusty Russell <rusty@rustcorp.com.au> | 2009-07-30 18:03:45 -0400 |
|---|---|---|
| committer | Rusty Russell <rusty@rustcorp.com.au> | 2009-07-30 02:33:45 -0400 |
| commit | 2e04ef76916d1e29a077ea9d0f2003c8fd86724d (patch) | |
| tree | 2ff8d625d6e467be9f9f1b67a3674cb6e125e970 /drivers/lguest/x86/switcher_32.S | |
| parent | e969fed542cae08cb11d666efac4f7c5d624d09f (diff) | |
lguest: fix comment style
I don't really notice it (except to begrudge the extra vertical
space), but Ingo does. And he pointed out that one excuse of lguest
is as a teaching tool, it should set a good example.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Cc: Ingo Molnar <mingo@redhat.com>
Diffstat (limited to 'drivers/lguest/x86/switcher_32.S')
| -rw-r--r-- | drivers/lguest/x86/switcher_32.S | 18 |
1 files changed, 12 insertions, 6 deletions
diff --git a/drivers/lguest/x86/switcher_32.S b/drivers/lguest/x86/switcher_32.S index 3fc15318a80f..6dec09793836 100644 --- a/drivers/lguest/x86/switcher_32.S +++ b/drivers/lguest/x86/switcher_32.S | |||
| @@ -1,12 +1,15 @@ | |||
| 1 | /*P:900 This is the Switcher: code which sits at 0xFFC00000 astride both the | 1 | /*P:900 |
| 2 | * This is the Switcher: code which sits at 0xFFC00000 astride both the | ||
| 2 | * Host and Guest to do the low-level Guest<->Host switch. It is as simple as | 3 | * Host and Guest to do the low-level Guest<->Host switch. It is as simple as |
| 3 | * it can be made, but it's naturally very specific to x86. | 4 | * it can be made, but it's naturally very specific to x86. |
| 4 | * | 5 | * |
| 5 | * You have now completed Preparation. If this has whet your appetite; if you | 6 | * You have now completed Preparation. If this has whet your appetite; if you |
| 6 | * are feeling invigorated and refreshed then the next, more challenging stage | 7 | * are feeling invigorated and refreshed then the next, more challenging stage |
| 7 | * can be found in "make Guest". :*/ | 8 | * can be found in "make Guest". |
| 9 | :*/ | ||
| 8 | 10 | ||
| 9 | /*M:012 Lguest is meant to be simple: my rule of thumb is that 1% more LOC must | 11 | /*M:012 |
| 12 | * Lguest is meant to be simple: my rule of thumb is that 1% more LOC must | ||
| 10 | * gain at least 1% more performance. Since neither LOC nor performance can be | 13 | * gain at least 1% more performance. Since neither LOC nor performance can be |
| 11 | * measured beforehand, it generally means implementing a feature then deciding | 14 | * measured beforehand, it generally means implementing a feature then deciding |
| 12 | * if it's worth it. And once it's implemented, who can say no? | 15 | * if it's worth it. And once it's implemented, who can say no? |
| @@ -31,11 +34,14 @@ | |||
| 31 | * Host (which is actually really easy). | 34 | * Host (which is actually really easy). |
| 32 | * | 35 | * |
| 33 | * Two questions remain. Would the performance gain outweigh the complexity? | 36 | * Two questions remain. Would the performance gain outweigh the complexity? |
| 34 | * And who would write the verse documenting it? :*/ | 37 | * And who would write the verse documenting it? |
| 38 | :*/ | ||
| 35 | 39 | ||
| 36 | /*M:011 Lguest64 handles NMI. This gave me NMI envy (until I looked at their | 40 | /*M:011 |
| 41 | * Lguest64 handles NMI. This gave me NMI envy (until I looked at their | ||
| 37 | * code). It's worth doing though, since it would let us use oprofile in the | 42 | * code). It's worth doing though, since it would let us use oprofile in the |
| 38 | * Host when a Guest is running. :*/ | 43 | * Host when a Guest is running. |
| 44 | :*/ | ||
| 39 | 45 | ||
| 40 | /*S:100 | 46 | /*S:100 |
| 41 | * Welcome to the Switcher itself! | 47 | * Welcome to the Switcher itself! |