diff options
author | Jingoo Han <jg1.han@samsung.com> | 2012-10-23 08:17:56 -0400 |
---|---|---|
committer | Bryan Wu <cooloney@gmail.com> | 2012-11-26 17:28:43 -0500 |
commit | 507d967bc1d103695440e27f888244e014bcf7be (patch) | |
tree | df66361361497ed04daff8675a263ea2d1a2d121 /drivers/leds/leds-lt3593.c | |
parent | a99d76f9eb5336291fa6af713844d1c779484e30 (diff) |
leds: leds-lt3593: use gpio_request_one
Using gpio_request_one can make the code simpler because it can
set the direction and initial value in one shot.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Bryan Wu <cooloney@gmail.com>
Diffstat (limited to 'drivers/leds/leds-lt3593.c')
-rw-r--r-- | drivers/leds/leds-lt3593.c | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/drivers/leds/leds-lt3593.c b/drivers/leds/leds-lt3593.c index 09a732217f6d..17b710c63995 100644 --- a/drivers/leds/leds-lt3593.c +++ b/drivers/leds/leds-lt3593.c | |||
@@ -94,10 +94,6 @@ static int __devinit create_lt3593_led(const struct gpio_led *template, | |||
94 | return 0; | 94 | return 0; |
95 | } | 95 | } |
96 | 96 | ||
97 | ret = gpio_request(template->gpio, template->name); | ||
98 | if (ret < 0) | ||
99 | return ret; | ||
100 | |||
101 | led_dat->cdev.name = template->name; | 97 | led_dat->cdev.name = template->name; |
102 | led_dat->cdev.default_trigger = template->default_trigger; | 98 | led_dat->cdev.default_trigger = template->default_trigger; |
103 | led_dat->gpio = template->gpio; | 99 | led_dat->gpio = template->gpio; |
@@ -110,9 +106,10 @@ static int __devinit create_lt3593_led(const struct gpio_led *template, | |||
110 | if (!template->retain_state_suspended) | 106 | if (!template->retain_state_suspended) |
111 | led_dat->cdev.flags |= LED_CORE_SUSPENDRESUME; | 107 | led_dat->cdev.flags |= LED_CORE_SUSPENDRESUME; |
112 | 108 | ||
113 | ret = gpio_direction_output(led_dat->gpio, state); | 109 | ret = gpio_request_one(template->gpio, GPIOF_DIR_OUT | state, |
110 | template->name); | ||
114 | if (ret < 0) | 111 | if (ret < 0) |
115 | goto err; | 112 | return ret; |
116 | 113 | ||
117 | INIT_WORK(&led_dat->work, lt3593_led_work); | 114 | INIT_WORK(&led_dat->work, lt3593_led_work); |
118 | 115 | ||