diff options
author | Avi Kivity <avi@qumranet.com> | 2007-03-20 06:46:50 -0400 |
---|---|---|
committer | Avi Kivity <avi@qumranet.com> | 2007-05-03 03:52:25 -0400 |
commit | 039576c03c35e2f990ad9bb9c39e1bad3cd60d34 (patch) | |
tree | fa6c81a40a36d2c0da1cf20c5deb45cb9bd7ba95 /drivers/kvm/mmu.c | |
parent | f0fe510864a4520a85dfa35ae14f5f376c56efc7 (diff) |
KVM: Avoid guest virtual addresses in string pio userspace interface
The current string pio interface communicates using guest virtual addresses,
relying on userspace to translate addresses and to check permissions. This
interface cannot fully support guest smp, as the check needs to take into
account two pages at one in case an unaligned string transfer straddles a
page boundary.
Change the interface not to communicate guest addresses at all; instead use
a buffer page (mmaped by userspace) and do transfers there. The kernel
manages the virtual to physical translation and can perform the checks
atomically by taking the appropriate locks.
Signed-off-by: Avi Kivity <avi@qumranet.com>
Diffstat (limited to 'drivers/kvm/mmu.c')
-rw-r--r-- | drivers/kvm/mmu.c | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/drivers/kvm/mmu.c b/drivers/kvm/mmu.c index 2d905770fd88..4843e95e54e1 100644 --- a/drivers/kvm/mmu.c +++ b/drivers/kvm/mmu.c | |||
@@ -735,6 +735,15 @@ hpa_t gva_to_hpa(struct kvm_vcpu *vcpu, gva_t gva) | |||
735 | return gpa_to_hpa(vcpu, gpa); | 735 | return gpa_to_hpa(vcpu, gpa); |
736 | } | 736 | } |
737 | 737 | ||
738 | struct page *gva_to_page(struct kvm_vcpu *vcpu, gva_t gva) | ||
739 | { | ||
740 | gpa_t gpa = vcpu->mmu.gva_to_gpa(vcpu, gva); | ||
741 | |||
742 | if (gpa == UNMAPPED_GVA) | ||
743 | return NULL; | ||
744 | return pfn_to_page(gpa_to_hpa(vcpu, gpa) >> PAGE_SHIFT); | ||
745 | } | ||
746 | |||
738 | static void nonpaging_new_cr3(struct kvm_vcpu *vcpu) | 747 | static void nonpaging_new_cr3(struct kvm_vcpu *vcpu) |
739 | { | 748 | { |
740 | } | 749 | } |