diff options
author | Russell King <rmk+kernel@arm.linux.org.uk> | 2009-09-24 16:22:33 -0400 |
---|---|---|
committer | Russell King <rmk+kernel@arm.linux.org.uk> | 2009-09-24 16:22:33 -0400 |
commit | baea7b946f00a291b166ccae7fcfed6c01530cc6 (patch) | |
tree | 4aa275fbdbec9c7b9b4629e8bee2bbecd3c6a6af /drivers/isdn | |
parent | ae19ffbadc1b2100285a5b5b3d0a4e0a11390904 (diff) | |
parent | 94e0fb086fc5663c38bbc0fe86d698be8314f82f (diff) |
Merge branch 'origin' into for-linus
Conflicts:
MAINTAINERS
Diffstat (limited to 'drivers/isdn')
-rw-r--r-- | drivers/isdn/capi/capifs.c | 2 | ||||
-rw-r--r-- | drivers/isdn/capi/capiutil.c | 2 | ||||
-rw-r--r-- | drivers/isdn/capi/kcapi_proc.c | 10 | ||||
-rw-r--r-- | drivers/isdn/gigaset/interface.c | 19 | ||||
-rw-r--r-- | drivers/isdn/i4l/isdn_common.c | 4 |
5 files changed, 16 insertions, 21 deletions
diff --git a/drivers/isdn/capi/capifs.c b/drivers/isdn/capi/capifs.c index bff72d81f263..9f8f67b6c07f 100644 --- a/drivers/isdn/capi/capifs.c +++ b/drivers/isdn/capi/capifs.c | |||
@@ -89,7 +89,7 @@ static int capifs_remount(struct super_block *s, int *flags, char *data) | |||
89 | return 0; | 89 | return 0; |
90 | } | 90 | } |
91 | 91 | ||
92 | static struct super_operations capifs_sops = | 92 | static const struct super_operations capifs_sops = |
93 | { | 93 | { |
94 | .statfs = simple_statfs, | 94 | .statfs = simple_statfs, |
95 | .remount_fs = capifs_remount, | 95 | .remount_fs = capifs_remount, |
diff --git a/drivers/isdn/capi/capiutil.c b/drivers/isdn/capi/capiutil.c index 16f2e465e5f9..26626eead828 100644 --- a/drivers/isdn/capi/capiutil.c +++ b/drivers/isdn/capi/capiutil.c | |||
@@ -1019,7 +1019,7 @@ int __init cdebug_init(void) | |||
1019 | if (!g_debbuf->buf) { | 1019 | if (!g_debbuf->buf) { |
1020 | kfree(g_cmsg); | 1020 | kfree(g_cmsg); |
1021 | kfree(g_debbuf); | 1021 | kfree(g_debbuf); |
1022 | return -ENOMEM;; | 1022 | return -ENOMEM; |
1023 | } | 1023 | } |
1024 | g_debbuf->size = CDEBUG_GSIZE; | 1024 | g_debbuf->size = CDEBUG_GSIZE; |
1025 | g_debbuf->buf[0] = 0; | 1025 | g_debbuf->buf[0] = 0; |
diff --git a/drivers/isdn/capi/kcapi_proc.c b/drivers/isdn/capi/kcapi_proc.c index 50ed778f63fc..09d4db764d22 100644 --- a/drivers/isdn/capi/kcapi_proc.c +++ b/drivers/isdn/capi/kcapi_proc.c | |||
@@ -89,14 +89,14 @@ static int contrstats_show(struct seq_file *seq, void *v) | |||
89 | return 0; | 89 | return 0; |
90 | } | 90 | } |
91 | 91 | ||
92 | static struct seq_operations seq_controller_ops = { | 92 | static const struct seq_operations seq_controller_ops = { |
93 | .start = controller_start, | 93 | .start = controller_start, |
94 | .next = controller_next, | 94 | .next = controller_next, |
95 | .stop = controller_stop, | 95 | .stop = controller_stop, |
96 | .show = controller_show, | 96 | .show = controller_show, |
97 | }; | 97 | }; |
98 | 98 | ||
99 | static struct seq_operations seq_contrstats_ops = { | 99 | static const struct seq_operations seq_contrstats_ops = { |
100 | .start = controller_start, | 100 | .start = controller_start, |
101 | .next = controller_next, | 101 | .next = controller_next, |
102 | .stop = controller_stop, | 102 | .stop = controller_stop, |
@@ -194,14 +194,14 @@ applstats_show(struct seq_file *seq, void *v) | |||
194 | return 0; | 194 | return 0; |
195 | } | 195 | } |
196 | 196 | ||
197 | static struct seq_operations seq_applications_ops = { | 197 | static const struct seq_operations seq_applications_ops = { |
198 | .start = applications_start, | 198 | .start = applications_start, |
199 | .next = applications_next, | 199 | .next = applications_next, |
200 | .stop = applications_stop, | 200 | .stop = applications_stop, |
201 | .show = applications_show, | 201 | .show = applications_show, |
202 | }; | 202 | }; |
203 | 203 | ||
204 | static struct seq_operations seq_applstats_ops = { | 204 | static const struct seq_operations seq_applstats_ops = { |
205 | .start = applications_start, | 205 | .start = applications_start, |
206 | .next = applications_next, | 206 | .next = applications_next, |
207 | .stop = applications_stop, | 207 | .stop = applications_stop, |
@@ -264,7 +264,7 @@ static int capi_driver_show(struct seq_file *seq, void *v) | |||
264 | return 0; | 264 | return 0; |
265 | } | 265 | } |
266 | 266 | ||
267 | static struct seq_operations seq_capi_driver_ops = { | 267 | static const struct seq_operations seq_capi_driver_ops = { |
268 | .start = capi_driver_start, | 268 | .start = capi_driver_start, |
269 | .next = capi_driver_next, | 269 | .next = capi_driver_next, |
270 | .stop = capi_driver_stop, | 270 | .stop = capi_driver_stop, |
diff --git a/drivers/isdn/gigaset/interface.c b/drivers/isdn/gigaset/interface.c index 8ff7e35c7069..f33ac27de643 100644 --- a/drivers/isdn/gigaset/interface.c +++ b/drivers/isdn/gigaset/interface.c | |||
@@ -408,33 +408,28 @@ static int if_write_room(struct tty_struct *tty) | |||
408 | return retval; | 408 | return retval; |
409 | } | 409 | } |
410 | 410 | ||
411 | /* FIXME: This function does not have error returns */ | ||
412 | |||
413 | static int if_chars_in_buffer(struct tty_struct *tty) | 411 | static int if_chars_in_buffer(struct tty_struct *tty) |
414 | { | 412 | { |
415 | struct cardstate *cs; | 413 | struct cardstate *cs; |
416 | int retval = -ENODEV; | 414 | int retval = 0; |
417 | 415 | ||
418 | cs = (struct cardstate *) tty->driver_data; | 416 | cs = (struct cardstate *) tty->driver_data; |
419 | if (!cs) { | 417 | if (!cs) { |
420 | pr_err("%s: no cardstate\n", __func__); | 418 | pr_err("%s: no cardstate\n", __func__); |
421 | return -ENODEV; | 419 | return 0; |
422 | } | 420 | } |
423 | 421 | ||
424 | gig_dbg(DEBUG_IF, "%u: %s()", cs->minor_index, __func__); | 422 | gig_dbg(DEBUG_IF, "%u: %s()", cs->minor_index, __func__); |
425 | 423 | ||
426 | if (mutex_lock_interruptible(&cs->mutex)) | 424 | mutex_lock(&cs->mutex); |
427 | return -ERESTARTSYS; // FIXME -EINTR? | ||
428 | 425 | ||
429 | if (!cs->connected) { | 426 | if (!cs->connected) |
430 | gig_dbg(DEBUG_IF, "not connected"); | 427 | gig_dbg(DEBUG_IF, "not connected"); |
431 | retval = -ENODEV; | 428 | else if (!cs->open_count) |
432 | } else if (!cs->open_count) | ||
433 | dev_warn(cs->dev, "%s: device not opened\n", __func__); | 429 | dev_warn(cs->dev, "%s: device not opened\n", __func__); |
434 | else if (cs->mstate != MS_LOCKED) { | 430 | else if (cs->mstate != MS_LOCKED) |
435 | dev_warn(cs->dev, "can't write to unlocked device\n"); | 431 | dev_warn(cs->dev, "can't write to unlocked device\n"); |
436 | retval = -EBUSY; | 432 | else |
437 | } else | ||
438 | retval = cs->ops->chars_in_buffer(cs); | 433 | retval = cs->ops->chars_in_buffer(cs); |
439 | 434 | ||
440 | mutex_unlock(&cs->mutex); | 435 | mutex_unlock(&cs->mutex); |
diff --git a/drivers/isdn/i4l/isdn_common.c b/drivers/isdn/i4l/isdn_common.c index 7188c59a76ff..adb1e8c36b46 100644 --- a/drivers/isdn/i4l/isdn_common.c +++ b/drivers/isdn/i4l/isdn_common.c | |||
@@ -761,7 +761,7 @@ isdn_getnum(char **p) | |||
761 | * Be aware that this is not an atomic operation when sleep != 0, even though | 761 | * Be aware that this is not an atomic operation when sleep != 0, even though |
762 | * interrupts are turned off! Well, like that we are currently only called | 762 | * interrupts are turned off! Well, like that we are currently only called |
763 | * on behalf of a read system call on raw device files (which are documented | 763 | * on behalf of a read system call on raw device files (which are documented |
764 | * to be dangerous and for for debugging purpose only). The inode semaphore | 764 | * to be dangerous and for debugging purpose only). The inode semaphore |
765 | * takes care that this is not called for the same minor device number while | 765 | * takes care that this is not called for the same minor device number while |
766 | * we are sleeping, but access is not serialized against simultaneous read() | 766 | * we are sleeping, but access is not serialized against simultaneous read() |
767 | * from the corresponding ttyI device. Can other ugly events, like changes | 767 | * from the corresponding ttyI device. Can other ugly events, like changes |
@@ -873,7 +873,7 @@ isdn_readbchan(int di, int channel, u_char * buf, u_char * fp, int len, wait_que | |||
873 | * Be aware that this is not an atomic operation when sleep != 0, even though | 873 | * Be aware that this is not an atomic operation when sleep != 0, even though |
874 | * interrupts are turned off! Well, like that we are currently only called | 874 | * interrupts are turned off! Well, like that we are currently only called |
875 | * on behalf of a read system call on raw device files (which are documented | 875 | * on behalf of a read system call on raw device files (which are documented |
876 | * to be dangerous and for for debugging purpose only). The inode semaphore | 876 | * to be dangerous and for debugging purpose only). The inode semaphore |
877 | * takes care that this is not called for the same minor device number while | 877 | * takes care that this is not called for the same minor device number while |
878 | * we are sleeping, but access is not serialized against simultaneous read() | 878 | * we are sleeping, but access is not serialized against simultaneous read() |
879 | * from the corresponding ttyI device. Can other ugly events, like changes | 879 | * from the corresponding ttyI device. Can other ugly events, like changes |