diff options
author | Dominik Brodowski <linux@dominikbrodowski.net> | 2006-01-15 06:43:16 -0500 |
---|---|---|
committer | Dominik Brodowski <linux@dominikbrodowski.net> | 2006-03-31 10:15:55 -0500 |
commit | 70294b468302fd7a0a99dad935c7ba5322989345 (patch) | |
tree | e54b0b7c85517ef717f3755e06ca08fbb0f5937e /drivers/isdn | |
parent | 4bbed5231468014b500b048d7370a1c6c349231a (diff) |
[PATCH] pcmcia: remove unneeded Vcc pseudo setting
As we do not allow setting Vcc in the pcmcia core, and Vpp1 and
Vpp2 can only be set to the same value, a lot of code can be
streamlined.
Signed-off-by: Dominik Brodowski <linux@dominikbrodowski.net>
Diffstat (limited to 'drivers/isdn')
-rw-r--r-- | drivers/isdn/hardware/avm/avm_cs.c | 1 | ||||
-rw-r--r-- | drivers/isdn/hisax/avma1_cs.c | 1 | ||||
-rw-r--r-- | drivers/isdn/hisax/elsa_cs.c | 8 | ||||
-rw-r--r-- | drivers/isdn/hisax/sedlbauer_cs.c | 16 | ||||
-rw-r--r-- | drivers/isdn/hisax/teles_cs.c | 8 |
5 files changed, 10 insertions, 24 deletions
diff --git a/drivers/isdn/hardware/avm/avm_cs.c b/drivers/isdn/hardware/avm/avm_cs.c index ae70247d5157..0c504dc49acf 100644 --- a/drivers/isdn/hardware/avm/avm_cs.c +++ b/drivers/isdn/hardware/avm/avm_cs.c | |||
@@ -123,7 +123,6 @@ static int avmcs_attach(struct pcmcia_device *p_dev) | |||
123 | 123 | ||
124 | /* General socket configuration */ | 124 | /* General socket configuration */ |
125 | link->conf.Attributes = CONF_ENABLE_IRQ; | 125 | link->conf.Attributes = CONF_ENABLE_IRQ; |
126 | link->conf.Vcc = 50; | ||
127 | link->conf.IntType = INT_MEMORY_AND_IO; | 126 | link->conf.IntType = INT_MEMORY_AND_IO; |
128 | link->conf.ConfigIndex = 1; | 127 | link->conf.ConfigIndex = 1; |
129 | link->conf.Present = PRESENT_OPTION; | 128 | link->conf.Present = PRESENT_OPTION; |
diff --git a/drivers/isdn/hisax/avma1_cs.c b/drivers/isdn/hisax/avma1_cs.c index 5e847cfb96f8..8d23e5ab8d01 100644 --- a/drivers/isdn/hisax/avma1_cs.c +++ b/drivers/isdn/hisax/avma1_cs.c | |||
@@ -153,7 +153,6 @@ static int avma1cs_attach(struct pcmcia_device *p_dev) | |||
153 | 153 | ||
154 | /* General socket configuration */ | 154 | /* General socket configuration */ |
155 | link->conf.Attributes = CONF_ENABLE_IRQ; | 155 | link->conf.Attributes = CONF_ENABLE_IRQ; |
156 | link->conf.Vcc = 50; | ||
157 | link->conf.IntType = INT_MEMORY_AND_IO; | 156 | link->conf.IntType = INT_MEMORY_AND_IO; |
158 | link->conf.ConfigIndex = 1; | 157 | link->conf.ConfigIndex = 1; |
159 | link->conf.Present = PRESENT_OPTION; | 158 | link->conf.Present = PRESENT_OPTION; |
diff --git a/drivers/isdn/hisax/elsa_cs.c b/drivers/isdn/hisax/elsa_cs.c index b76b303ebf6b..00835d537c10 100644 --- a/drivers/isdn/hisax/elsa_cs.c +++ b/drivers/isdn/hisax/elsa_cs.c | |||
@@ -170,7 +170,6 @@ static int elsa_cs_attach(struct pcmcia_device *p_dev) | |||
170 | link->io.IOAddrLines = 3; | 170 | link->io.IOAddrLines = 3; |
171 | 171 | ||
172 | link->conf.Attributes = CONF_ENABLE_IRQ; | 172 | link->conf.Attributes = CONF_ENABLE_IRQ; |
173 | link->conf.Vcc = 50; | ||
174 | link->conf.IntType = INT_MEMORY_AND_IO; | 173 | link->conf.IntType = INT_MEMORY_AND_IO; |
175 | 174 | ||
176 | link->handle = p_dev; | 175 | link->handle = p_dev; |
@@ -324,11 +323,8 @@ static void elsa_cs_config(dev_link_t *link) | |||
324 | link->dev = &dev->node; | 323 | link->dev = &dev->node; |
325 | 324 | ||
326 | /* Finally, report what we've done */ | 325 | /* Finally, report what we've done */ |
327 | printk(KERN_INFO "%s: index 0x%02x: Vcc %d.%d", | 326 | printk(KERN_INFO "%s: index 0x%02x: ", |
328 | dev->node.dev_name, link->conf.ConfigIndex, | 327 | dev->node.dev_name, link->conf.ConfigIndex); |
329 | link->conf.Vcc/10, link->conf.Vcc%10); | ||
330 | if (link->conf.Vpp1) | ||
331 | printk(", Vpp %d.%d", link->conf.Vpp1/10, link->conf.Vpp1%10); | ||
332 | if (link->conf.Attributes & CONF_ENABLE_IRQ) | 328 | if (link->conf.Attributes & CONF_ENABLE_IRQ) |
333 | printk(", irq %d", link->irq.AssignedIRQ); | 329 | printk(", irq %d", link->irq.AssignedIRQ); |
334 | if (link->io.NumPorts1) | 330 | if (link->io.NumPorts1) |
diff --git a/drivers/isdn/hisax/sedlbauer_cs.c b/drivers/isdn/hisax/sedlbauer_cs.c index 5745eb1afe35..a3cd1c556352 100644 --- a/drivers/isdn/hisax/sedlbauer_cs.c +++ b/drivers/isdn/hisax/sedlbauer_cs.c | |||
@@ -184,7 +184,6 @@ static int sedlbauer_attach(struct pcmcia_device *p_dev) | |||
184 | 184 | ||
185 | 185 | ||
186 | link->conf.Attributes = 0; | 186 | link->conf.Attributes = 0; |
187 | link->conf.Vcc = 50; | ||
188 | link->conf.IntType = INT_MEMORY_AND_IO; | 187 | link->conf.IntType = INT_MEMORY_AND_IO; |
189 | 188 | ||
190 | link->handle = p_dev; | 189 | link->handle = p_dev; |
@@ -263,9 +262,7 @@ static void sedlbauer_config(dev_link_t *link) | |||
263 | /* Configure card */ | 262 | /* Configure card */ |
264 | link->state |= DEV_CONFIG; | 263 | link->state |= DEV_CONFIG; |
265 | 264 | ||
266 | /* Look up the current Vcc */ | ||
267 | CS_CHECK(GetConfigurationInfo, pcmcia_get_configuration_info(handle, &conf)); | 265 | CS_CHECK(GetConfigurationInfo, pcmcia_get_configuration_info(handle, &conf)); |
268 | link->conf.Vcc = conf.Vcc; | ||
269 | 266 | ||
270 | /* | 267 | /* |
271 | In this loop, we scan the CIS for configuration table entries, | 268 | In this loop, we scan the CIS for configuration table entries, |
@@ -309,10 +306,10 @@ static void sedlbauer_config(dev_link_t *link) | |||
309 | } | 306 | } |
310 | 307 | ||
311 | if (cfg->vpp1.present & (1<<CISTPL_POWER_VNOM)) | 308 | if (cfg->vpp1.present & (1<<CISTPL_POWER_VNOM)) |
312 | link->conf.Vpp1 = link->conf.Vpp2 = | 309 | link->conf.Vpp = |
313 | cfg->vpp1.param[CISTPL_POWER_VNOM]/10000; | 310 | cfg->vpp1.param[CISTPL_POWER_VNOM]/10000; |
314 | else if (dflt.vpp1.present & (1<<CISTPL_POWER_VNOM)) | 311 | else if (dflt.vpp1.present & (1<<CISTPL_POWER_VNOM)) |
315 | link->conf.Vpp1 = link->conf.Vpp2 = | 312 | link->conf.Vpp = |
316 | dflt.vpp1.param[CISTPL_POWER_VNOM]/10000; | 313 | dflt.vpp1.param[CISTPL_POWER_VNOM]/10000; |
317 | 314 | ||
318 | /* Do we need to allocate an interrupt? */ | 315 | /* Do we need to allocate an interrupt? */ |
@@ -403,11 +400,10 @@ static void sedlbauer_config(dev_link_t *link) | |||
403 | link->dev = &dev->node; | 400 | link->dev = &dev->node; |
404 | 401 | ||
405 | /* Finally, report what we've done */ | 402 | /* Finally, report what we've done */ |
406 | printk(KERN_INFO "%s: index 0x%02x: Vcc %d.%d", | 403 | printk(KERN_INFO "%s: index 0x%02x:", |
407 | dev->node.dev_name, link->conf.ConfigIndex, | 404 | dev->node.dev_name, link->conf.ConfigIndex); |
408 | link->conf.Vcc/10, link->conf.Vcc%10); | 405 | if (link->conf.Vpp) |
409 | if (link->conf.Vpp1) | 406 | printk(", Vpp %d.%d", link->conf.Vpp/10, link->conf.Vpp%10); |
410 | printk(", Vpp %d.%d", link->conf.Vpp1/10, link->conf.Vpp1%10); | ||
411 | if (link->conf.Attributes & CONF_ENABLE_IRQ) | 407 | if (link->conf.Attributes & CONF_ENABLE_IRQ) |
412 | printk(", irq %d", link->irq.AssignedIRQ); | 408 | printk(", irq %d", link->irq.AssignedIRQ); |
413 | if (link->io.NumPorts1) | 409 | if (link->io.NumPorts1) |
diff --git a/drivers/isdn/hisax/teles_cs.c b/drivers/isdn/hisax/teles_cs.c index 929507eb63af..040f098d4b26 100644 --- a/drivers/isdn/hisax/teles_cs.c +++ b/drivers/isdn/hisax/teles_cs.c | |||
@@ -161,7 +161,6 @@ static int teles_attach(struct pcmcia_device *p_dev) | |||
161 | link->io.IOAddrLines = 5; | 161 | link->io.IOAddrLines = 5; |
162 | 162 | ||
163 | link->conf.Attributes = CONF_ENABLE_IRQ; | 163 | link->conf.Attributes = CONF_ENABLE_IRQ; |
164 | link->conf.Vcc = 50; | ||
165 | link->conf.IntType = INT_MEMORY_AND_IO; | 164 | link->conf.IntType = INT_MEMORY_AND_IO; |
166 | 165 | ||
167 | link->handle = p_dev; | 166 | link->handle = p_dev; |
@@ -315,11 +314,8 @@ static void teles_cs_config(dev_link_t *link) | |||
315 | link->dev = &dev->node; | 314 | link->dev = &dev->node; |
316 | 315 | ||
317 | /* Finally, report what we've done */ | 316 | /* Finally, report what we've done */ |
318 | printk(KERN_INFO "%s: index 0x%02x: Vcc %d.%d", | 317 | printk(KERN_INFO "%s: index 0x%02x:", |
319 | dev->node.dev_name, link->conf.ConfigIndex, | 318 | dev->node.dev_name, link->conf.ConfigIndex); |
320 | link->conf.Vcc/10, link->conf.Vcc%10); | ||
321 | if (link->conf.Vpp1) | ||
322 | printk(", Vpp %d.%d", link->conf.Vpp1/10, link->conf.Vpp1%10); | ||
323 | if (link->conf.Attributes & CONF_ENABLE_IRQ) | 319 | if (link->conf.Attributes & CONF_ENABLE_IRQ) |
324 | printk(", irq %d", link->irq.AssignedIRQ); | 320 | printk(", irq %d", link->irq.AssignedIRQ); |
325 | if (link->io.NumPorts1) | 321 | if (link->io.NumPorts1) |