diff options
author | Arjan van de Ven <arjan@linux.intel.com> | 2008-07-25 04:45:52 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2008-07-25 13:53:29 -0400 |
commit | b6c63937001889af6fe431aaba97e59d04e028e7 (patch) | |
tree | cf73a1124a73e62fa5353098c276bb18b44cb867 /drivers/isdn | |
parent | f38954c93c4a548f55d73ac5c1cf5e7f4023bb6c (diff) |
Rename WARN() to WARNING() to clear the namespace
We want to use WARN() as a variant of WARN_ON(), however a few drivers are
using WARN() internally. This patch renames these to WARNING() to avoid the
namespace clash. A few cases were defining but not using the thing, for those
cases I just deleted the definition.
Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
Acked-by: Greg KH <greg@kroah.com>
Cc: Karsten Keil <kkeil@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/isdn')
-rw-r--r-- | drivers/isdn/hisax/st5481.h | 4 | ||||
-rw-r--r-- | drivers/isdn/hisax/st5481_b.c | 4 | ||||
-rw-r--r-- | drivers/isdn/hisax/st5481_d.c | 6 | ||||
-rw-r--r-- | drivers/isdn/hisax/st5481_usb.c | 18 |
4 files changed, 16 insertions, 16 deletions
diff --git a/drivers/isdn/hisax/st5481.h b/drivers/isdn/hisax/st5481.h index 2044e7173ab4..cff7a6354334 100644 --- a/drivers/isdn/hisax/st5481.h +++ b/drivers/isdn/hisax/st5481.h | |||
@@ -220,7 +220,7 @@ enum { | |||
220 | #define ERR(format, arg...) \ | 220 | #define ERR(format, arg...) \ |
221 | printk(KERN_ERR "%s:%s: " format "\n" , __FILE__, __func__ , ## arg) | 221 | printk(KERN_ERR "%s:%s: " format "\n" , __FILE__, __func__ , ## arg) |
222 | 222 | ||
223 | #define WARN(format, arg...) \ | 223 | #define WARNING(format, arg...) \ |
224 | printk(KERN_WARNING "%s:%s: " format "\n" , __FILE__, __func__ , ## arg) | 224 | printk(KERN_WARNING "%s:%s: " format "\n" , __FILE__, __func__ , ## arg) |
225 | 225 | ||
226 | #define INFO(format, arg...) \ | 226 | #define INFO(format, arg...) \ |
@@ -412,7 +412,7 @@ struct st5481_adapter { | |||
412 | ({ \ | 412 | ({ \ |
413 | int status; \ | 413 | int status; \ |
414 | if ((status = usb_submit_urb(urb, mem_flags)) < 0) { \ | 414 | if ((status = usb_submit_urb(urb, mem_flags)) < 0) { \ |
415 | WARN("usb_submit_urb failed,status=%d", status); \ | 415 | WARNING("usb_submit_urb failed,status=%d", status); \ |
416 | } \ | 416 | } \ |
417 | status; \ | 417 | status; \ |
418 | }) | 418 | }) |
diff --git a/drivers/isdn/hisax/st5481_b.c b/drivers/isdn/hisax/st5481_b.c index fa64115cd7c7..0074b600a0ef 100644 --- a/drivers/isdn/hisax/st5481_b.c +++ b/drivers/isdn/hisax/st5481_b.c | |||
@@ -180,7 +180,7 @@ static void usb_b_out_complete(struct urb *urb) | |||
180 | DBG(4,"urb killed status %d", urb->status); | 180 | DBG(4,"urb killed status %d", urb->status); |
181 | return; // Give up | 181 | return; // Give up |
182 | default: | 182 | default: |
183 | WARN("urb status %d",urb->status); | 183 | WARNING("urb status %d",urb->status); |
184 | if (b_out->busy == 0) { | 184 | if (b_out->busy == 0) { |
185 | st5481_usb_pipe_reset(adapter, (bcs->channel+1)*2 | USB_DIR_OUT, NULL, NULL); | 185 | st5481_usb_pipe_reset(adapter, (bcs->channel+1)*2 | USB_DIR_OUT, NULL, NULL); |
186 | } | 186 | } |
@@ -372,6 +372,6 @@ void st5481_b_l2l1(struct hisax_if *ifc, int pr, void *arg) | |||
372 | B_L1L2(bcs, PH_DEACTIVATE | INDICATION, NULL); | 372 | B_L1L2(bcs, PH_DEACTIVATE | INDICATION, NULL); |
373 | break; | 373 | break; |
374 | default: | 374 | default: |
375 | WARN("pr %#x\n", pr); | 375 | WARNING("pr %#x\n", pr); |
376 | } | 376 | } |
377 | } | 377 | } |
diff --git a/drivers/isdn/hisax/st5481_d.c b/drivers/isdn/hisax/st5481_d.c index b8c4855cc889..077991c1cd05 100644 --- a/drivers/isdn/hisax/st5481_d.c +++ b/drivers/isdn/hisax/st5481_d.c | |||
@@ -389,7 +389,7 @@ static void usb_d_out_complete(struct urb *urb) | |||
389 | DBG(1,"urb killed status %d", urb->status); | 389 | DBG(1,"urb killed status %d", urb->status); |
390 | break; | 390 | break; |
391 | default: | 391 | default: |
392 | WARN("urb status %d",urb->status); | 392 | WARNING("urb status %d",urb->status); |
393 | if (d_out->busy == 0) { | 393 | if (d_out->busy == 0) { |
394 | st5481_usb_pipe_reset(adapter, EP_D_OUT | USB_DIR_OUT, fifo_reseted, adapter); | 394 | st5481_usb_pipe_reset(adapter, EP_D_OUT | USB_DIR_OUT, fifo_reseted, adapter); |
395 | } | 395 | } |
@@ -420,7 +420,7 @@ static void dout_start_xmit(struct FsmInst *fsm, int event, void *arg) | |||
420 | isdnhdlc_out_init(&d_out->hdlc_state, 1, 0); | 420 | isdnhdlc_out_init(&d_out->hdlc_state, 1, 0); |
421 | 421 | ||
422 | if (test_and_set_bit(buf_nr, &d_out->busy)) { | 422 | if (test_and_set_bit(buf_nr, &d_out->busy)) { |
423 | WARN("ep %d urb %d busy %#lx", EP_D_OUT, buf_nr, d_out->busy); | 423 | WARNING("ep %d urb %d busy %#lx", EP_D_OUT, buf_nr, d_out->busy); |
424 | return; | 424 | return; |
425 | } | 425 | } |
426 | urb = d_out->urb[buf_nr]; | 426 | urb = d_out->urb[buf_nr]; |
@@ -601,7 +601,7 @@ void st5481_d_l2l1(struct hisax_if *hisax_d_if, int pr, void *arg) | |||
601 | FsmEvent(&adapter->d_out.fsm, EV_DOUT_START_XMIT, NULL); | 601 | FsmEvent(&adapter->d_out.fsm, EV_DOUT_START_XMIT, NULL); |
602 | break; | 602 | break; |
603 | default: | 603 | default: |
604 | WARN("pr %#x\n", pr); | 604 | WARNING("pr %#x\n", pr); |
605 | break; | 605 | break; |
606 | } | 606 | } |
607 | } | 607 | } |
diff --git a/drivers/isdn/hisax/st5481_usb.c b/drivers/isdn/hisax/st5481_usb.c index 427a8b0520f5..ec3c0e507669 100644 --- a/drivers/isdn/hisax/st5481_usb.c +++ b/drivers/isdn/hisax/st5481_usb.c | |||
@@ -66,7 +66,7 @@ static void usb_ctrl_msg(struct st5481_adapter *adapter, | |||
66 | struct ctrl_msg *ctrl_msg; | 66 | struct ctrl_msg *ctrl_msg; |
67 | 67 | ||
68 | if ((w_index = fifo_add(&ctrl->msg_fifo.f)) < 0) { | 68 | if ((w_index = fifo_add(&ctrl->msg_fifo.f)) < 0) { |
69 | WARN("control msg FIFO full"); | 69 | WARNING("control msg FIFO full"); |
70 | return; | 70 | return; |
71 | } | 71 | } |
72 | ctrl_msg = &ctrl->msg_fifo.data[w_index]; | 72 | ctrl_msg = &ctrl->msg_fifo.data[w_index]; |
@@ -139,7 +139,7 @@ static void usb_ctrl_complete(struct urb *urb) | |||
139 | DBG(1,"urb killed status %d", urb->status); | 139 | DBG(1,"urb killed status %d", urb->status); |
140 | return; // Give up | 140 | return; // Give up |
141 | default: | 141 | default: |
142 | WARN("urb status %d",urb->status); | 142 | WARNING("urb status %d",urb->status); |
143 | break; | 143 | break; |
144 | } | 144 | } |
145 | } | 145 | } |
@@ -198,7 +198,7 @@ static void usb_int_complete(struct urb *urb) | |||
198 | DBG(2, "urb shutting down with status: %d", urb->status); | 198 | DBG(2, "urb shutting down with status: %d", urb->status); |
199 | return; | 199 | return; |
200 | default: | 200 | default: |
201 | WARN("nonzero urb status received: %d", urb->status); | 201 | WARNING("nonzero urb status received: %d", urb->status); |
202 | goto exit; | 202 | goto exit; |
203 | } | 203 | } |
204 | 204 | ||
@@ -235,7 +235,7 @@ static void usb_int_complete(struct urb *urb) | |||
235 | exit: | 235 | exit: |
236 | status = usb_submit_urb (urb, GFP_ATOMIC); | 236 | status = usb_submit_urb (urb, GFP_ATOMIC); |
237 | if (status) | 237 | if (status) |
238 | WARN("usb_submit_urb failed with result %d", status); | 238 | WARNING("usb_submit_urb failed with result %d", status); |
239 | } | 239 | } |
240 | 240 | ||
241 | /* ====================================================================== | 241 | /* ====================================================================== |
@@ -257,7 +257,7 @@ int st5481_setup_usb(struct st5481_adapter *adapter) | |||
257 | DBG(2,""); | 257 | DBG(2,""); |
258 | 258 | ||
259 | if ((status = usb_reset_configuration (dev)) < 0) { | 259 | if ((status = usb_reset_configuration (dev)) < 0) { |
260 | WARN("reset_configuration failed,status=%d",status); | 260 | WARNING("reset_configuration failed,status=%d",status); |
261 | return status; | 261 | return status; |
262 | } | 262 | } |
263 | 263 | ||
@@ -269,7 +269,7 @@ int st5481_setup_usb(struct st5481_adapter *adapter) | |||
269 | 269 | ||
270 | // Check if the config is sane | 270 | // Check if the config is sane |
271 | if ( altsetting->desc.bNumEndpoints != 7 ) { | 271 | if ( altsetting->desc.bNumEndpoints != 7 ) { |
272 | WARN("expecting 7 got %d endpoints!", altsetting->desc.bNumEndpoints); | 272 | WARNING("expecting 7 got %d endpoints!", altsetting->desc.bNumEndpoints); |
273 | return -EINVAL; | 273 | return -EINVAL; |
274 | } | 274 | } |
275 | 275 | ||
@@ -279,7 +279,7 @@ int st5481_setup_usb(struct st5481_adapter *adapter) | |||
279 | 279 | ||
280 | // Use alternative setting 3 on interface 0 to have 2B+D | 280 | // Use alternative setting 3 on interface 0 to have 2B+D |
281 | if ((status = usb_set_interface (dev, 0, 3)) < 0) { | 281 | if ((status = usb_set_interface (dev, 0, 3)) < 0) { |
282 | WARN("usb_set_interface failed,status=%d",status); | 282 | WARNING("usb_set_interface failed,status=%d",status); |
283 | return status; | 283 | return status; |
284 | } | 284 | } |
285 | 285 | ||
@@ -497,7 +497,7 @@ static void usb_in_complete(struct urb *urb) | |||
497 | DBG(1,"urb killed status %d", urb->status); | 497 | DBG(1,"urb killed status %d", urb->status); |
498 | return; // Give up | 498 | return; // Give up |
499 | default: | 499 | default: |
500 | WARN("urb status %d",urb->status); | 500 | WARNING("urb status %d",urb->status); |
501 | break; | 501 | break; |
502 | } | 502 | } |
503 | } | 503 | } |
@@ -523,7 +523,7 @@ static void usb_in_complete(struct urb *urb) | |||
523 | DBG(4,"count=%d",status); | 523 | DBG(4,"count=%d",status); |
524 | DBG_PACKET(0x400, in->rcvbuf, status); | 524 | DBG_PACKET(0x400, in->rcvbuf, status); |
525 | if (!(skb = dev_alloc_skb(status))) { | 525 | if (!(skb = dev_alloc_skb(status))) { |
526 | WARN("receive out of memory\n"); | 526 | WARNING("receive out of memory\n"); |
527 | break; | 527 | break; |
528 | } | 528 | } |
529 | memcpy(skb_put(skb, status), in->rcvbuf, status); | 529 | memcpy(skb_put(skb, status), in->rcvbuf, status); |