diff options
author | Jeff Dike <jdike@addtoit.com> | 2006-10-02 05:17:18 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-10-02 10:57:14 -0400 |
commit | b68e31d0ebbcc909d1941f9f230c9d062a3a13d3 (patch) | |
tree | b32902e5de02081cbb9eca49d7bb0b444e2b4f23 /drivers/isdn | |
parent | ed97bd37efd8ff7398d3a7eedf4bcbf245f5dad3 (diff) |
[PATCH] const struct tty_operations
As part of an SMP cleanliness pass over UML, I consted a bunch of
structures in order to not have to document their locking. One of these
structures was a struct tty_operations. In order to const it in UML
without introducing compiler complaints, the declaration of
tty_set_operations needs to be changed, and then all of its callers need to
be fixed.
This patch declares all struct tty_operations in the tree as const. In all
cases, they are static and used only as input to tty_set_operations. As an
extra check, I ran an i386 allyesconfig build which produced no extra
warnings.
53 drivers are affected. I checked the history of a bunch of them, and in
most cases, there have been only a handful of maintenance changes in the
last six months. serial_core.c was the busiest one that I looked at.
Signed-off-by: Jeff Dike <jdike@addtoit.com>
Acked-by: Alan Cox <alan@redhat.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'drivers/isdn')
-rw-r--r-- | drivers/isdn/capi/capi.c | 2 | ||||
-rw-r--r-- | drivers/isdn/gigaset/interface.c | 2 | ||||
-rw-r--r-- | drivers/isdn/i4l/isdn_tty.c | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/drivers/isdn/capi/capi.c b/drivers/isdn/capi/capi.c index 669f76393b5a..11844bbfe933 100644 --- a/drivers/isdn/capi/capi.c +++ b/drivers/isdn/capi/capi.c | |||
@@ -1298,7 +1298,7 @@ static int capinc_tty_read_proc(char *page, char **start, off_t off, | |||
1298 | 1298 | ||
1299 | static struct tty_driver *capinc_tty_driver; | 1299 | static struct tty_driver *capinc_tty_driver; |
1300 | 1300 | ||
1301 | static struct tty_operations capinc_ops = { | 1301 | static const struct tty_operations capinc_ops = { |
1302 | .open = capinc_tty_open, | 1302 | .open = capinc_tty_open, |
1303 | .close = capinc_tty_close, | 1303 | .close = capinc_tty_close, |
1304 | .write = capinc_tty_write, | 1304 | .write = capinc_tty_write, |
diff --git a/drivers/isdn/gigaset/interface.c b/drivers/isdn/gigaset/interface.c index bd2e4267528e..596f3aebe2f7 100644 --- a/drivers/isdn/gigaset/interface.c +++ b/drivers/isdn/gigaset/interface.c | |||
@@ -134,7 +134,7 @@ static int if_tiocmset(struct tty_struct *tty, struct file *file, | |||
134 | static int if_write(struct tty_struct *tty, | 134 | static int if_write(struct tty_struct *tty, |
135 | const unsigned char *buf, int count); | 135 | const unsigned char *buf, int count); |
136 | 136 | ||
137 | static struct tty_operations if_ops = { | 137 | static const struct tty_operations if_ops = { |
138 | .open = if_open, | 138 | .open = if_open, |
139 | .close = if_close, | 139 | .close = if_close, |
140 | .ioctl = if_ioctl, | 140 | .ioctl = if_ioctl, |
diff --git a/drivers/isdn/i4l/isdn_tty.c b/drivers/isdn/i4l/isdn_tty.c index 9ab66e8960d5..2b91bb07fc7f 100644 --- a/drivers/isdn/i4l/isdn_tty.c +++ b/drivers/isdn/i4l/isdn_tty.c | |||
@@ -1860,7 +1860,7 @@ modem_write_profile(atemu * m) | |||
1860 | send_sig(SIGIO, dev->profd, 1); | 1860 | send_sig(SIGIO, dev->profd, 1); |
1861 | } | 1861 | } |
1862 | 1862 | ||
1863 | static struct tty_operations modem_ops = { | 1863 | static const struct tty_operations modem_ops = { |
1864 | .open = isdn_tty_open, | 1864 | .open = isdn_tty_open, |
1865 | .close = isdn_tty_close, | 1865 | .close = isdn_tty_close, |
1866 | .write = isdn_tty_write, | 1866 | .write = isdn_tty_write, |