diff options
author | Julia Lawall <julia@diku.dk> | 2010-08-05 06:29:19 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2010-08-17 00:06:30 -0400 |
commit | f7df0b8d924ad2f39852ea397d39a51fbb955212 (patch) | |
tree | 9d443db5466bb6857ce82d4a12ba74222814a3ec /drivers/isdn | |
parent | 9e1634a734bdd2dac5687f57dd427bef083e4659 (diff) |
drivers/isdn: Adjust confusing if indentation
In hisax/hfc_sx.c and mISDN/l1oip_core.c, the code after the if is
outdented so that it is not aligned with the if branch.
In mISDN/dsp_cmx.c, an else is added between the original if branch and the
following statement, in line with the code following it. Without this
change, the first assignment to dsp->rx_W has no useful effect.
The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r disable braces4@
position p1,p2;
statement S1,S2;
@@
(
if (...) { ... }
|
if (...) S1@p1 S2@p2
)
@script:python@
p1 << r.p1;
p2 << r.p2;
@@
if (p1[0].column == p2[0].column):
cocci.print_main("branch",p1)
cocci.print_secs("after",p2)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/isdn')
-rw-r--r-- | drivers/isdn/hisax/hfc_sx.c | 13 | ||||
-rw-r--r-- | drivers/isdn/mISDN/dsp_cmx.c | 1 | ||||
-rw-r--r-- | drivers/isdn/mISDN/l1oip_core.c | 2 |
3 files changed, 9 insertions, 7 deletions
diff --git a/drivers/isdn/hisax/hfc_sx.c b/drivers/isdn/hisax/hfc_sx.c index be5faf4aa868..5aa138eb0b3c 100644 --- a/drivers/isdn/hisax/hfc_sx.c +++ b/drivers/isdn/hisax/hfc_sx.c | |||
@@ -234,13 +234,14 @@ read_fifo(struct IsdnCardState *cs, u_char fifo, int trans_max) | |||
234 | count++; | 234 | count++; |
235 | if (count > trans_max) | 235 | if (count > trans_max) |
236 | count = trans_max; /* limit length */ | 236 | count = trans_max; /* limit length */ |
237 | if ((skb = dev_alloc_skb(count))) { | 237 | skb = dev_alloc_skb(count); |
238 | dst = skb_put(skb, count); | 238 | if (skb) { |
239 | while (count--) | 239 | dst = skb_put(skb, count); |
240 | while (count--) | ||
240 | *dst++ = Read_hfc(cs, HFCSX_FIF_DRD); | 241 | *dst++ = Read_hfc(cs, HFCSX_FIF_DRD); |
241 | return(skb); | 242 | return skb; |
242 | } | 243 | } else |
243 | else return(NULL); /* no memory */ | 244 | return NULL; /* no memory */ |
244 | } | 245 | } |
245 | 246 | ||
246 | do { | 247 | do { |
diff --git a/drivers/isdn/mISDN/dsp_cmx.c b/drivers/isdn/mISDN/dsp_cmx.c index 713ef2b805a2..76d9e673b4e1 100644 --- a/drivers/isdn/mISDN/dsp_cmx.c +++ b/drivers/isdn/mISDN/dsp_cmx.c | |||
@@ -1237,6 +1237,7 @@ dsp_cmx_receive(struct dsp *dsp, struct sk_buff *skb) | |||
1237 | if (dsp->cmx_delay) | 1237 | if (dsp->cmx_delay) |
1238 | dsp->rx_W = (dsp->rx_R + dsp->cmx_delay) | 1238 | dsp->rx_W = (dsp->rx_R + dsp->cmx_delay) |
1239 | & CMX_BUFF_MASK; | 1239 | & CMX_BUFF_MASK; |
1240 | else | ||
1240 | dsp->rx_W = (dsp->rx_R + (dsp_poll >> 1)) | 1241 | dsp->rx_W = (dsp->rx_R + (dsp_poll >> 1)) |
1241 | & CMX_BUFF_MASK; | 1242 | & CMX_BUFF_MASK; |
1242 | } else { | 1243 | } else { |
diff --git a/drivers/isdn/mISDN/l1oip_core.c b/drivers/isdn/mISDN/l1oip_core.c index 22f38e48ac4e..5b59796ed250 100644 --- a/drivers/isdn/mISDN/l1oip_core.c +++ b/drivers/isdn/mISDN/l1oip_core.c | |||
@@ -972,7 +972,7 @@ channel_dctrl(struct dchannel *dch, struct mISDN_ctrl_req *cq) | |||
972 | if (debug & DEBUG_L1OIP_SOCKET) | 972 | if (debug & DEBUG_L1OIP_SOCKET) |
973 | printk(KERN_DEBUG "%s: got new ip address from user " | 973 | printk(KERN_DEBUG "%s: got new ip address from user " |
974 | "space.\n", __func__); | 974 | "space.\n", __func__); |
975 | l1oip_socket_open(hc); | 975 | l1oip_socket_open(hc); |
976 | break; | 976 | break; |
977 | case MISDN_CTRL_UNSETPEER: | 977 | case MISDN_CTRL_UNSETPEER: |
978 | if (debug & DEBUG_L1OIP_SOCKET) | 978 | if (debug & DEBUG_L1OIP_SOCKET) |