diff options
author | Hannes Eder <hannes@hanneseder.net> | 2008-12-13 00:15:17 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2008-12-13 00:15:17 -0500 |
commit | 5b8343540a3d27f87a4d9d72bb39b7d4cc3dd95e (patch) | |
tree | 38671546aab7418067af9b5fca08b79e9307f3f0 /drivers/isdn/mISDN/layer2.c | |
parent | dfa96ec1bb83641242c48883c2bae8f1f30483b2 (diff) |
mISDN: make global symbols static or include header files
The warnings fixed by including an header file for the appropriate
prototype are marked with "*", for all others the corresonponding
symbol has been made static. This patch fixes all such issues in
mISDN.
Fix this sparse warnings:
drivers/isdn/hardware/mISDN/hfcmulti.c:174:5: warning: symbol 'plxsd_master' was not declared. Should it be static?
drivers/isdn/hardware/mISDN/hfcmulti.c:426:1: warning: symbol 'write_fifo_regio' was not declared. Should it be static?
drivers/isdn/hardware/mISDN/hfcmulti.c:447:1: warning: symbol 'write_fifo_pcimem' was not declared. Should it be static?
drivers/isdn/hardware/mISDN/hfcmulti.c:469:1: warning: symbol 'read_fifo_regio' was not declared. Should it be static?
drivers/isdn/hardware/mISDN/hfcmulti.c:491:1: warning: symbol 'read_fifo_pcimem' was not declared. Should it be static?
drivers/isdn/hardware/mISDN/hfcmulti.c:710:1: warning: symbol 'vpm_init' was not declared. Should it be static?
drivers/isdn/hardware/mISDN/hfcmulti.c:793:1: warning: symbol 'vpm_check' was not declared. Should it be static?
drivers/isdn/hardware/mISDN/hfcmulti.c:816:1: warning: symbol 'vpm_echocan_on' was not declared. Should it be static?
drivers/isdn/hardware/mISDN/hfcmulti.c:848:1: warning: symbol 'vpm_echocan_off' was not declared. Should it be static?
* drivers/isdn/mISDN/l1oip_codec.c:224:1: warning: symbol 'l1oip_law_to_4bit' was not declared. Should it be static?
* drivers/isdn/mISDN/l1oip_codec.c:261:1: warning: symbol 'l1oip_4bit_to_law' was not declared. Should it be static?
* drivers/isdn/mISDN/l1oip_codec.c:281:1: warning: symbol 'l1oip_alaw_to_ulaw' was not declared. Should it be static?
* drivers/isdn/mISDN/l1oip_codec.c:294:1: warning: symbol 'l1oip_ulaw_to_alaw' was not declared. Should it be static?
* drivers/isdn/mISDN/l1oip_codec.c:311:1: warning: symbol 'l1oip_4bit_free' was not declared. Should it be static?
* drivers/isdn/mISDN/l1oip_codec.c:322:1: warning: symbol 'l1oip_4bit_alloc' was not declared. Should it be static?
drivers/isdn/mISDN/core.c:29:1: warning: symbol 'device_lock' was not declared. Should it be static?
drivers/isdn/mISDN/core.c:34:1: warning: symbol 'bp_lock' was not declared. Should it be static?
drivers/isdn/mISDN/core.c:196:1: warning: symbol 'mISDNInit' was not declared. Should it be static?
drivers/isdn/mISDN/core.c:227:6: warning: symbol 'mISDN_cleanup' was not declared. Should it be static?
drivers/isdn/mISDN/stack.c:40:1: warning: symbol 'mISDN_queue_message' was not declared. Should it be static?
* drivers/isdn/mISDN/layer1.c:388:1: warning: symbol 'l1_init' was not declared. Should it be static?
* drivers/isdn/mISDN/layer1.c:400:1: warning: symbol 'l1_cleanup' was not declared. Should it be static?
drivers/isdn/mISDN/layer2.c:469:1: warning: symbol 'iframe_error' was not declared. Should it be static?
drivers/isdn/mISDN/layer2.c:487:1: warning: symbol 'super_error' was not declared. Should it be static?
drivers/isdn/mISDN/layer2.c:496:1: warning: symbol 'unnum_error' was not declared. Should it be static?
drivers/isdn/mISDN/layer2.c:509:1: warning: symbol 'UI_error' was not declared. Should it be static?
drivers/isdn/mISDN/layer2.c:522:1: warning: symbol 'FRMR_error' was not declared. Should it be static?
drivers/isdn/mISDN/layer2.c:1069:1: warning: symbol 'enquiry_cr' was not declared. Should it be static?
* drivers/isdn/mISDN/layer2.c:2196:1: warning: symbol 'Isdnl2_Init' was not declared. Should it be static?
* drivers/isdn/mISDN/layer2.c:2210:1: warning: symbol 'Isdnl2_cleanup' was not declared. Should it be static?
drivers/isdn/mISDN/tei.c:397:1: warning: symbol 'random_ri' was not declared. Should it be static?
* drivers/isdn/mISDN/timerdev.c:277:1: warning: symbol 'mISDN_inittimer' was not declared. Should it be static?
* drivers/isdn/mISDN/timerdev.c:288:6: warning: symbol 'mISDN_timer_cleanup' was not declared. Should it be static?
drivers/isdn/mISDN/dsp_core.c:164:12: warning: symbol 'mISDN_dsp_revision' was not declared. Should it be static?
drivers/isdn/mISDN/dsp_cmx.c:1543:5: warning: symbol 'samplecount' was not declared. Should it be static?
drivers/isdn/mISDN/dsp_cmx.c:1546:5: warning: symbol 'dsp_start_jiffies' was not declared. Should it be static?
drivers/isdn/mISDN/dsp_cmx.c:1547:16: warning: symbol 'dsp_start_tv' was not declared. Should it be static?
drivers/isdn/mISDN/dsp_tones.c:239:3: warning: symbol 'pattern' was not declared. Should it be static?
drivers/isdn/mISDN/dsp_audio.c:33:4: warning: symbol 'dsp_audio_ulaw_to_alaw' was not declared. Should it be static?
Signed-off-by: Hannes Eder <hannes@hanneseder.net>
Acked-by: Karsten Keil <kkeil@suse.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/isdn/mISDN/layer2.c')
-rw-r--r-- | drivers/isdn/mISDN/layer2.c | 14 |
1 files changed, 8 insertions, 6 deletions
diff --git a/drivers/isdn/mISDN/layer2.c b/drivers/isdn/mISDN/layer2.c index 77fca3b061de..d6e2863f224a 100644 --- a/drivers/isdn/mISDN/layer2.c +++ b/drivers/isdn/mISDN/layer2.c | |||
@@ -15,6 +15,8 @@ | |||
15 | * | 15 | * |
16 | */ | 16 | */ |
17 | 17 | ||
18 | #include <linux/mISDNif.h> | ||
19 | #include "core.h" | ||
18 | #include "fsm.h" | 20 | #include "fsm.h" |
19 | #include "layer2.h" | 21 | #include "layer2.h" |
20 | 22 | ||
@@ -465,7 +467,7 @@ IsRNR(u_char *data, struct layer2 *l2) | |||
465 | data[0] == RNR : (data[0] & 0xf) == RNR; | 467 | data[0] == RNR : (data[0] & 0xf) == RNR; |
466 | } | 468 | } |
467 | 469 | ||
468 | int | 470 | static int |
469 | iframe_error(struct layer2 *l2, struct sk_buff *skb) | 471 | iframe_error(struct layer2 *l2, struct sk_buff *skb) |
470 | { | 472 | { |
471 | u_int i; | 473 | u_int i; |
@@ -483,7 +485,7 @@ iframe_error(struct layer2 *l2, struct sk_buff *skb) | |||
483 | return 0; | 485 | return 0; |
484 | } | 486 | } |
485 | 487 | ||
486 | int | 488 | static int |
487 | super_error(struct layer2 *l2, struct sk_buff *skb) | 489 | super_error(struct layer2 *l2, struct sk_buff *skb) |
488 | { | 490 | { |
489 | if (skb->len != l2addrsize(l2) + | 491 | if (skb->len != l2addrsize(l2) + |
@@ -492,7 +494,7 @@ super_error(struct layer2 *l2, struct sk_buff *skb) | |||
492 | return 0; | 494 | return 0; |
493 | } | 495 | } |
494 | 496 | ||
495 | int | 497 | static int |
496 | unnum_error(struct layer2 *l2, struct sk_buff *skb, int wantrsp) | 498 | unnum_error(struct layer2 *l2, struct sk_buff *skb, int wantrsp) |
497 | { | 499 | { |
498 | int rsp = (*skb->data & 0x2) >> 1; | 500 | int rsp = (*skb->data & 0x2) >> 1; |
@@ -505,7 +507,7 @@ unnum_error(struct layer2 *l2, struct sk_buff *skb, int wantrsp) | |||
505 | return 0; | 507 | return 0; |
506 | } | 508 | } |
507 | 509 | ||
508 | int | 510 | static int |
509 | UI_error(struct layer2 *l2, struct sk_buff *skb) | 511 | UI_error(struct layer2 *l2, struct sk_buff *skb) |
510 | { | 512 | { |
511 | int rsp = *skb->data & 0x2; | 513 | int rsp = *skb->data & 0x2; |
@@ -518,7 +520,7 @@ UI_error(struct layer2 *l2, struct sk_buff *skb) | |||
518 | return 0; | 520 | return 0; |
519 | } | 521 | } |
520 | 522 | ||
521 | int | 523 | static int |
522 | FRMR_error(struct layer2 *l2, struct sk_buff *skb) | 524 | FRMR_error(struct layer2 *l2, struct sk_buff *skb) |
523 | { | 525 | { |
524 | u_int headers = l2addrsize(l2) + 1; | 526 | u_int headers = l2addrsize(l2) + 1; |
@@ -1065,7 +1067,7 @@ l2_st6_dm_release(struct FsmInst *fi, int event, void *arg) | |||
1065 | } | 1067 | } |
1066 | } | 1068 | } |
1067 | 1069 | ||
1068 | void | 1070 | static void |
1069 | enquiry_cr(struct layer2 *l2, u_char typ, u_char cr, u_char pf) | 1071 | enquiry_cr(struct layer2 *l2, u_char typ, u_char cr, u_char pf) |
1070 | { | 1072 | { |
1071 | struct sk_buff *skb; | 1073 | struct sk_buff *skb; |