diff options
author | Jeff Garzik <jeff@garzik.org> | 2007-10-31 03:42:07 -0400 |
---|---|---|
committer | Jeff Garzik <jgarzik@redhat.com> | 2008-04-20 18:22:31 -0400 |
commit | 8349304d12cf1313bdbd6eb2083701d86809be24 (patch) | |
tree | 599d43c202cda35b80966d9f364559484ca4145a /drivers/isdn/hisax/saphir.c | |
parent | d38c8475b4f3a684ac673dcedc88ffdb17b74882 (diff) |
[ISDN] Hisax: eliminate many unnecessary references to CardType[]
For the vast majority of CardType[card->typ] uses (but not all!),
the string is constant for each driver. Therefore, we may replace
CardType[card->typ] with the actual string describing the driver, making
each printk() a bit more simple.
This also has the nice, intended side effect of greatly reducing
external references to hisax global CardType[]. This will be of value
once the ISDN drivers are converted to the ISA/PCI/PNP hotplug APIs.
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
Diffstat (limited to 'drivers/isdn/hisax/saphir.c')
-rw-r--r-- | drivers/isdn/hisax/saphir.c | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/drivers/isdn/hisax/saphir.c b/drivers/isdn/hisax/saphir.c index c99b16690fb3..b34a81d655b8 100644 --- a/drivers/isdn/hisax/saphir.c +++ b/drivers/isdn/hisax/saphir.c | |||
@@ -18,7 +18,6 @@ | |||
18 | #include "hscx.h" | 18 | #include "hscx.h" |
19 | #include "isdnl1.h" | 19 | #include "isdnl1.h" |
20 | 20 | ||
21 | extern const char *CardType[]; | ||
22 | static char *saphir_rev = "$Revision: 1.10.2.4 $"; | 21 | static char *saphir_rev = "$Revision: 1.10.2.4 $"; |
23 | 22 | ||
24 | #define byteout(addr,val) outb(val,addr) | 23 | #define byteout(addr,val) outb(val,addr) |
@@ -260,15 +259,14 @@ setup_saphir(struct IsdnCard *card) | |||
260 | cs->irq = card->para[0]; | 259 | cs->irq = card->para[0]; |
261 | if (!request_region(cs->hw.saphir.cfg_reg, 6, "saphir")) { | 260 | if (!request_region(cs->hw.saphir.cfg_reg, 6, "saphir")) { |
262 | printk(KERN_WARNING | 261 | printk(KERN_WARNING |
263 | "HiSax: %s config port %x-%x already in use\n", | 262 | "HiSax: HST Saphir config port %x-%x already in use\n", |
264 | CardType[card->typ], | ||
265 | cs->hw.saphir.cfg_reg, | 263 | cs->hw.saphir.cfg_reg, |
266 | cs->hw.saphir.cfg_reg + 5); | 264 | cs->hw.saphir.cfg_reg + 5); |
267 | return (0); | 265 | return (0); |
268 | } | 266 | } |
269 | 267 | ||
270 | printk(KERN_INFO "HiSax: %s config irq:%d io:0x%X\n", | 268 | printk(KERN_INFO "HiSax: HST Saphir config irq:%d io:0x%X\n", |
271 | CardType[cs->typ], cs->irq, cs->hw.saphir.cfg_reg); | 269 | cs->irq, cs->hw.saphir.cfg_reg); |
272 | 270 | ||
273 | setup_isac(cs); | 271 | setup_isac(cs); |
274 | cs->hw.saphir.timer.function = (void *) SaphirWatchDog; | 272 | cs->hw.saphir.timer.function = (void *) SaphirWatchDog; |