diff options
author | Jeff Garzik <jeff@garzik.org> | 2007-10-31 03:42:07 -0400 |
---|---|---|
committer | Jeff Garzik <jgarzik@redhat.com> | 2008-04-20 18:22:31 -0400 |
commit | 8349304d12cf1313bdbd6eb2083701d86809be24 (patch) | |
tree | 599d43c202cda35b80966d9f364559484ca4145a /drivers/isdn/hisax/s0box.c | |
parent | d38c8475b4f3a684ac673dcedc88ffdb17b74882 (diff) |
[ISDN] Hisax: eliminate many unnecessary references to CardType[]
For the vast majority of CardType[card->typ] uses (but not all!),
the string is constant for each driver. Therefore, we may replace
CardType[card->typ] with the actual string describing the driver, making
each printk() a bit more simple.
This also has the nice, intended side effect of greatly reducing
external references to hisax global CardType[]. This will be of value
once the ISDN drivers are converted to the ISA/PCI/PNP hotplug APIs.
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
Diffstat (limited to 'drivers/isdn/hisax/s0box.c')
-rw-r--r-- | drivers/isdn/hisax/s0box.c | 13 |
1 files changed, 4 insertions, 9 deletions
diff --git a/drivers/isdn/hisax/s0box.c b/drivers/isdn/hisax/s0box.c index 150ef68b4ae2..16d00b555c8c 100644 --- a/drivers/isdn/hisax/s0box.c +++ b/drivers/isdn/hisax/s0box.c | |||
@@ -16,7 +16,6 @@ | |||
16 | #include "hscx.h" | 16 | #include "hscx.h" |
17 | #include "isdnl1.h" | 17 | #include "isdnl1.h" |
18 | 18 | ||
19 | extern const char *CardType[]; | ||
20 | static const char *s0box_revision = "$Revision: 2.6.2.4 $"; | 19 | static const char *s0box_revision = "$Revision: 2.6.2.4 $"; |
21 | 20 | ||
22 | static inline void | 21 | static inline void |
@@ -231,19 +230,15 @@ setup_s0box(struct IsdnCard *card) | |||
231 | cs->hw.teles3.hscxfifo[1] = cs->hw.teles3.hscx[1] + 0x3e; | 230 | cs->hw.teles3.hscxfifo[1] = cs->hw.teles3.hscx[1] + 0x3e; |
232 | cs->irq = card->para[0]; | 231 | cs->irq = card->para[0]; |
233 | if (!request_region(cs->hw.teles3.cfg_reg,8, "S0Box parallel I/O")) { | 232 | if (!request_region(cs->hw.teles3.cfg_reg,8, "S0Box parallel I/O")) { |
234 | printk(KERN_WARNING | 233 | printk(KERN_WARNING "HiSax: S0Box ports %x-%x already in use\n", |
235 | "HiSax: %s ports %x-%x already in use\n", | ||
236 | CardType[cs->typ], | ||
237 | cs->hw.teles3.cfg_reg, | 234 | cs->hw.teles3.cfg_reg, |
238 | cs->hw.teles3.cfg_reg + 7); | 235 | cs->hw.teles3.cfg_reg + 7); |
239 | return 0; | 236 | return 0; |
240 | } | 237 | } |
241 | printk(KERN_INFO | 238 | printk(KERN_INFO "HiSax: S0Box config irq:%d isac:0x%x cfg:0x%x\n", |
242 | "HiSax: %s config irq:%d isac:0x%x cfg:0x%x\n", | 239 | cs->irq, |
243 | CardType[cs->typ], cs->irq, | ||
244 | cs->hw.teles3.isac, cs->hw.teles3.cfg_reg); | 240 | cs->hw.teles3.isac, cs->hw.teles3.cfg_reg); |
245 | printk(KERN_INFO | 241 | printk(KERN_INFO "HiSax: hscx A:0x%x hscx B:0x%x\n", |
246 | "HiSax: hscx A:0x%x hscx B:0x%x\n", | ||
247 | cs->hw.teles3.hscx[0], cs->hw.teles3.hscx[1]); | 242 | cs->hw.teles3.hscx[0], cs->hw.teles3.hscx[1]); |
248 | setup_isac(cs); | 243 | setup_isac(cs); |
249 | cs->readisac = &ReadISAC; | 244 | cs->readisac = &ReadISAC; |