diff options
author | Jeff Garzik <jeff@garzik.org> | 2007-10-31 03:42:07 -0400 |
---|---|---|
committer | Jeff Garzik <jgarzik@redhat.com> | 2008-04-20 18:22:31 -0400 |
commit | 8349304d12cf1313bdbd6eb2083701d86809be24 (patch) | |
tree | 599d43c202cda35b80966d9f364559484ca4145a /drivers/isdn/hisax/ix1_micro.c | |
parent | d38c8475b4f3a684ac673dcedc88ffdb17b74882 (diff) |
[ISDN] Hisax: eliminate many unnecessary references to CardType[]
For the vast majority of CardType[card->typ] uses (but not all!),
the string is constant for each driver. Therefore, we may replace
CardType[card->typ] with the actual string describing the driver, making
each printk() a bit more simple.
This also has the nice, intended side effect of greatly reducing
external references to hisax global CardType[]. This will be of value
once the ISDN drivers are converted to the ISA/PCI/PNP hotplug APIs.
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
Diffstat (limited to 'drivers/isdn/hisax/ix1_micro.c')
-rw-r--r-- | drivers/isdn/hisax/ix1_micro.c | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/drivers/isdn/hisax/ix1_micro.c b/drivers/isdn/hisax/ix1_micro.c index 252d79de5e5e..2d18d4f1e57e 100644 --- a/drivers/isdn/hisax/ix1_micro.c +++ b/drivers/isdn/hisax/ix1_micro.c | |||
@@ -24,7 +24,6 @@ | |||
24 | #include "hscx.h" | 24 | #include "hscx.h" |
25 | #include "isdnl1.h" | 25 | #include "isdnl1.h" |
26 | 26 | ||
27 | extern const char *CardType[]; | ||
28 | static const char *ix1_revision = "$Revision: 2.12.2.4 $"; | 27 | static const char *ix1_revision = "$Revision: 2.12.2.4 $"; |
29 | 28 | ||
30 | #define byteout(addr,val) outb(val,addr) | 29 | #define byteout(addr,val) outb(val,addr) |
@@ -288,15 +287,15 @@ setup_ix1micro(struct IsdnCard *card) | |||
288 | if (cs->hw.ix1.cfg_reg) { | 287 | if (cs->hw.ix1.cfg_reg) { |
289 | if (!request_region(cs->hw.ix1.cfg_reg, 4, "ix1micro cfg")) { | 288 | if (!request_region(cs->hw.ix1.cfg_reg, 4, "ix1micro cfg")) { |
290 | printk(KERN_WARNING | 289 | printk(KERN_WARNING |
291 | "HiSax: %s config port %x-%x already in use\n", | 290 | "HiSax: ITK ix1-micro Rev.2 config port " |
292 | CardType[card->typ], | 291 | "%x-%x already in use\n", |
293 | cs->hw.ix1.cfg_reg, | 292 | cs->hw.ix1.cfg_reg, |
294 | cs->hw.ix1.cfg_reg + 4); | 293 | cs->hw.ix1.cfg_reg + 4); |
295 | return (0); | 294 | return (0); |
296 | } | 295 | } |
297 | } | 296 | } |
298 | printk(KERN_INFO "HiSax: %s config irq:%d io:0x%X\n", | 297 | printk(KERN_INFO "HiSax: ITK ix1-micro Rev.2 config irq:%d io:0x%X\n", |
299 | CardType[cs->typ], cs->irq, cs->hw.ix1.cfg_reg); | 298 | cs->irq, cs->hw.ix1.cfg_reg); |
300 | setup_isac(cs); | 299 | setup_isac(cs); |
301 | cs->readisac = &ReadISAC; | 300 | cs->readisac = &ReadISAC; |
302 | cs->writeisac = &WriteISAC; | 301 | cs->writeisac = &WriteISAC; |