diff options
author | Alan Cox <alan@lxorguk.ukuu.org.uk> | 2006-10-03 04:13:55 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-10-03 11:03:41 -0400 |
commit | 17a4506d0eb1f78c9018c06a79e7dd09ae78c3a8 (patch) | |
tree | 6d0721b3570cc189300f3c7035d12cfa634183f5 /drivers/isdn/hisax/hisax_fcpcipnp.c | |
parent | 31e7e1a806dab5e8e218b78e1b41887a4f6dfcc0 (diff) |
[PATCH] ISDN warning fixes
Clean up warnings in drivers/isdn by using long not int for the values
where we pass void * and cast to integer types. The code is ok (ok passing
the stuff this way isn't pretty but the code is valid). In all the cases I
checked out the right thing happens anyway but this removes all the
warnings.
Signed-off-by: Alan Cox <alan@redhat.com>
Cc: Jeff Garzik <jeff@garzik.org>
Acked-by: Karsten Keil <kkeil@suse.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'drivers/isdn/hisax/hisax_fcpcipnp.c')
-rw-r--r-- | drivers/isdn/hisax/hisax_fcpcipnp.c | 17 |
1 files changed, 7 insertions, 10 deletions
diff --git a/drivers/isdn/hisax/hisax_fcpcipnp.c b/drivers/isdn/hisax/hisax_fcpcipnp.c index 1d7cf3bd6aa3..881a4165cfb4 100644 --- a/drivers/isdn/hisax/hisax_fcpcipnp.c +++ b/drivers/isdn/hisax/hisax_fcpcipnp.c | |||
@@ -546,7 +546,7 @@ static inline void hdlc_xpr_irq(struct fritz_bcs *bcs) | |||
546 | } | 546 | } |
547 | bcs->tx_cnt = 0; | 547 | bcs->tx_cnt = 0; |
548 | bcs->tx_skb = NULL; | 548 | bcs->tx_skb = NULL; |
549 | B_L1L2(bcs, PH_DATA | CONFIRM, (void *) skb->truesize); | 549 | B_L1L2(bcs, PH_DATA | CONFIRM, (void *)(unsigned long)skb->truesize); |
550 | dev_kfree_skb_irq(skb); | 550 | dev_kfree_skb_irq(skb); |
551 | } | 551 | } |
552 | 552 | ||
@@ -635,7 +635,7 @@ static void fritz_b_l2l1(struct hisax_if *ifc, int pr, void *arg) | |||
635 | hdlc_fill_fifo(bcs); | 635 | hdlc_fill_fifo(bcs); |
636 | break; | 636 | break; |
637 | case PH_ACTIVATE | REQUEST: | 637 | case PH_ACTIVATE | REQUEST: |
638 | mode = (int) arg; | 638 | mode = (long) arg; |
639 | DBG(4,"B%d,PH_ACTIVATE_REQUEST %d", bcs->channel + 1, mode); | 639 | DBG(4,"B%d,PH_ACTIVATE_REQUEST %d", bcs->channel + 1, mode); |
640 | modehdlc(bcs, mode); | 640 | modehdlc(bcs, mode); |
641 | B_L1L2(bcs, PH_ACTIVATE | INDICATION, NULL); | 641 | B_L1L2(bcs, PH_ACTIVATE | INDICATION, NULL); |
@@ -998,18 +998,15 @@ static int __init hisax_fcpcipnp_init(void) | |||
998 | 998 | ||
999 | retval = pci_register_driver(&fcpci_driver); | 999 | retval = pci_register_driver(&fcpci_driver); |
1000 | if (retval) | 1000 | if (retval) |
1001 | goto out; | 1001 | return retval; |
1002 | #ifdef __ISAPNP__ | 1002 | #ifdef __ISAPNP__ |
1003 | retval = pnp_register_driver(&fcpnp_driver); | 1003 | retval = pnp_register_driver(&fcpnp_driver); |
1004 | if (retval < 0) | 1004 | if (retval < 0) { |
1005 | goto out_unregister_pci; | 1005 | pci_unregister_driver(&fcpci_driver); |
1006 | return retval; | ||
1007 | } | ||
1006 | #endif | 1008 | #endif |
1007 | return 0; | 1009 | return 0; |
1008 | |||
1009 | out_unregister_pci: | ||
1010 | pci_unregister_driver(&fcpci_driver); | ||
1011 | out: | ||
1012 | return retval; | ||
1013 | } | 1010 | } |
1014 | 1011 | ||
1015 | static void __exit hisax_fcpcipnp_exit(void) | 1012 | static void __exit hisax_fcpcipnp_exit(void) |