diff options
author | Jeff Garzik <jeff@garzik.org> | 2007-10-31 03:42:07 -0400 |
---|---|---|
committer | Jeff Garzik <jgarzik@redhat.com> | 2008-04-20 18:22:31 -0400 |
commit | 8349304d12cf1313bdbd6eb2083701d86809be24 (patch) | |
tree | 599d43c202cda35b80966d9f364559484ca4145a /drivers/isdn/hisax/asuscom.c | |
parent | d38c8475b4f3a684ac673dcedc88ffdb17b74882 (diff) |
[ISDN] Hisax: eliminate many unnecessary references to CardType[]
For the vast majority of CardType[card->typ] uses (but not all!),
the string is constant for each driver. Therefore, we may replace
CardType[card->typ] with the actual string describing the driver, making
each printk() a bit more simple.
This also has the nice, intended side effect of greatly reducing
external references to hisax global CardType[]. This will be of value
once the ISDN drivers are converted to the ISA/PCI/PNP hotplug APIs.
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
Diffstat (limited to 'drivers/isdn/hisax/asuscom.c')
-rw-r--r-- | drivers/isdn/hisax/asuscom.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/drivers/isdn/hisax/asuscom.c b/drivers/isdn/hisax/asuscom.c index 61e69e9c4aa9..b96f3184c2e5 100644 --- a/drivers/isdn/hisax/asuscom.c +++ b/drivers/isdn/hisax/asuscom.c | |||
@@ -20,8 +20,6 @@ | |||
20 | #include "hscx.h" | 20 | #include "hscx.h" |
21 | #include "isdnl1.h" | 21 | #include "isdnl1.h" |
22 | 22 | ||
23 | extern const char *CardType[]; | ||
24 | |||
25 | static const char *Asuscom_revision = "$Revision: 1.14.2.4 $"; | 23 | static const char *Asuscom_revision = "$Revision: 1.14.2.4 $"; |
26 | 24 | ||
27 | #define byteout(addr,val) outb(val,addr) | 25 | #define byteout(addr,val) outb(val,addr) |
@@ -376,8 +374,7 @@ setup_asuscom(struct IsdnCard *card) | |||
376 | cs->irq = card->para[0]; | 374 | cs->irq = card->para[0]; |
377 | if (!request_region(cs->hw.asus.cfg_reg, bytecnt, "asuscom isdn")) { | 375 | if (!request_region(cs->hw.asus.cfg_reg, bytecnt, "asuscom isdn")) { |
378 | printk(KERN_WARNING | 376 | printk(KERN_WARNING |
379 | "HiSax: %s config port %x-%x already in use\n", | 377 | "HiSax: ISDNLink config port %x-%x already in use\n", |
380 | CardType[card->typ], | ||
381 | cs->hw.asus.cfg_reg, | 378 | cs->hw.asus.cfg_reg, |
382 | cs->hw.asus.cfg_reg + bytecnt); | 379 | cs->hw.asus.cfg_reg + bytecnt); |
383 | return (0); | 380 | return (0); |