proc_fops: convert drivers/isdn/ to seq_file

Convert code away from ->read_proc/->write_proc interfaces.  Switch to
proc_create()/proc_create_data() which make addition of proc entries
reliable wrt NULL ->proc_fops, NULL ->data and so on.

Problem with ->read_proc et al is described here commit
786d7e1612f0b0adb6046f19b906609e4fe8b1ba "Fix rmmod/read/write races in
/proc entries"

[akpm@linux-foundation.org: CONFIG_PROC_FS=n build fix]
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Tilman Schmidt <tilman@imap.cc>
Signed-off-by: Karsten Keil <keil@b1-systems.de>
Signed-off-by: David S. Miller <davem@davemloft.net>

9 files changed, 107 insertions, 89 deletions

diff --git a/drivers/isdn/hardware/avm/avmcard.h b/drivers/isdn/hardware/avm/avmcard.h
index d964f07e4a56..a70e8854461d 100644
--- a/drivers/isdn/hardware/avm/avmcard.h
+++ b/drivers/isdn/hardware/avm/avmcard.h
@@ -556,8 +556,7 @@ u16  b1_send_message(struct capi_ctr *ctrl, struct sk_buff *skb);
 void b1_parse_version(avmctrl_info *card);
 irqreturn_t b1_interrupt(int interrupt, void *devptr);
 
-int b1ctl_read_proc(char *page, char **start, off_t off,
-                        int count, int *eof, struct capi_ctr *ctrl);
+extern const struct file_operations b1ctl_proc_fops;
 
 avmcard_dmainfo *avmcard_dma_alloc(char *name, struct pci_dev *,
                                    long rsize, long ssize);
@@ -577,7 +576,6 @@ void b1dma_register_appl(struct capi_ctr *ctrl,
                                 capi_register_params *rp);
 void b1dma_release_appl(struct capi_ctr *ctrl, u16 appl);
 u16  b1dma_send_message(struct capi_ctr *ctrl, struct sk_buff *skb);
-int b1dmactl_read_proc(char *page, char **start, off_t off,
-                        int count, int *eof, struct capi_ctr *ctrl);
+extern const struct file_operations b1dmactl_proc_fops;
 
 #endif /* _AVMCARD_H_ */
diff --git a/drivers/isdn/hardware/avm/b1.c b/drivers/isdn/hardware/avm/b1.c
index a7c0083e78a7..c38fa0f4c729 100644
--- a/drivers/isdn/hardware/avm/b1.c
+++ b/drivers/isdn/hardware/avm/b1.c
@@ -12,6 +12,8 @@
 #include <linux/module.h>
 #include <linux/kernel.h>
 #include <linux/pci.h>
+#include <linux/proc_fs.h>
+#include <linux/seq_file.h>
 #include <linux/skbuff.h>
 #include <linux/delay.h>
 #include <linux/mm.h>
@@ -634,18 +636,17 @@ irqreturn_t b1_interrupt(int interrupt, void *devptr)
 }
 
 /* ------------------------------------------------------------- */
-int b1ctl_read_proc(char *page, char **start, off_t off,
-                        int count, int *eof, struct capi_ctr *ctrl)
+static int b1ctl_proc_show(struct seq_file *m, void *v)
 {
+        struct capi_ctr *ctrl = m->private;
         avmctrl_info *cinfo = (avmctrl_info *)(ctrl->driverdata);
         avmcard *card = cinfo->card;
         u8 flag;
-        int len = 0;
         char *s;
 
-        len += sprintf(page+len, "%-16s %s\n", "name", card->name);
-        len += sprintf(page+len, "%-16s 0x%x\n", "io", card->port);
-        len += sprintf(page+len, "%-16s %d\n", "irq", card->irq);
+        seq_printf(m, "%-16s %s\n", "name", card->name);
+        seq_printf(m, "%-16s 0x%x\n", "io", card->port);
+        seq_printf(m, "%-16s %d\n", "irq", card->irq);
         switch (card->cardtype) {
         case avm_b1isa: s = "B1 ISA"; break;
         case avm_b1pci: s = "B1 PCI"; break;
@@ -658,20 +659,20 @@ int b1ctl_read_proc(char *page, char **start, off_t off,
         case avm_c2: s = "C2"; break;
         default: s = "???"; break;
         }
-        len += sprintf(page+len, "%-16s %s\n", "type", s);
+        seq_printf(m, "%-16s %s\n", "type", s);
         if (card->cardtype == avm_t1isa)
-           len += sprintf(page+len, "%-16s %d\n", "cardnr", card->cardnr);
+                seq_printf(m, "%-16s %d\n", "cardnr", card->cardnr);
         if ((s = cinfo->version[VER_DRIVER]) != NULL)
-           len += sprintf(page+len, "%-16s %s\n", "ver_driver", s);
+                seq_printf(m, "%-16s %s\n", "ver_driver", s);
         if ((s = cinfo->version[VER_CARDTYPE]) != NULL)
-           len += sprintf(page+len, "%-16s %s\n", "ver_cardtype", s);
+                seq_printf(m, "%-16s %s\n", "ver_cardtype", s);
         if ((s = cinfo->version[VER_SERIAL]) != NULL)
-           len += sprintf(page+len, "%-16s %s\n", "ver_serial", s);
+                seq_printf(m, "%-16s %s\n", "ver_serial", s);
 
         if (card->cardtype != avm_m1) {
                 flag = ((u8 *)(ctrl->profile.manu))[3];
                 if (flag)
-                        len += sprintf(page+len, "%-16s%s%s%s%s%s%s%s\n",
+                        seq_printf(m, "%-16s%s%s%s%s%s%s%s\n",
                         "protocol",
                         (flag & 0x01) ? " DSS1" : "",
                         (flag & 0x02) ? " CT1" : "",
@@ -685,7 +686,7 @@ int b1ctl_read_proc(char *page, char **start, off_t off,
         if (card->cardtype != avm_m1) {
                 flag = ((u8 *)(ctrl->profile.manu))[5];
                 if (flag)
-                        len += sprintf(page+len, "%-16s%s%s%s%s\n",
+                        seq_printf(m, "%-16s%s%s%s%s\n",
                         "linetype",
                         (flag & 0x01) ? " point to point" : "",
                         (flag & 0x02) ? " point to multipoint" : "",
@@ -693,16 +694,25 @@ int b1ctl_read_proc(char *page, char **start, off_t off,
                         (flag & 0x04) ? " leased line with D-channel" : ""
                         );
         }
-        len += sprintf(page+len, "%-16s %s\n", "cardname", cinfo->cardname);
-
-        if (off+count >= len)
-           *eof = 1;
-        if (len < off)
-           return 0;
-        *start = page + off;
-        return ((count < len-off) ? count : len-off);
+        seq_printf(m, "%-16s %s\n", "cardname", cinfo->cardname);
+
+        return 0;
+}
+
+static int b1ctl_proc_open(struct inode *inode, struct file *file)
+{
+        return single_open(file, b1ctl_proc_show, PDE(inode)->data);
 }
 
+const struct file_operations b1ctl_proc_fops = {
+        .owner          = THIS_MODULE,
+        .open           = b1ctl_proc_open,
+        .read           = seq_read,
+        .llseek         = seq_lseek,
+        .release        = single_release,
+};
+EXPORT_SYMBOL(b1ctl_proc_fops);
+
 /* ------------------------------------------------------------- */
 
 #ifdef CONFIG_PCI
@@ -781,8 +791,6 @@ EXPORT_SYMBOL(b1_send_message);
 EXPORT_SYMBOL(b1_parse_version);
 EXPORT_SYMBOL(b1_interrupt);
 
-EXPORT_SYMBOL(b1ctl_read_proc);
-
 static int __init b1_init(void)
 {
         char *p;
diff --git a/drivers/isdn/hardware/avm/b1dma.c b/drivers/isdn/hardware/avm/b1dma.c
index 0e84aaae43fd..124550d0dbf3 100644
--- a/drivers/isdn/hardware/avm/b1dma.c
+++ b/drivers/isdn/hardware/avm/b1dma.c
@@ -11,6 +11,8 @@
 
 #include <linux/module.h>
 #include <linux/kernel.h>
+#include <linux/proc_fs.h>
+#include <linux/seq_file.h>
 #include <linux/skbuff.h>
 #include <linux/delay.h>
 #include <linux/mm.h>
@@ -855,21 +857,20 @@ u16 b1dma_send_message(struct capi_ctr *ctrl, struct sk_buff *skb)
 
 /* ------------------------------------------------------------- */
 
-int b1dmactl_read_proc(char *page, char **start, off_t off,
-                        int count, int *eof, struct capi_ctr *ctrl)
+static int b1dmactl_proc_show(struct seq_file *m, void *v)
 {
+        struct capi_ctr *ctrl = m->private;
         avmctrl_info *cinfo = (avmctrl_info *)(ctrl->driverdata);
         avmcard *card = cinfo->card;
         u8 flag;
-        int len = 0;
         char *s;
         u32 txoff, txlen, rxoff, rxlen, csr;
         unsigned long flags;
 
-        len += sprintf(page+len, "%-16s %s\n", "name", card->name);
-        len += sprintf(page+len, "%-16s 0x%x\n", "io", card->port);
-        len += sprintf(page+len, "%-16s %d\n", "irq", card->irq);
-        len += sprintf(page+len, "%-16s 0x%lx\n", "membase", card->membase);
+        seq_printf(m, "%-16s %s\n", "name", card->name);
+        seq_printf(m, "%-16s 0x%x\n", "io", card->port);
+        seq_printf(m, "%-16s %d\n", "irq", card->irq);
+        seq_printf(m, "%-16s 0x%lx\n", "membase", card->membase);
         switch (card->cardtype) {
         case avm_b1isa: s = "B1 ISA"; break;
         case avm_b1pci: s = "B1 PCI"; break;
@@ -882,18 +883,18 @@ int b1dmactl_read_proc(char *page, char **start, off_t off,
         case avm_c2: s = "C2"; break;
         default: s = "???"; break;
         }
-        len += sprintf(page+len, "%-16s %s\n", "type", s);
+        seq_printf(m, "%-16s %s\n", "type", s);
         if ((s = cinfo->version[VER_DRIVER]) != NULL)
-           len += sprintf(page+len, "%-16s %s\n", "ver_driver", s);
+                seq_printf(m, "%-16s %s\n", "ver_driver", s);
         if ((s = cinfo->version[VER_CARDTYPE]) != NULL)
-           len += sprintf(page+len, "%-16s %s\n", "ver_cardtype", s);
+                seq_printf(m, "%-16s %s\n", "ver_cardtype", s);
         if ((s = cinfo->version[VER_SERIAL]) != NULL)
-           len += sprintf(page+len, "%-16s %s\n", "ver_serial", s);
+                seq_printf(m, "%-16s %s\n", "ver_serial", s);
 
         if (card->cardtype != avm_m1) {
                 flag = ((u8 *)(ctrl->profile.manu))[3];
                 if (flag)
-                        len += sprintf(page+len, "%-16s%s%s%s%s%s%s%s\n",
+                        seq_printf(m, "%-16s%s%s%s%s%s%s%s\n",
                         "protocol",
                         (flag & 0x01) ? " DSS1" : "",
                         (flag & 0x02) ? " CT1" : "",
@@ -907,7 +908,7 @@ int b1dmactl_read_proc(char *page, char **start, off_t off,
         if (card->cardtype != avm_m1) {
                 flag = ((u8 *)(ctrl->profile.manu))[5];
                 if (flag)
-                        len += sprintf(page+len, "%-16s%s%s%s%s\n",
+                        seq_printf(m, "%-16s%s%s%s%s\n",
                         "linetype",
                         (flag & 0x01) ? " point to point" : "",
                         (flag & 0x02) ? " point to multipoint" : "",
@@ -915,7 +916,7 @@ int b1dmactl_read_proc(char *page, char **start, off_t off,
                         (flag & 0x04) ? " leased line with D-channel" : ""
                         );
         }
-        len += sprintf(page+len, "%-16s %s\n", "cardname", cinfo->cardname);
+        seq_printf(m, "%-16s %s\n", "cardname", cinfo->cardname);
 
 
         spin_lock_irqsave(&card->lock, flags);
@@ -930,27 +931,30 @@ int b1dmactl_read_proc(char *page, char **start, off_t off,
 
         spin_unlock_irqrestore(&card->lock, flags);
 
-        len += sprintf(page+len, "%-16s 0x%lx\n",
-                                "csr (cached)", (unsigned long)card->csr);
-        len += sprintf(page+len, "%-16s 0x%lx\n",
-                                "csr", (unsigned long)csr);
-        len += sprintf(page+len, "%-16s %lu\n",
-                                "txoff", (unsigned long)txoff);
-        len += sprintf(page+len, "%-16s %lu\n",
-                                "txlen", (unsigned long)txlen);
-        len += sprintf(page+len, "%-16s %lu\n",
-                                "rxoff", (unsigned long)rxoff);
-        len += sprintf(page+len, "%-16s %lu\n",
-                                "rxlen", (unsigned long)rxlen);
-
-        if (off+count >= len)
-           *eof = 1;
-        if (len < off)
-           return 0;
-        *start = page + off;
-        return ((count < len-off) ? count : len-off);
+        seq_printf(m, "%-16s 0x%lx\n", "csr (cached)", (unsigned long)card->csr);
+        seq_printf(m, "%-16s 0x%lx\n", "csr", (unsigned long)csr);
+        seq_printf(m, "%-16s %lu\n", "txoff", (unsigned long)txoff);
+        seq_printf(m, "%-16s %lu\n", "txlen", (unsigned long)txlen);
+        seq_printf(m, "%-16s %lu\n", "rxoff", (unsigned long)rxoff);
+        seq_printf(m, "%-16s %lu\n", "rxlen", (unsigned long)rxlen);
+
+        return 0;
+}
+
+static int b1dmactl_proc_open(struct inode *inode, struct file *file)
+{
+        return single_open(file, b1dmactl_proc_show, PDE(inode)->data);
 }
 
+const struct file_operations b1dmactl_proc_fops = {
+        .owner          = THIS_MODULE,
+        .open           = b1dmactl_proc_open,
+        .read           = seq_read,
+        .llseek         = seq_lseek,
+        .release        = single_release,
+};
+EXPORT_SYMBOL(b1dmactl_proc_fops);
+
 /* ------------------------------------------------------------- */
 
 EXPORT_SYMBOL(b1dma_reset);
@@ -963,7 +967,6 @@ EXPORT_SYMBOL(b1dma_reset_ctr);
 EXPORT_SYMBOL(b1dma_register_appl);
 EXPORT_SYMBOL(b1dma_release_appl);
 EXPORT_SYMBOL(b1dma_send_message);
-EXPORT_SYMBOL(b1dmactl_read_proc);
 
 static int __init b1dma_init(void)
 {
diff --git a/drivers/isdn/hardware/avm/b1isa.c b/drivers/isdn/hardware/avm/b1isa.c
index 6461a32bc838..ff5390546f92 100644
--- a/drivers/isdn/hardware/avm/b1isa.c
+++ b/drivers/isdn/hardware/avm/b1isa.c
@@ -121,7 +121,7 @@ static int b1isa_probe(struct pci_dev *pdev)
         cinfo->capi_ctrl.load_firmware = b1_load_firmware;
         cinfo->capi_ctrl.reset_ctr     = b1_reset_ctr;
         cinfo->capi_ctrl.procinfo      = b1isa_procinfo;
-        cinfo->capi_ctrl.ctr_read_proc = b1ctl_read_proc;
+        cinfo->capi_ctrl.proc_fops = &b1ctl_proc_fops;
         strcpy(cinfo->capi_ctrl.name, card->name);
 
         retval = attach_capi_ctr(&cinfo->capi_ctrl);
diff --git a/drivers/isdn/hardware/avm/b1pci.c b/drivers/isdn/hardware/avm/b1pci.c
index 5b314a2c4049..c97e4315079d 100644
--- a/drivers/isdn/hardware/avm/b1pci.c
+++ b/drivers/isdn/hardware/avm/b1pci.c
@@ -112,7 +112,7 @@ static int b1pci_probe(struct capicardparams *p, struct pci_dev *pdev)
         cinfo->capi_ctrl.load_firmware = b1_load_firmware;
         cinfo->capi_ctrl.reset_ctr     = b1_reset_ctr;
         cinfo->capi_ctrl.procinfo      = b1pci_procinfo;
-        cinfo->capi_ctrl.ctr_read_proc = b1ctl_read_proc;
+        cinfo->capi_ctrl.proc_fops = &b1ctl_proc_fops;
         strcpy(cinfo->capi_ctrl.name, card->name);
         cinfo->capi_ctrl.owner         = THIS_MODULE;
 
@@ -251,7 +251,7 @@ static int b1pciv4_probe(struct capicardparams *p, struct pci_dev *pdev)
         cinfo->capi_ctrl.load_firmware = b1dma_load_firmware;
         cinfo->capi_ctrl.reset_ctr     = b1dma_reset_ctr;
         cinfo->capi_ctrl.procinfo      = b1pciv4_procinfo;
-        cinfo->capi_ctrl.ctr_read_proc = b1dmactl_read_proc;
+        cinfo->capi_ctrl.proc_fops = &b1dmactl_proc_fops;
         strcpy(cinfo->capi_ctrl.name, card->name);
 
         retval = attach_capi_ctr(&cinfo->capi_ctrl);
diff --git a/drivers/isdn/hardware/avm/b1pcmcia.c b/drivers/isdn/hardware/avm/b1pcmcia.c
index 7740403b40e1..d6391e0afeea 100644
--- a/drivers/isdn/hardware/avm/b1pcmcia.c
+++ b/drivers/isdn/hardware/avm/b1pcmcia.c
@@ -108,7 +108,7 @@ static int b1pcmcia_add_card(unsigned int port, unsigned irq,
         cinfo->capi_ctrl.load_firmware = b1_load_firmware;
         cinfo->capi_ctrl.reset_ctr     = b1_reset_ctr;
         cinfo->capi_ctrl.procinfo      = b1pcmcia_procinfo;
-        cinfo->capi_ctrl.ctr_read_proc = b1ctl_read_proc;
+        cinfo->capi_ctrl.proc_fops = &b1ctl_proc_fops;
         strcpy(cinfo->capi_ctrl.name, card->name);
 
         retval = attach_capi_ctr(&cinfo->capi_ctrl);
diff --git a/drivers/isdn/hardware/avm/c4.c b/drivers/isdn/hardware/avm/c4.c
index 6833301a45fc..de6e6b311819 100644
--- a/drivers/isdn/hardware/avm/c4.c
+++ b/drivers/isdn/hardware/avm/c4.c
@@ -11,6 +11,8 @@
 
 #include <linux/module.h>
 #include <linux/kernel.h>
+#include <linux/proc_fs.h>
+#include <linux/seq_file.h>
 #include <linux/skbuff.h>
 #include <linux/delay.h>
 #include <linux/mm.h>
@@ -1062,19 +1064,18 @@ static char *c4_procinfo(struct capi_ctr *ctrl)
         return cinfo->infobuf;
 }
 
-static int c4_read_proc(char *page, char **start, off_t off,
-                        int count, int *eof, struct capi_ctr *ctrl)
+static int c4_proc_show(struct seq_file *m, void *v)
 {
+        struct capi_ctr *ctrl = m->private;
         avmctrl_info *cinfo = (avmctrl_info *)(ctrl->driverdata);
         avmcard *card = cinfo->card;
         u8 flag;
-        int len = 0;
         char *s;
 
-        len += sprintf(page+len, "%-16s %s\n", "name", card->name);
-        len += sprintf(page+len, "%-16s 0x%x\n", "io", card->port);
-        len += sprintf(page+len, "%-16s %d\n", "irq", card->irq);
-        len += sprintf(page+len, "%-16s 0x%lx\n", "membase", card->membase);
+        seq_printf(m, "%-16s %s\n", "name", card->name);
+        seq_printf(m, "%-16s 0x%x\n", "io", card->port);
+        seq_printf(m, "%-16s %d\n", "irq", card->irq);
+        seq_printf(m, "%-16s 0x%lx\n", "membase", card->membase);
         switch (card->cardtype) {
         case avm_b1isa: s = "B1 ISA"; break;
         case avm_b1pci: s = "B1 PCI"; break;
@@ -1087,18 +1088,18 @@ static int c4_read_proc(char *page, char **start, off_t off,
         case avm_c2: s = "C2"; break;
         default: s = "???"; break;
         }
-        len += sprintf(page+len, "%-16s %s\n", "type", s);
+        seq_printf(m, "%-16s %s\n", "type", s);
         if ((s = cinfo->version[VER_DRIVER]) != NULL)
-           len += sprintf(page+len, "%-16s %s\n", "ver_driver", s);
+                seq_printf(m, "%-16s %s\n", "ver_driver", s);
         if ((s = cinfo->version[VER_CARDTYPE]) != NULL)
-           len += sprintf(page+len, "%-16s %s\n", "ver_cardtype", s);
+                seq_printf(m, "%-16s %s\n", "ver_cardtype", s);
         if ((s = cinfo->version[VER_SERIAL]) != NULL)
-           len += sprintf(page+len, "%-16s %s\n", "ver_serial", s);
+                seq_printf(m, "%-16s %s\n", "ver_serial", s);
 
         if (card->cardtype != avm_m1) {
                 flag = ((u8 *)(ctrl->profile.manu))[3];
                 if (flag)
-                        len += sprintf(page+len, "%-16s%s%s%s%s%s%s%s\n",
+                        seq_printf(m, "%-16s%s%s%s%s%s%s%s\n",
                         "protocol",
                         (flag & 0x01) ? " DSS1" : "",
                         (flag & 0x02) ? " CT1" : "",
@@ -1112,7 +1113,7 @@ static int c4_read_proc(char *page, char **start, off_t off,
         if (card->cardtype != avm_m1) {
                 flag = ((u8 *)(ctrl->profile.manu))[5];
                 if (flag)
-                        len += sprintf(page+len, "%-16s%s%s%s%s\n",
+                        seq_printf(m, "%-16s%s%s%s%s\n",
                         "linetype",
                         (flag & 0x01) ? " point to point" : "",
                         (flag & 0x02) ? " point to multipoint" : "",
@@ -1120,16 +1121,24 @@ static int c4_read_proc(char *page, char **start, off_t off,
                         (flag & 0x04) ? " leased line with D-channel" : ""
                         );
         }
-        len += sprintf(page+len, "%-16s %s\n", "cardname", cinfo->cardname);
-
-        if (off+count >= len)
-           *eof = 1;
-        if (len < off)
-           return 0;
-        *start = page + off;
-        return ((count < len-off) ? count : len-off);
+        seq_printf(m, "%-16s %s\n", "cardname", cinfo->cardname);
+
+        return 0;
 }
 
+static int c4_proc_open(struct inode *inode, struct file *file)
+{
+        return single_open(file, c4_proc_show, PDE(inode)->data);
+}
+
+static const struct file_operations c4_proc_fops = {
+        .owner          = THIS_MODULE,
+        .open           = c4_proc_open,
+        .read           = seq_read,
+        .llseek         = seq_lseek,
+        .release        = single_release,
+};
+
 /* ------------------------------------------------------------- */
 
 static int c4_add_card(struct capicardparams *p, struct pci_dev *dev,
@@ -1201,7 +1210,7 @@ static int c4_add_card(struct capicardparams *p, struct pci_dev *dev,
                 cinfo->capi_ctrl.load_firmware = c4_load_firmware;
                 cinfo->capi_ctrl.reset_ctr     = c4_reset_ctr;
                 cinfo->capi_ctrl.procinfo      = c4_procinfo;
-                cinfo->capi_ctrl.ctr_read_proc = c4_read_proc;
+                cinfo->capi_ctrl.proc_fops = &c4_proc_fops;
                 strcpy(cinfo->capi_ctrl.name, card->name);
 
                 retval = attach_capi_ctr(&cinfo->capi_ctrl);
diff --git a/drivers/isdn/hardware/avm/t1isa.c b/drivers/isdn/hardware/avm/t1isa.c
index 1c53fd49adb6..baeeb3c2a3ee 100644
--- a/drivers/isdn/hardware/avm/t1isa.c
+++ b/drivers/isdn/hardware/avm/t1isa.c
@@ -429,7 +429,7 @@ static int t1isa_probe(struct pci_dev *pdev, int cardnr)
         cinfo->capi_ctrl.load_firmware = t1isa_load_firmware;
         cinfo->capi_ctrl.reset_ctr     = t1isa_reset_ctr;
         cinfo->capi_ctrl.procinfo      = t1isa_procinfo;
-        cinfo->capi_ctrl.ctr_read_proc = b1ctl_read_proc;
+        cinfo->capi_ctrl.proc_fops = &b1ctl_proc_fops;
         strcpy(cinfo->capi_ctrl.name, card->name);
 
         retval = attach_capi_ctr(&cinfo->capi_ctrl);
diff --git a/drivers/isdn/hardware/avm/t1pci.c b/drivers/isdn/hardware/avm/t1pci.c
index e6d298d75146..5a3f83098018 100644
--- a/drivers/isdn/hardware/avm/t1pci.c
+++ b/drivers/isdn/hardware/avm/t1pci.c
@@ -119,7 +119,7 @@ static int t1pci_add_card(struct capicardparams *p, struct pci_dev *pdev)
         cinfo->capi_ctrl.load_firmware = b1dma_load_firmware;
         cinfo->capi_ctrl.reset_ctr     = b1dma_reset_ctr;
         cinfo->capi_ctrl.procinfo      = t1pci_procinfo;
-        cinfo->capi_ctrl.ctr_read_proc = b1dmactl_read_proc;
+        cinfo->capi_ctrl.proc_fops = &b1dmactl_proc_fops;
         strcpy(cinfo->capi_ctrl.name, card->name);
 
         retval = attach_capi_ctr(&cinfo->capi_ctrl);