diff options
author | Tilman Schmidt <tilman@imap.cc> | 2010-02-22 08:09:52 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2010-02-26 04:24:23 -0500 |
commit | 1528b18f7ec2b907711f37667c68e10d9296c882 (patch) | |
tree | 00c887ea15474334898ae1f89a05706be49079ed /drivers/isdn/gigaset/bas-gigaset.c | |
parent | 63e055d1c6e3a5f6d370cc841d621d5fa4d5d834 (diff) |
gigaset: reduce syslog clutter
Improve readability of the Gigaset driver's kernel messages by
removing a few unnecessary messages and limiting the emission
of some debug messages more narrowly.
Impact: logging
Signed-off-by: Tilman Schmidt <tilman@imap.cc>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/isdn/gigaset/bas-gigaset.c')
-rw-r--r-- | drivers/isdn/gigaset/bas-gigaset.c | 18 |
1 files changed, 6 insertions, 12 deletions
diff --git a/drivers/isdn/gigaset/bas-gigaset.c b/drivers/isdn/gigaset/bas-gigaset.c index 95ebc5129895..0be15c70c16d 100644 --- a/drivers/isdn/gigaset/bas-gigaset.c +++ b/drivers/isdn/gigaset/bas-gigaset.c | |||
@@ -347,12 +347,7 @@ static inline void error_hangup(struct bc_state *bcs) | |||
347 | { | 347 | { |
348 | struct cardstate *cs = bcs->cs; | 348 | struct cardstate *cs = bcs->cs; |
349 | 349 | ||
350 | gig_dbg(DEBUG_ANY, "%s: scheduling HUP for channel %d", | 350 | gigaset_add_event(cs, &bcs->at_state, EV_HUP, NULL, 0, NULL); |
351 | __func__, bcs->channel); | ||
352 | |||
353 | if (!gigaset_add_event(cs, &bcs->at_state, EV_HUP, NULL, 0, NULL)) | ||
354 | dev_err(cs->dev, "event queue full\n"); | ||
355 | |||
356 | gigaset_schedule_event(cs); | 351 | gigaset_schedule_event(cs); |
357 | } | 352 | } |
358 | 353 | ||
@@ -1706,8 +1701,7 @@ static void complete_cb(struct cardstate *cs) | |||
1706 | 1701 | ||
1707 | /* unqueue completed buffer */ | 1702 | /* unqueue completed buffer */ |
1708 | cs->cmdbytes -= cs->curlen; | 1703 | cs->cmdbytes -= cs->curlen; |
1709 | gig_dbg(DEBUG_TRANSCMD|DEBUG_LOCKCMD, | 1704 | gig_dbg(DEBUG_OUTPUT, "write_command: sent %u bytes, %u left", |
1710 | "write_command: sent %u bytes, %u left", | ||
1711 | cs->curlen, cs->cmdbytes); | 1705 | cs->curlen, cs->cmdbytes); |
1712 | if (cb->next != NULL) { | 1706 | if (cb->next != NULL) { |
1713 | cs->cmdbuf = cb->next; | 1707 | cs->cmdbuf = cb->next; |
@@ -1881,13 +1875,13 @@ static int start_cbsend(struct cardstate *cs) | |||
1881 | 1875 | ||
1882 | /* check if suspend requested */ | 1876 | /* check if suspend requested */ |
1883 | if (ucs->basstate & BS_SUSPEND) { | 1877 | if (ucs->basstate & BS_SUSPEND) { |
1884 | gig_dbg(DEBUG_TRANSCMD|DEBUG_LOCKCMD, "suspending"); | 1878 | gig_dbg(DEBUG_OUTPUT, "suspending"); |
1885 | return -EHOSTUNREACH; | 1879 | return -EHOSTUNREACH; |
1886 | } | 1880 | } |
1887 | 1881 | ||
1888 | /* check if AT channel is open */ | 1882 | /* check if AT channel is open */ |
1889 | if (!(ucs->basstate & BS_ATOPEN)) { | 1883 | if (!(ucs->basstate & BS_ATOPEN)) { |
1890 | gig_dbg(DEBUG_TRANSCMD|DEBUG_LOCKCMD, "AT channel not open"); | 1884 | gig_dbg(DEBUG_OUTPUT, "AT channel not open"); |
1891 | rc = req_submit(cs->bcs, HD_OPEN_ATCHANNEL, 0, BAS_TIMEOUT); | 1885 | rc = req_submit(cs->bcs, HD_OPEN_ATCHANNEL, 0, BAS_TIMEOUT); |
1892 | if (rc < 0) { | 1886 | if (rc < 0) { |
1893 | /* flush command queue */ | 1887 | /* flush command queue */ |
@@ -2251,7 +2245,7 @@ static int gigaset_probe(struct usb_interface *interface, | |||
2251 | int i, j; | 2245 | int i, j; |
2252 | int rc; | 2246 | int rc; |
2253 | 2247 | ||
2254 | gig_dbg(DEBUG_ANY, | 2248 | gig_dbg(DEBUG_INIT, |
2255 | "%s: Check if device matches .. (Vendor: 0x%x, Product: 0x%x)", | 2249 | "%s: Check if device matches .. (Vendor: 0x%x, Product: 0x%x)", |
2256 | __func__, le16_to_cpu(udev->descriptor.idVendor), | 2250 | __func__, le16_to_cpu(udev->descriptor.idVendor), |
2257 | le16_to_cpu(udev->descriptor.idProduct)); | 2251 | le16_to_cpu(udev->descriptor.idProduct)); |
@@ -2259,7 +2253,7 @@ static int gigaset_probe(struct usb_interface *interface, | |||
2259 | /* set required alternate setting */ | 2253 | /* set required alternate setting */ |
2260 | hostif = interface->cur_altsetting; | 2254 | hostif = interface->cur_altsetting; |
2261 | if (hostif->desc.bAlternateSetting != 3) { | 2255 | if (hostif->desc.bAlternateSetting != 3) { |
2262 | gig_dbg(DEBUG_ANY, | 2256 | gig_dbg(DEBUG_INIT, |
2263 | "%s: wrong alternate setting %d - trying to switch", | 2257 | "%s: wrong alternate setting %d - trying to switch", |
2264 | __func__, hostif->desc.bAlternateSetting); | 2258 | __func__, hostif->desc.bAlternateSetting); |
2265 | if (usb_set_interface(udev, hostif->desc.bInterfaceNumber, 3) | 2259 | if (usb_set_interface(udev, hostif->desc.bInterfaceNumber, 3) |