diff options
author | Andreea-Cristina Bernat <bernat.ada@gmail.com> | 2014-08-18 08:20:56 -0400 |
---|---|---|
committer | Joerg Roedel <jroedel@suse.de> | 2014-08-19 07:27:55 -0400 |
commit | eecbad7d0306b9ee4f621517052913d1adaea753 (patch) | |
tree | 262ed578906c82541193831dd1b9b4700a75a87b /drivers/iommu/dmar.c | |
parent | f63ef69028742b09c1c0896177d555a30ff6cf13 (diff) |
iommu: Replace rcu_assign_pointer() with RCU_INIT_POINTER()
The use of "rcu_assign_pointer()" is NULLing out the pointer.
According to RCU_INIT_POINTER()'s block comment:
"1. This use of RCU_INIT_POINTER() is NULLing out the pointer"
it is better to use it instead of rcu_assign_pointer() because it has a
smaller overhead.
The following Coccinelle semantic patch was used:
@@
@@
- rcu_assign_pointer
+ RCU_INIT_POINTER
(..., NULL)
Signed-off-by: Andreea-Cristina Bernat <bernat.ada@gmail.com>
Signed-off-by: Joerg Roedel <jroedel@suse.de>
Diffstat (limited to 'drivers/iommu/dmar.c')
-rw-r--r-- | drivers/iommu/dmar.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/iommu/dmar.c b/drivers/iommu/dmar.c index 60ab474bfff3..8ed55b0a1ce4 100644 --- a/drivers/iommu/dmar.c +++ b/drivers/iommu/dmar.c | |||
@@ -247,7 +247,7 @@ int dmar_remove_dev_scope(struct dmar_pci_notify_info *info, u16 segment, | |||
247 | 247 | ||
248 | for_each_active_dev_scope(devices, count, index, tmp) | 248 | for_each_active_dev_scope(devices, count, index, tmp) |
249 | if (tmp == &info->dev->dev) { | 249 | if (tmp == &info->dev->dev) { |
250 | rcu_assign_pointer(devices[index].dev, NULL); | 250 | RCU_INIT_POINTER(devices[index].dev, NULL); |
251 | synchronize_rcu(); | 251 | synchronize_rcu(); |
252 | put_device(tmp); | 252 | put_device(tmp); |
253 | return 1; | 253 | return 1; |