diff options
author | Joerg Roedel <joerg.roedel@amd.com> | 2012-07-06 07:28:37 -0400 |
---|---|---|
committer | Joerg Roedel <joerg.roedel@amd.com> | 2012-07-17 06:14:55 -0400 |
commit | 98f1ad258254d89ffb550a36d59caf9127a9d53f (patch) | |
tree | 4d4bd90b5e052e9f444ce84ec3648397fcb56ec7 /drivers/iommu/amd_iommu_init.c | |
parent | 84a1caf1453c3d44050bd22db958af4a7f99315c (diff) |
iommu/amd: Fix sparse warnings
A few sparse warnings fire in drivers/iommu/amd_iommu_init.c.
Fix most of them with this patch. Also fix the sparse
warnings in drivers/iommu/irq_remapping.c while at it.
Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
Diffstat (limited to 'drivers/iommu/amd_iommu_init.c')
-rw-r--r-- | drivers/iommu/amd_iommu_init.c | 16 |
1 files changed, 5 insertions, 11 deletions
diff --git a/drivers/iommu/amd_iommu_init.c b/drivers/iommu/amd_iommu_init.c index a33612f3206f..55f2033ea69b 100644 --- a/drivers/iommu/amd_iommu_init.c +++ b/drivers/iommu/amd_iommu_init.c | |||
@@ -190,12 +190,6 @@ static u32 dev_table_size; /* size of the device table */ | |||
190 | static u32 alias_table_size; /* size of the alias table */ | 190 | static u32 alias_table_size; /* size of the alias table */ |
191 | static u32 rlookup_table_size; /* size if the rlookup table */ | 191 | static u32 rlookup_table_size; /* size if the rlookup table */ |
192 | 192 | ||
193 | /* | ||
194 | * This function flushes all internal caches of | ||
195 | * the IOMMU used by this driver. | ||
196 | */ | ||
197 | extern void iommu_flush_all_caches(struct amd_iommu *iommu); | ||
198 | |||
199 | static int amd_iommu_enable_interrupts(void); | 193 | static int amd_iommu_enable_interrupts(void); |
200 | 194 | ||
201 | static inline void update_last_devid(u16 devid) | 195 | static inline void update_last_devid(u16 devid) |
@@ -358,7 +352,7 @@ static void iommu_disable(struct amd_iommu *iommu) | |||
358 | * mapping and unmapping functions for the IOMMU MMIO space. Each AMD IOMMU in | 352 | * mapping and unmapping functions for the IOMMU MMIO space. Each AMD IOMMU in |
359 | * the system has one. | 353 | * the system has one. |
360 | */ | 354 | */ |
361 | static u8 * __init iommu_map_mmio_space(u64 address) | 355 | static u8 __iomem * __init iommu_map_mmio_space(u64 address) |
362 | { | 356 | { |
363 | if (!request_mem_region(address, MMIO_REGION_LENGTH, "amd_iommu")) { | 357 | if (!request_mem_region(address, MMIO_REGION_LENGTH, "amd_iommu")) { |
364 | pr_err("AMD-Vi: Can not reserve memory region %llx for mmio\n", | 358 | pr_err("AMD-Vi: Can not reserve memory region %llx for mmio\n", |
@@ -367,7 +361,7 @@ static u8 * __init iommu_map_mmio_space(u64 address) | |||
367 | return NULL; | 361 | return NULL; |
368 | } | 362 | } |
369 | 363 | ||
370 | return ioremap_nocache(address, MMIO_REGION_LENGTH); | 364 | return (u8 __iomem *)ioremap_nocache(address, MMIO_REGION_LENGTH); |
371 | } | 365 | } |
372 | 366 | ||
373 | static void __init iommu_unmap_mmio_space(struct amd_iommu *iommu) | 367 | static void __init iommu_unmap_mmio_space(struct amd_iommu *iommu) |
@@ -1217,7 +1211,7 @@ static int __init init_exclusion_range(struct ivmd_header *m) | |||
1217 | /* called for unity map ACPI definition */ | 1211 | /* called for unity map ACPI definition */ |
1218 | static int __init init_unity_map_range(struct ivmd_header *m) | 1212 | static int __init init_unity_map_range(struct ivmd_header *m) |
1219 | { | 1213 | { |
1220 | struct unity_map_entry *e = 0; | 1214 | struct unity_map_entry *e = NULL; |
1221 | char *s; | 1215 | char *s; |
1222 | 1216 | ||
1223 | e = kzalloc(sizeof(*e), GFP_KERNEL); | 1217 | e = kzalloc(sizeof(*e), GFP_KERNEL); |
@@ -1727,8 +1721,8 @@ __setup("amd_iommu=", parse_amd_iommu_options); | |||
1727 | 1721 | ||
1728 | IOMMU_INIT_FINISH(amd_iommu_detect, | 1722 | IOMMU_INIT_FINISH(amd_iommu_detect, |
1729 | gart_iommu_hole_init, | 1723 | gart_iommu_hole_init, |
1730 | 0, | 1724 | NULL, |
1731 | 0); | 1725 | NULL); |
1732 | 1726 | ||
1733 | bool amd_iommu_v2_supported(void) | 1727 | bool amd_iommu_v2_supported(void) |
1734 | { | 1728 | { |