diff options
author | Arjan van de Ven <arjan@linux.intel.com> | 2007-02-12 03:55:32 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-02-12 12:48:45 -0500 |
commit | 2b8693c0617e972fc0b2fd1ebf8de97e15b656c3 (patch) | |
tree | 3eb7dfbc8d5e4031e4992bdd566e211f5ada71f3 /drivers/input | |
parent | 5dfe4c964a0dd7bb3a1d64a4166835a153146207 (diff) |
[PATCH] mark struct file_operations const 3
Many struct file_operations in the kernel can be "const". Marking them const
moves these to the .rodata section, which avoids false sharing with potential
dirty data. In addition it'll catch accidental writes at compile time to
these shared resources.
Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/input')
-rw-r--r-- | drivers/input/input.c | 6 | ||||
-rw-r--r-- | drivers/input/misc/hp_sdc_rtc.c | 2 | ||||
-rw-r--r-- | drivers/input/misc/uinput.c | 2 | ||||
-rw-r--r-- | drivers/input/serio/serio_raw.c | 2 |
4 files changed, 6 insertions, 6 deletions
diff --git a/drivers/input/input.c b/drivers/input/input.c index 7cf2b4f603a3..14d4c0493c36 100644 --- a/drivers/input/input.c +++ b/drivers/input/input.c | |||
@@ -482,7 +482,7 @@ static int input_proc_devices_open(struct inode *inode, struct file *file) | |||
482 | return seq_open(file, &input_devices_seq_ops); | 482 | return seq_open(file, &input_devices_seq_ops); |
483 | } | 483 | } |
484 | 484 | ||
485 | static struct file_operations input_devices_fileops = { | 485 | static const struct file_operations input_devices_fileops = { |
486 | .owner = THIS_MODULE, | 486 | .owner = THIS_MODULE, |
487 | .open = input_proc_devices_open, | 487 | .open = input_proc_devices_open, |
488 | .poll = input_proc_devices_poll, | 488 | .poll = input_proc_devices_poll, |
@@ -533,7 +533,7 @@ static int input_proc_handlers_open(struct inode *inode, struct file *file) | |||
533 | return seq_open(file, &input_handlers_seq_ops); | 533 | return seq_open(file, &input_handlers_seq_ops); |
534 | } | 534 | } |
535 | 535 | ||
536 | static struct file_operations input_handlers_fileops = { | 536 | static const struct file_operations input_handlers_fileops = { |
537 | .owner = THIS_MODULE, | 537 | .owner = THIS_MODULE, |
538 | .open = input_proc_handlers_open, | 538 | .open = input_proc_handlers_open, |
539 | .read = seq_read, | 539 | .read = seq_read, |
@@ -1142,7 +1142,7 @@ static int input_open_file(struct inode *inode, struct file *file) | |||
1142 | return err; | 1142 | return err; |
1143 | } | 1143 | } |
1144 | 1144 | ||
1145 | static struct file_operations input_fops = { | 1145 | static const struct file_operations input_fops = { |
1146 | .owner = THIS_MODULE, | 1146 | .owner = THIS_MODULE, |
1147 | .open = input_open_file, | 1147 | .open = input_open_file, |
1148 | }; | 1148 | }; |
diff --git a/drivers/input/misc/hp_sdc_rtc.c b/drivers/input/misc/hp_sdc_rtc.c index 31d5a13bfd6b..ab76ea442fa5 100644 --- a/drivers/input/misc/hp_sdc_rtc.c +++ b/drivers/input/misc/hp_sdc_rtc.c | |||
@@ -670,7 +670,7 @@ static int hp_sdc_rtc_ioctl(struct inode *inode, struct file *file, | |||
670 | #endif | 670 | #endif |
671 | } | 671 | } |
672 | 672 | ||
673 | static struct file_operations hp_sdc_rtc_fops = { | 673 | static const struct file_operations hp_sdc_rtc_fops = { |
674 | .owner = THIS_MODULE, | 674 | .owner = THIS_MODULE, |
675 | .llseek = no_llseek, | 675 | .llseek = no_llseek, |
676 | .read = hp_sdc_rtc_read, | 676 | .read = hp_sdc_rtc_read, |
diff --git a/drivers/input/misc/uinput.c b/drivers/input/misc/uinput.c index 9516439b7c78..42556232c523 100644 --- a/drivers/input/misc/uinput.c +++ b/drivers/input/misc/uinput.c | |||
@@ -627,7 +627,7 @@ static long uinput_ioctl(struct file *file, unsigned int cmd, unsigned long arg) | |||
627 | return retval; | 627 | return retval; |
628 | } | 628 | } |
629 | 629 | ||
630 | static struct file_operations uinput_fops = { | 630 | static const struct file_operations uinput_fops = { |
631 | .owner = THIS_MODULE, | 631 | .owner = THIS_MODULE, |
632 | .open = uinput_open, | 632 | .open = uinput_open, |
633 | .release = uinput_release, | 633 | .release = uinput_release, |
diff --git a/drivers/input/serio/serio_raw.c b/drivers/input/serio/serio_raw.c index 088ebc348ba3..887357666c68 100644 --- a/drivers/input/serio/serio_raw.c +++ b/drivers/input/serio/serio_raw.c | |||
@@ -234,7 +234,7 @@ static unsigned int serio_raw_poll(struct file *file, poll_table *wait) | |||
234 | return 0; | 234 | return 0; |
235 | } | 235 | } |
236 | 236 | ||
237 | static struct file_operations serio_raw_fops = { | 237 | static const struct file_operations serio_raw_fops = { |
238 | .owner = THIS_MODULE, | 238 | .owner = THIS_MODULE, |
239 | .open = serio_raw_open, | 239 | .open = serio_raw_open, |
240 | .release = serio_raw_release, | 240 | .release = serio_raw_release, |