aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/input/tsdev.c
diff options
context:
space:
mode:
authorDmitry Torokhov <dtor@insightbb.com>2007-06-03 23:29:36 -0400
committerDmitry Torokhov <dtor@insightbb.com>2007-06-03 23:50:05 -0400
commit1dfa2812404c37d7571622195f907cea3331616c (patch)
tree2533af73ff0e1e4d24603967bd6cdc092973dce9 /drivers/input/tsdev.c
parent26be5a509af5f80c7012bd4f0478a94746c9c9d9 (diff)
Input: reduce raciness when input handlers disconnect
There is a race between input handler's release() and disconnect() methods: when input handler disconnects it wakes up all regular users and then process to walk user list to wake up async. users. While disconnect() walks the list release() removes elements of the same list causing oopses. While this is not a substibute for proper locking we can reduce odds of getting an oops if we wake up normal readers after walking the list. Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
Diffstat (limited to 'drivers/input/tsdev.c')
-rw-r--r--drivers/input/tsdev.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/input/tsdev.c b/drivers/input/tsdev.c
index 5e5b5c91d75b..af4581d00d82 100644
--- a/drivers/input/tsdev.c
+++ b/drivers/input/tsdev.c
@@ -477,9 +477,9 @@ static void tsdev_disconnect(struct input_handle *handle)
477 477
478 if (tsdev->open) { 478 if (tsdev->open) {
479 input_close_device(handle); 479 input_close_device(handle);
480 wake_up_interruptible(&tsdev->wait);
481 list_for_each_entry(client, &tsdev->client_list, node) 480 list_for_each_entry(client, &tsdev->client_list, node)
482 kill_fasync(&client->fasync, SIGIO, POLL_HUP); 481 kill_fasync(&client->fasync, SIGIO, POLL_HUP);
482 wake_up_interruptible(&tsdev->wait);
483 } else 483 } else
484 tsdev_free(tsdev); 484 tsdev_free(tsdev);
485} 485}