diff options
author | Jason Gerecke <killertofu@gmail.com> | 2012-03-13 01:15:43 -0400 |
---|---|---|
committer | Dmitry Torokhov <dmitry.torokhov@gmail.com> | 2012-03-13 01:19:14 -0400 |
commit | 24e3e5ae1e4c2a3a32f5b1f96b4e3fd721806acd (patch) | |
tree | fe7d980253335a2e21a3983be97c79133a9ebbee /drivers/input/tablet | |
parent | 7a0a1dfe9b319528ef8f681d610b8a49797ab475 (diff) |
Input: wacom - fix physical size calculation for 3rd-gen Bamboo
This calculation determines the physical dimensions of the tablet,
used later on in calculate_touch_res to obtain the touch sensor
resolution.
Instead of dividing the logical size by the resolution, the current
code performs a multiplication. This doesn't pose a problem for the
3rd-gen Bamboo since the resolution and scale factor happen to be
identical, but will produce an incorrect result for other cases.
Signed-off-by: Jason Gerecke <killertofu@gmail.com>
Reviewed-by: Chris Bagwell <chris@cnpbagwell.com>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
Diffstat (limited to 'drivers/input/tablet')
-rw-r--r-- | drivers/input/tablet/wacom_sys.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/input/tablet/wacom_sys.c b/drivers/input/tablet/wacom_sys.c index 7e63183a6c68..b59058998417 100644 --- a/drivers/input/tablet/wacom_sys.c +++ b/drivers/input/tablet/wacom_sys.c | |||
@@ -184,9 +184,9 @@ static int wacom_parse_logical_collection(unsigned char *report, | |||
184 | * data before its overwritten. | 184 | * data before its overwritten. |
185 | */ | 185 | */ |
186 | features->x_phy = | 186 | features->x_phy = |
187 | (features->x_max * features->x_resolution) / 100; | 187 | (features->x_max * 100) / features->x_resolution; |
188 | features->y_phy = | 188 | features->y_phy = |
189 | (features->y_max * features->y_resolution) / 100; | 189 | (features->y_max * 100) / features->y_resolution; |
190 | 190 | ||
191 | features->x_max = features->y_max = | 191 | features->x_max = features->y_max = |
192 | get_unaligned_le16(&report[10]); | 192 | get_unaligned_le16(&report[10]); |