Merge branch 'sh/stable-updates' into sh-latest

1 files changed, 10 insertions, 7 deletions

diff --git a/drivers/input/tablet/wacom_sys.c b/drivers/input/tablet/wacom_sys.c
index 449c0a46dbac..d27c9d91630b 100644
--- a/drivers/input/tablet/wacom_sys.c
+++ b/drivers/input/tablet/wacom_sys.c
@@ -49,6 +49,7 @@ struct hid_descriptor {
 #define USB_REQ_GET_REPORT      0x01
 #define USB_REQ_SET_REPORT      0x09
 #define WAC_HID_FEATURE_REPORT  0x03
+#define WAC_MSG_RETRIES         5
 
 static int usb_get_report(struct usb_interface *intf, unsigned char type,
                                 unsigned char id, void *buf, int size)
@@ -165,7 +166,7 @@ static int wacom_parse_hid(struct usb_interface *intf, struct hid_descriptor *hi
                         report,
                         hid_desc->wDescriptorLength,
                         5000); /* 5 secs */
-        } while (result < 0 && limit++ < 5);
+        } while (result < 0 && limit++ < WAC_MSG_RETRIES);
 
         /* No need to parse the Descriptor. It isn't an error though */
         if (result < 0)
@@ -319,24 +320,26 @@ static int wacom_query_tablet_data(struct usb_interface *intf, struct wacom_feat
         int limit = 0, report_id = 2;
         int error = -ENOMEM;
 
-        rep_data = kmalloc(2, GFP_KERNEL);
+        rep_data = kmalloc(4, GFP_KERNEL);
         if (!rep_data)
                 return error;
 
-        /* ask to report tablet data if it is 2FGT Tablet PC or
+        /* ask to report tablet data if it is MT Tablet PC or
          * not a Tablet PC */
         if (features->type == TABLETPC2FG) {
                 do {
                         rep_data[0] = 3;
                         rep_data[1] = 4;
+                        rep_data[2] = 0;
+                        rep_data[3] = 0;
                         report_id = 3;
                         error = usb_set_report(intf, WAC_HID_FEATURE_REPORT,
-                                report_id, rep_data, 2);
+                                report_id, rep_data, 4);
                         if (error >= 0)
                                 error = usb_get_report(intf,
                                         WAC_HID_FEATURE_REPORT, report_id,
-                                        rep_data, 3);
-                } while ((error < 0 || rep_data[1] != 4) && limit++ < 5);
+                                        rep_data, 4);
+                } while ((error < 0 || rep_data[1] != 4) && limit++ < WAC_MSG_RETRIES);
         } else if (features->type != TABLETPC) {
                 do {
                         rep_data[0] = 2;
@@ -347,7 +350,7 @@ static int wacom_query_tablet_data(struct usb_interface *intf, struct wacom_feat
                                 error = usb_get_report(intf,
                                         WAC_HID_FEATURE_REPORT, report_id,
                                         rep_data, 2);
-                } while ((error < 0 || rep_data[1] != 2) && limit++ < 5);
+                } while ((error < 0 || rep_data[1] != 2) && limit++ < WAC_MSG_RETRIES);
         }
 
         kfree(rep_data);