aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/input/tablet/aiptek.c
diff options
context:
space:
mode:
authorDmitry Torokhov <dtor@insightbb.com>2007-05-21 00:18:08 -0400
committerDmitry Torokhov <dtor@insightbb.com>2007-07-10 00:35:16 -0400
commit37767b66ed61ee37f0d8f40523f74c31bc187d1d (patch)
tree1a9363d2640e233d10a0447bc9a6305952fb00c6 /drivers/input/tablet/aiptek.c
parentcd438a58c89221d8642455d0cc8ec96d3b822f6e (diff)
Input: aiptek - kill aiptek_convert_from_2s_complement()
There is no reason to do that, just tell the compiler that we are dealing with signed values in buffer, that's it. Signed-off-by: Rene van Paassen <rene.vanpaassen@gmail.com> Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
Diffstat (limited to 'drivers/input/tablet/aiptek.c')
-rw-r--r--drivers/input/tablet/aiptek.c24
1 files changed, 2 insertions, 22 deletions
diff --git a/drivers/input/tablet/aiptek.c b/drivers/input/tablet/aiptek.c
index 0c990e61ed73..3a5e0aafa115 100644
--- a/drivers/input/tablet/aiptek.c
+++ b/drivers/input/tablet/aiptek.c
@@ -377,26 +377,6 @@ static const char *map_val_to_str(const struct aiptek_map *map, int val)
377} 377}
378 378
379/*********************************************************************** 379/***********************************************************************
380 * Relative reports deliver values in 2's complement format to
381 * deal with negative offsets.
382 */
383static int aiptek_convert_from_2s_complement(unsigned char c)
384{
385 int ret;
386 unsigned char b = c;
387 int negate = 0;
388
389 if ((b & 0x80) != 0) {
390 b = ~b;
391 b--;
392 negate = 1;
393 }
394 ret = b;
395 ret = (negate == 1) ? -ret : ret;
396 return ret;
397}
398
399/***********************************************************************
400 * aiptek_irq can receive one of six potential reports. 380 * aiptek_irq can receive one of six potential reports.
401 * The documentation for each is in the body of the function. 381 * The documentation for each is in the body of the function.
402 * 382 *
@@ -473,8 +453,8 @@ static void aiptek_irq(struct urb *urb)
473 aiptek->diagnostic = 453 aiptek->diagnostic =
474 AIPTEK_DIAGNOSTIC_SENDING_RELATIVE_IN_ABSOLUTE; 454 AIPTEK_DIAGNOSTIC_SENDING_RELATIVE_IN_ABSOLUTE;
475 } else { 455 } else {
476 x = aiptek_convert_from_2s_complement(data[2]); 456 x = (signed char) data[2];
477 y = aiptek_convert_from_2s_complement(data[3]); 457 y = (signed char) data[3];
478 458
479 /* jitterable keeps track of whether any button has been pressed. 459 /* jitterable keeps track of whether any button has been pressed.
480 * We're also using it to remap the physical mouse button mask 460 * We're also using it to remap the physical mouse button mask