aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/input/serio/hp_sdc.c
diff options
context:
space:
mode:
authorHelge Deller <deller@gmx.de>2007-02-28 23:51:19 -0500
committerDmitry Torokhov <dtor@insightbb.com>2007-02-28 23:51:19 -0500
commit3acaf540a33199141695f2e2fcfa8829053159bf (patch)
tree8cc083df919078ec15665cfc34bc977f6996e939 /drivers/input/serio/hp_sdc.c
parent969111e900226a8dbd1f596f34c09eecd20afc7d (diff)
Input: HIL - various fixes for HIL drivers
- mark some structures const or __read_mostly - hilkbd.c: fix uninitialized spinlock in HIL keyboard driver - hil_mlc.c: use USEC_PER_SEC instead of 1000000 - hp_sdc: bugfix for request_irq()/free_irq() parameters, this prevented multiple load/unload cycles as module Signed-off-by: Helge Deller <deller@gmx.de> Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
Diffstat (limited to 'drivers/input/serio/hp_sdc.c')
-rw-r--r--drivers/input/serio/hp_sdc.c16
1 files changed, 8 insertions, 8 deletions
diff --git a/drivers/input/serio/hp_sdc.c b/drivers/input/serio/hp_sdc.c
index b57370dc4e3d..353a8a18948b 100644
--- a/drivers/input/serio/hp_sdc.c
+++ b/drivers/input/serio/hp_sdc.c
@@ -748,7 +748,7 @@ void hp_sdc_kicker (unsigned long data) {
748 748
749#if defined(__hppa__) 749#if defined(__hppa__)
750 750
751static struct parisc_device_id hp_sdc_tbl[] = { 751static const struct parisc_device_id hp_sdc_tbl[] = {
752 { 752 {
753 .hw_type = HPHW_FIO, 753 .hw_type = HPHW_FIO,
754 .hversion_rev = HVERSION_REV_ANY_ID, 754 .hversion_rev = HVERSION_REV_ANY_ID,
@@ -817,12 +817,12 @@ static int __init hp_sdc_init(void)
817#endif 817#endif
818 818
819 errstr = "IRQ not available for"; 819 errstr = "IRQ not available for";
820 if(request_irq(hp_sdc.irq, &hp_sdc_isr, 0, "HP SDC", 820 if (request_irq(hp_sdc.irq, &hp_sdc_isr, IRQF_SHARED|IRQF_SAMPLE_RANDOM,
821 (void *) hp_sdc.base_io)) goto err1; 821 "HP SDC", &hp_sdc)) goto err1;
822 822
823 errstr = "NMI not available for"; 823 errstr = "NMI not available for";
824 if (request_irq(hp_sdc.nmi, &hp_sdc_nmisr, 0, "HP SDC NMI", 824 if (request_irq(hp_sdc.nmi, &hp_sdc_nmisr, IRQF_SHARED,
825 (void *) hp_sdc.base_io)) goto err2; 825 "HP SDC NMI", &hp_sdc)) goto err2;
826 826
827 printk(KERN_INFO PREFIX "HP SDC at 0x%p, IRQ %d (NMI IRQ %d)\n", 827 printk(KERN_INFO PREFIX "HP SDC at 0x%p, IRQ %d (NMI IRQ %d)\n",
828 (void *)hp_sdc.base_io, hp_sdc.irq, hp_sdc.nmi); 828 (void *)hp_sdc.base_io, hp_sdc.irq, hp_sdc.nmi);
@@ -854,7 +854,7 @@ static int __init hp_sdc_init(void)
854 hp_sdc.dev_err = 0; 854 hp_sdc.dev_err = 0;
855 return 0; 855 return 0;
856 err2: 856 err2:
857 free_irq(hp_sdc.irq, NULL); 857 free_irq(hp_sdc.irq, &hp_sdc);
858 err1: 858 err1:
859 release_region(hp_sdc.data_io, 2); 859 release_region(hp_sdc.data_io, 2);
860 err0: 860 err0:
@@ -898,8 +898,8 @@ static void hp_sdc_exit(void)
898 /* Wait until we know this has been processed by the i8042 */ 898 /* Wait until we know this has been processed by the i8042 */
899 hp_sdc_spin_ibf(); 899 hp_sdc_spin_ibf();
900 900
901 free_irq(hp_sdc.nmi, NULL); 901 free_irq(hp_sdc.nmi, &hp_sdc);
902 free_irq(hp_sdc.irq, NULL); 902 free_irq(hp_sdc.irq, &hp_sdc);
903 write_unlock_irq(&hp_sdc.lock); 903 write_unlock_irq(&hp_sdc.lock);
904 904
905 del_timer(&hp_sdc.kicker); 905 del_timer(&hp_sdc.kicker);