aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/input/mouse
diff options
context:
space:
mode:
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>2012-05-01 20:56:47 -0400
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2012-05-01 20:56:47 -0400
commit140b1230a19b65489317271da36465e42865f2e4 (patch)
treeacbc95c74b6558bce80ddc61cc3212c0ee8d1692 /drivers/input/mouse
parent80f8594f63dd35179235aa22901dfa5ce786fe00 (diff)
USB: input: bcm5974.c: fix up dev_err() usage
We should always reference the input device for dev_err(), not the USB device. Fix up the places where I got this wrong. Reported-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> CC: Henrik Rydberg <rydberg@euromail.se> CC: Alessandro Rubini <rubini@ipvvis.unipv.it> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/input/mouse')
-rw-r--r--drivers/input/mouse/bcm5974.c10
1 files changed, 5 insertions, 5 deletions
diff --git a/drivers/input/mouse/bcm5974.c b/drivers/input/mouse/bcm5974.c
index 8cd7c932c202..e2e8d815da76 100644
--- a/drivers/input/mouse/bcm5974.c
+++ b/drivers/input/mouse/bcm5974.c
@@ -584,7 +584,7 @@ static int bcm5974_wellspring_mode(struct bcm5974 *dev, bool on)
584 int retval = 0, size; 584 int retval = 0, size;
585 585
586 if (!data) { 586 if (!data) {
587 dev_err(&dev->intf->dev, "out of memory\n"); 587 dev_err(&dev->input->dev, "out of memory\n");
588 retval = -ENOMEM; 588 retval = -ENOMEM;
589 goto out; 589 goto out;
590 } 590 }
@@ -597,7 +597,7 @@ static int bcm5974_wellspring_mode(struct bcm5974 *dev, bool on)
597 BCM5974_WELLSPRING_MODE_REQUEST_INDEX, data, 8, 5000); 597 BCM5974_WELLSPRING_MODE_REQUEST_INDEX, data, 8, 5000);
598 598
599 if (size != 8) { 599 if (size != 8) {
600 dev_err(&dev->intf->dev, "could not read from device\n"); 600 dev_err(&dev->input->dev, "could not read from device\n");
601 retval = -EIO; 601 retval = -EIO;
602 goto out; 602 goto out;
603 } 603 }
@@ -615,7 +615,7 @@ static int bcm5974_wellspring_mode(struct bcm5974 *dev, bool on)
615 BCM5974_WELLSPRING_MODE_REQUEST_INDEX, data, 8, 5000); 615 BCM5974_WELLSPRING_MODE_REQUEST_INDEX, data, 8, 5000);
616 616
617 if (size != 8) { 617 if (size != 8) {
618 dev_err(&dev->intf->dev, "could not write to device\n"); 618 dev_err(&dev->input->dev, "could not write to device\n");
619 retval = -EIO; 619 retval = -EIO;
620 goto out; 620 goto out;
621 } 621 }
@@ -654,7 +654,7 @@ static void bcm5974_irq_button(struct urb *urb)
654exit: 654exit:
655 error = usb_submit_urb(dev->bt_urb, GFP_ATOMIC); 655 error = usb_submit_urb(dev->bt_urb, GFP_ATOMIC);
656 if (error) 656 if (error)
657 dev_err(&dev->intf->dev, "button urb failed: %d\n", error); 657 dev_err(&dev->input->dev, "button urb failed: %d\n", error);
658} 658}
659 659
660static void bcm5974_irq_trackpad(struct urb *urb) 660static void bcm5974_irq_trackpad(struct urb *urb)
@@ -687,7 +687,7 @@ static void bcm5974_irq_trackpad(struct urb *urb)
687exit: 687exit:
688 error = usb_submit_urb(dev->tp_urb, GFP_ATOMIC); 688 error = usb_submit_urb(dev->tp_urb, GFP_ATOMIC);
689 if (error) 689 if (error)
690 dev_err(&dev->intf->dev, "trackpad urb failed: %d\n", error); 690 dev_err(&dev->input->dev, "trackpad urb failed: %d\n", error);
691} 691}
692 692
693/* 693/*