diff options
author | Dmitry Torokhov <dmitry.torokhov@gmail.com> | 2010-05-11 02:06:52 -0400 |
---|---|---|
committer | Dmitry Torokhov <dmitry.torokhov@gmail.com> | 2010-05-19 13:15:29 -0400 |
commit | 83ba9ea8a04b72dfee2515428c15e7414ba4fc61 (patch) | |
tree | 01e8dbcbdb3062054cf2bfa788add25de73d99ac /drivers/input/mouse/synaptics.c | |
parent | a083632eaf6231162b33e40561cfec6a9c156945 (diff) |
Input: synaptics - set dimensions as reported by firmware
Newer Synaptics firmware allows to query maximim dimensions reported by
device, let's use this data.
Tested-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
Diffstat (limited to 'drivers/input/mouse/synaptics.c')
-rw-r--r-- | drivers/input/mouse/synaptics.c | 32 |
1 files changed, 23 insertions, 9 deletions
diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c index ebd7a99efeae..52bb1de32e4e 100644 --- a/drivers/input/mouse/synaptics.c +++ b/drivers/input/mouse/synaptics.c | |||
@@ -36,6 +36,8 @@ | |||
36 | * The x/y limits are taken from the Synaptics TouchPad interfacing Guide, | 36 | * The x/y limits are taken from the Synaptics TouchPad interfacing Guide, |
37 | * section 2.3.2, which says that they should be valid regardless of the | 37 | * section 2.3.2, which says that they should be valid regardless of the |
38 | * actual size of the sensor. | 38 | * actual size of the sensor. |
39 | * Note that newer firmware allows querying device for maximum useable | ||
40 | * coordinates. | ||
39 | */ | 41 | */ |
40 | #define XMIN_NOMINAL 1472 | 42 | #define XMIN_NOMINAL 1472 |
41 | #define XMAX_NOMINAL 5472 | 43 | #define XMAX_NOMINAL 5472 |
@@ -194,23 +196,33 @@ static int synaptics_identify(struct psmouse *psmouse) | |||
194 | } | 196 | } |
195 | 197 | ||
196 | /* | 198 | /* |
197 | * Read touchpad resolution | 199 | * Read touchpad resolution and maximum reported coordinates |
198 | * Resolution is left zero if touchpad does not support the query | 200 | * Resolution is left zero if touchpad does not support the query |
199 | */ | 201 | */ |
200 | static int synaptics_resolution(struct psmouse *psmouse) | 202 | static int synaptics_resolution(struct psmouse *psmouse) |
201 | { | 203 | { |
202 | struct synaptics_data *priv = psmouse->private; | 204 | struct synaptics_data *priv = psmouse->private; |
203 | unsigned char res[3]; | 205 | unsigned char res[3]; |
206 | unsigned char max[3]; | ||
204 | 207 | ||
205 | if (SYN_ID_MAJOR(priv->identity) < 4) | 208 | if (SYN_ID_MAJOR(priv->identity) < 4) |
206 | return 0; | ||
207 | 209 | ||
208 | if (synaptics_send_cmd(psmouse, SYN_QUE_RESOLUTION, res)) | 210 | if (synaptics_send_cmd(psmouse, SYN_QUE_RESOLUTION, res) == 0) { |
209 | return 0; | 211 | if (res[0] != 0 && (res[1] & 0x80) && res[2] != 0) { |
212 | priv->x_res = res[0]; /* x resolution in units/mm */ | ||
213 | priv->y_res = res[2]; /* y resolution in units/mm */ | ||
214 | } | ||
215 | } | ||
210 | 216 | ||
211 | if ((res[0] != 0) && (res[1] & 0x80) && (res[2] != 0)) { | 217 | if (SYN_EXT_CAP_REQUESTS(priv->capabilities) >= 5 && |
212 | priv->x_res = res[0]; /* x resolution in units/mm */ | 218 | SYN_CAP_MAX_DIMENSIONS(priv->ext_cap_0c)) { |
213 | priv->y_res = res[2]; /* y resolution in units/mm */ | 219 | if (synaptics_send_cmd(psmouse, SYN_QUE_EXT_DIMENSIONS, max)) { |
220 | printk(KERN_ERR "Synaptics claims to have dimensions query," | ||
221 | " but I'm not able to read it.\n"); | ||
222 | } else { | ||
223 | priv->x_max = (max[0] << 5) | ((max[1] & 0x0f) << 1); | ||
224 | priv->y_max = (max[2] << 5) | ((max[1] & 0xf0) >> 3); | ||
225 | } | ||
214 | } | 226 | } |
215 | 227 | ||
216 | return 0; | 228 | return 0; |
@@ -578,8 +590,10 @@ static void set_input_params(struct input_dev *dev, struct synaptics_data *priv) | |||
578 | int i; | 590 | int i; |
579 | 591 | ||
580 | __set_bit(EV_ABS, dev->evbit); | 592 | __set_bit(EV_ABS, dev->evbit); |
581 | input_set_abs_params(dev, ABS_X, XMIN_NOMINAL, XMAX_NOMINAL, 0, 0); | 593 | input_set_abs_params(dev, ABS_X, |
582 | input_set_abs_params(dev, ABS_Y, YMIN_NOMINAL, YMAX_NOMINAL, 0, 0); | 594 | XMIN_NOMINAL, priv->x_max ?: XMAX_NOMINAL, 0, 0); |
595 | input_set_abs_params(dev, ABS_Y, | ||
596 | YMIN_NOMINAL, priv->y_max ?: YMAX_NOMINAL, 0, 0); | ||
583 | input_set_abs_params(dev, ABS_PRESSURE, 0, 255, 0, 0); | 597 | input_set_abs_params(dev, ABS_PRESSURE, 0, 255, 0, 0); |
584 | __set_bit(ABS_TOOL_WIDTH, dev->absbit); | 598 | __set_bit(ABS_TOOL_WIDTH, dev->absbit); |
585 | 599 | ||