diff options
author | Greg Kroah-Hartman <gregkh@suse.de> | 2008-08-14 12:37:34 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2008-10-17 17:41:08 -0400 |
commit | 1817b1692a2eab022e805d32e910f4556c89dce8 (patch) | |
tree | e3014e48b4bbbbbd7b0630911ea9a8ee92a2b689 /drivers/input/misc | |
parent | 15d5a9acb1df1e22a7ba60aaaad758d9d71e5ea7 (diff) |
USB: remove warn() macro from usb input drivers
USB should not be having it's own printk macros, so remove warn() and
use the system-wide standard of dev_warn() wherever possible. In the
few places that will not work out, use a basic printk().
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/input/misc')
-rw-r--r-- | drivers/input/misc/ati_remote.c | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/drivers/input/misc/ati_remote.c b/drivers/input/misc/ati_remote.c index debfc1af9d95..428ecd3294a3 100644 --- a/drivers/input/misc/ati_remote.c +++ b/drivers/input/misc/ati_remote.c | |||
@@ -285,7 +285,6 @@ static const struct { | |||
285 | }; | 285 | }; |
286 | 286 | ||
287 | /* Local function prototypes */ | 287 | /* Local function prototypes */ |
288 | static void ati_remote_dump (unsigned char *data, unsigned int actual_length); | ||
289 | static int ati_remote_open (struct input_dev *inputdev); | 288 | static int ati_remote_open (struct input_dev *inputdev); |
290 | static void ati_remote_close (struct input_dev *inputdev); | 289 | static void ati_remote_close (struct input_dev *inputdev); |
291 | static int ati_remote_sendpacket (struct ati_remote *ati_remote, u16 cmd, unsigned char *data); | 290 | static int ati_remote_sendpacket (struct ati_remote *ati_remote, u16 cmd, unsigned char *data); |
@@ -307,15 +306,16 @@ static struct usb_driver ati_remote_driver = { | |||
307 | /* | 306 | /* |
308 | * ati_remote_dump_input | 307 | * ati_remote_dump_input |
309 | */ | 308 | */ |
310 | static void ati_remote_dump(unsigned char *data, unsigned int len) | 309 | static void ati_remote_dump(struct device *dev, unsigned char *data, |
310 | unsigned int len) | ||
311 | { | 311 | { |
312 | if ((len == 1) && (data[0] != (unsigned char)0xff) && (data[0] != 0x00)) | 312 | if ((len == 1) && (data[0] != (unsigned char)0xff) && (data[0] != 0x00)) |
313 | warn("Weird byte 0x%02x", data[0]); | 313 | dev_warn(dev, "Weird byte 0x%02x\n", data[0]); |
314 | else if (len == 4) | 314 | else if (len == 4) |
315 | warn("Weird key %02x %02x %02x %02x", | 315 | dev_warn(dev, "Weird key %02x %02x %02x %02x\n", |
316 | data[0], data[1], data[2], data[3]); | 316 | data[0], data[1], data[2], data[3]); |
317 | else | 317 | else |
318 | warn("Weird data, len=%d %02x %02x %02x %02x %02x %02x ...", | 318 | dev_warn(dev, "Weird data, len=%d %02x %02x %02x %02x %02x %02x ...\n", |
319 | len, data[0], data[1], data[2], data[3], data[4], data[5]); | 319 | len, data[0], data[1], data[2], data[3], data[4], data[5]); |
320 | } | 320 | } |
321 | 321 | ||
@@ -470,7 +470,7 @@ static void ati_remote_input_report(struct urb *urb) | |||
470 | /* Deal with strange looking inputs */ | 470 | /* Deal with strange looking inputs */ |
471 | if ( (urb->actual_length != 4) || (data[0] != 0x14) || | 471 | if ( (urb->actual_length != 4) || (data[0] != 0x14) || |
472 | ((data[3] & 0x0f) != 0x00) ) { | 472 | ((data[3] & 0x0f) != 0x00) ) { |
473 | ati_remote_dump(data, urb->actual_length); | 473 | ati_remote_dump(&urb->dev->dev, data, urb->actual_length); |
474 | return; | 474 | return; |
475 | } | 475 | } |
476 | 476 | ||
@@ -814,7 +814,7 @@ static void ati_remote_disconnect(struct usb_interface *interface) | |||
814 | ati_remote = usb_get_intfdata(interface); | 814 | ati_remote = usb_get_intfdata(interface); |
815 | usb_set_intfdata(interface, NULL); | 815 | usb_set_intfdata(interface, NULL); |
816 | if (!ati_remote) { | 816 | if (!ati_remote) { |
817 | warn("%s - null device?\n", __func__); | 817 | dev_warn(&interface->dev, "%s - null device?\n", __func__); |
818 | return; | 818 | return; |
819 | } | 819 | } |
820 | 820 | ||