Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input

* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input: (51 commits)
  Input: appletouch - give up maintainership
  Input: dm355evm_kbd - switch to using sparse keymap library
  Input: wistron_btns - switch to using sparse keymap library
  Input: add generic support for sparse keymaps
  Input: fix memory leak in force feedback core
  Input: wistron - remove identification strings from DMI table
  Input: psmouse - remove identification strings from DMI tables
  Input: atkbd - remove identification strings from DMI table
  Input: i8042 - remove identification strings from DMI tables
  DMI: allow omitting ident strings in DMI tables
  Input: psmouse - do not carry DMI data around
  Input: matrix-keypad - switch to using dev_pm_ops
  Input: keyboard - fix lack of locking when traversing handler->h_list
  Input: gpio_keys - scan gpio state at probe and resume time
  Input: keyboard - add locking around event handling
  Input: usbtouchscreen - add support for ET&T TC5UH touchscreen controller
  Input: xpad - add two new Xbox 360 devices
  Input: polled device - do not start polling if interval is zero
  Input: polled device - schedule first poll immediately
  Input: add S3C24XX touchscreen driver
  ...

7 files changed, 686 insertions, 335 deletions

diff --git a/drivers/input/keyboard/Kconfig b/drivers/input/keyboard/Kconfig
index ee98b1bc5d89..203b88a82b56 100644
--- a/drivers/input/keyboard/Kconfig
+++ b/drivers/input/keyboard/Kconfig
@@ -361,6 +361,16 @@ config KEYBOARD_SH_KEYSC
           To compile this driver as a module, choose M here: the
           module will be called sh_keysc.
 
+config KEYBOARD_DAVINCI
+        tristate "TI DaVinci Key Scan"
+        depends on ARCH_DAVINCI_DM365
+        help
+          Say Y to enable keypad module support for the TI DaVinci
+          platforms (DM365).
+
+          To compile this driver as a module, choose M here: the
+          module will be called davinci_keyscan.
+
 config KEYBOARD_OMAP
         tristate "TI OMAP keypad support"
         depends on (ARCH_OMAP1 || ARCH_OMAP2)
diff --git a/drivers/input/keyboard/Makefile b/drivers/input/keyboard/Makefile
index babad5e58b77..68c017235ce9 100644
--- a/drivers/input/keyboard/Makefile
+++ b/drivers/input/keyboard/Makefile
@@ -11,6 +11,7 @@ obj-$(CONFIG_KEYBOARD_ATARI)		+= atakbd.o
 obj-$(CONFIG_KEYBOARD_ATKBD)            += atkbd.o
 obj-$(CONFIG_KEYBOARD_BFIN)             += bf54x-keys.o
 obj-$(CONFIG_KEYBOARD_CORGI)            += corgikbd.o
+obj-$(CONFIG_KEYBOARD_DAVINCI)          += davinci_keyscan.o
 obj-$(CONFIG_KEYBOARD_EP93XX)           += ep93xx_keypad.o
 obj-$(CONFIG_KEYBOARD_GPIO)             += gpio_keys.o
 obj-$(CONFIG_KEYBOARD_HIL)              += hil_kbd.o
diff --git a/drivers/input/keyboard/atkbd.c b/drivers/input/keyboard/atkbd.c
index 28e6110d1ff8..a3573570c52f 100644
--- a/drivers/input/keyboard/atkbd.c
+++ b/drivers/input/keyboard/atkbd.c
@@ -1567,9 +1567,8 @@ static int __init atkbd_setup_scancode_fixup(const struct dmi_system_id *id)
         return 0;
 }
 
-static struct dmi_system_id atkbd_dmi_quirk_table[] __initdata = {
+static const struct dmi_system_id atkbd_dmi_quirk_table[] __initconst = {
         {
-                .ident = "Dell Laptop",
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
                         DMI_MATCH(DMI_CHASSIS_TYPE, "8"), /* Portable */
@@ -1578,7 +1577,6 @@ static struct dmi_system_id atkbd_dmi_quirk_table[] __initdata = {
                 .driver_data = atkbd_dell_laptop_forced_release_keys,
         },
         {
-                .ident = "Dell Laptop",
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "Dell Computer Corporation"),
                         DMI_MATCH(DMI_CHASSIS_TYPE, "8"), /* Portable */
@@ -1587,7 +1585,6 @@ static struct dmi_system_id atkbd_dmi_quirk_table[] __initdata = {
                 .driver_data = atkbd_dell_laptop_forced_release_keys,
         },
         {
-                .ident = "HP 2133",
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "HP 2133"),
@@ -1596,7 +1593,6 @@ static struct dmi_system_id atkbd_dmi_quirk_table[] __initdata = {
                 .driver_data = atkbd_hp_forced_release_keys,
         },
         {
-                .ident = "HP Pavilion ZV6100",
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "Pavilion ZV6100"),
@@ -1605,7 +1601,6 @@ static struct dmi_system_id atkbd_dmi_quirk_table[] __initdata = {
                 .driver_data = atkbd_volume_forced_release_keys,
         },
         {
-                .ident = "HP Presario R4000",
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "Presario R4000"),
@@ -1614,7 +1609,6 @@ static struct dmi_system_id atkbd_dmi_quirk_table[] __initdata = {
                 .driver_data = atkbd_volume_forced_release_keys,
         },
         {
-                .ident = "HP Presario R4100",
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "Presario R4100"),
@@ -1623,7 +1617,6 @@ static struct dmi_system_id atkbd_dmi_quirk_table[] __initdata = {
                 .driver_data = atkbd_volume_forced_release_keys,
         },
         {
-                .ident = "HP Presario R4200",
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "Presario R4200"),
@@ -1632,7 +1625,7 @@ static struct dmi_system_id atkbd_dmi_quirk_table[] __initdata = {
                 .driver_data = atkbd_volume_forced_release_keys,
         },
         {
-                .ident = "Inventec Symphony",
+                /* Inventec Symphony */
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "INVENTEC"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "SYMPHONY 6.0/7.0"),
@@ -1641,7 +1634,7 @@ static struct dmi_system_id atkbd_dmi_quirk_table[] __initdata = {
                 .driver_data = atkbd_volume_forced_release_keys,
         },
         {
-                .ident = "Samsung NC10",
+                /* Samsung NC10 */
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "SAMSUNG ELECTRONICS CO., LTD."),
                         DMI_MATCH(DMI_PRODUCT_NAME, "NC10"),
@@ -1650,7 +1643,7 @@ static struct dmi_system_id atkbd_dmi_quirk_table[] __initdata = {
                 .driver_data = atkbd_samsung_forced_release_keys,
         },
         {
-                .ident = "Samsung NC20",
+                /* Samsung NC20 */
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "SAMSUNG ELECTRONICS CO., LTD."),
                         DMI_MATCH(DMI_PRODUCT_NAME, "NC20"),
@@ -1659,7 +1652,7 @@ static struct dmi_system_id atkbd_dmi_quirk_table[] __initdata = {
                 .driver_data = atkbd_samsung_forced_release_keys,
         },
         {
-                .ident = "Samsung SQ45S70S",
+                /* Samsung SQ45S70S */
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "SAMSUNG ELECTRONICS CO., LTD."),
                         DMI_MATCH(DMI_PRODUCT_NAME, "SQ45S70S"),
@@ -1668,7 +1661,7 @@ static struct dmi_system_id atkbd_dmi_quirk_table[] __initdata = {
                 .driver_data = atkbd_samsung_forced_release_keys,
         },
         {
-                .ident = "Fujitsu Amilo PA 1510",
+                /* Fujitsu Amilo PA 1510 */
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU SIEMENS"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "AMILO Pa 1510"),
@@ -1677,7 +1670,7 @@ static struct dmi_system_id atkbd_dmi_quirk_table[] __initdata = {
                 .driver_data = atkbd_volume_forced_release_keys,
         },
         {
-                .ident = "Fujitsu Amilo Pi 3525",
+                /* Fujitsu Amilo Pi 3525 */
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU SIEMENS"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "AMILO Pi 3525"),
@@ -1686,7 +1679,7 @@ static struct dmi_system_id atkbd_dmi_quirk_table[] __initdata = {
                 .driver_data = atkbd_amilo_pi3525_forced_release_keys,
         },
         {
-                .ident = "Fujitsu Amilo Xi 3650",
+                /* Fujitsu Amilo Xi 3650 */
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU SIEMENS"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "AMILO Xi 3650"),
@@ -1695,7 +1688,6 @@ static struct dmi_system_id atkbd_dmi_quirk_table[] __initdata = {
                 .driver_data = atkbd_amilo_xi3650_forced_release_keys,
         },
         {
-                .ident = "Soltech Corporation TA12",
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "Soltech Corporation"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "TA12"),
@@ -1704,7 +1696,7 @@ static struct dmi_system_id atkbd_dmi_quirk_table[] __initdata = {
                 .driver_data = atkdb_soltech_ta12_forced_release_keys,
         },
         {
-                .ident = "OQO Model 01+",
+                /* OQO Model 01+ */
                 .matches = {
                         DMI_MATCH(DMI_SYS_VENDOR, "OQO"),
                         DMI_MATCH(DMI_PRODUCT_NAME, "ZEPTO"),
diff --git a/drivers/input/keyboard/davinci_keyscan.c b/drivers/input/keyboard/davinci_keyscan.c
new file mode 100644
index 000000000000..6e52d855f637
--- /dev/null
+++ b/drivers/input/keyboard/davinci_keyscan.c
@@ -0,0 +1,337 @@
+/*
+ * DaVinci Key Scan Driver for TI platforms
+ *
+ * Copyright (C) 2009 Texas Instruments, Inc
+ *
+ * Author: Miguel Aguilar <miguel.aguilar@ridgerun.com>
+ *
+ * Intial Code: Sandeep Paulraj <s-paulraj@ti.com>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
+ */
+#include <linux/module.h>
+#include <linux/init.h>
+#include <linux/interrupt.h>
+#include <linux/types.h>
+#include <linux/input.h>
+#include <linux/kernel.h>
+#include <linux/delay.h>
+#include <linux/platform_device.h>
+#include <linux/errno.h>
+
+#include <asm/irq.h>
+
+#include <mach/hardware.h>
+#include <mach/irqs.h>
+#include <mach/keyscan.h>
+
+/* Key scan registers */
+#define DAVINCI_KEYSCAN_KEYCTRL         0x0000
+#define DAVINCI_KEYSCAN_INTENA          0x0004
+#define DAVINCI_KEYSCAN_INTFLAG         0x0008
+#define DAVINCI_KEYSCAN_INTCLR          0x000c
+#define DAVINCI_KEYSCAN_STRBWIDTH       0x0010
+#define DAVINCI_KEYSCAN_INTERVAL        0x0014
+#define DAVINCI_KEYSCAN_CONTTIME        0x0018
+#define DAVINCI_KEYSCAN_CURRENTST       0x001c
+#define DAVINCI_KEYSCAN_PREVSTATE       0x0020
+#define DAVINCI_KEYSCAN_EMUCTRL         0x0024
+#define DAVINCI_KEYSCAN_IODFTCTRL       0x002c
+
+/* Key Control Register (KEYCTRL) */
+#define DAVINCI_KEYSCAN_KEYEN           0x00000001
+#define DAVINCI_KEYSCAN_PREVMODE        0x00000002
+#define DAVINCI_KEYSCAN_CHATOFF         0x00000004
+#define DAVINCI_KEYSCAN_AUTODET         0x00000008
+#define DAVINCI_KEYSCAN_SCANMODE        0x00000010
+#define DAVINCI_KEYSCAN_OUTTYPE         0x00000020
+
+/* Masks for the interrupts */
+#define DAVINCI_KEYSCAN_INT_CONT        0x00000008
+#define DAVINCI_KEYSCAN_INT_OFF         0x00000004
+#define DAVINCI_KEYSCAN_INT_ON          0x00000002
+#define DAVINCI_KEYSCAN_INT_CHANGE      0x00000001
+#define DAVINCI_KEYSCAN_INT_ALL         0x0000000f
+
+struct davinci_ks {
+        struct input_dev                *input;
+        struct davinci_ks_platform_data *pdata;
+        int                             irq;
+        void __iomem                    *base;
+        resource_size_t                 pbase;
+        size_t                          base_size;
+        unsigned short                  keymap[];
+};
+
+/* Initializing the kp Module */
+static int __init davinci_ks_initialize(struct davinci_ks *davinci_ks)
+{
+        struct device *dev = &davinci_ks->input->dev;
+        struct davinci_ks_platform_data *pdata = davinci_ks->pdata;
+        u32 matrix_ctrl;
+
+        /* Enable all interrupts */
+        __raw_writel(DAVINCI_KEYSCAN_INT_ALL,
+                     davinci_ks->base + DAVINCI_KEYSCAN_INTENA);
+
+        /* Clear interrupts if any */
+        __raw_writel(DAVINCI_KEYSCAN_INT_ALL,
+                     davinci_ks->base + DAVINCI_KEYSCAN_INTCLR);
+
+        /* Setup the scan period = strobe + interval */
+        __raw_writel(pdata->strobe,
+                     davinci_ks->base + DAVINCI_KEYSCAN_STRBWIDTH);
+        __raw_writel(pdata->interval,
+                     davinci_ks->base + DAVINCI_KEYSCAN_INTERVAL);
+        __raw_writel(0x01,
+                     davinci_ks->base + DAVINCI_KEYSCAN_CONTTIME);
+
+        /* Define matrix type */
+        switch (pdata->matrix_type) {
+        case DAVINCI_KEYSCAN_MATRIX_4X4:
+                matrix_ctrl = 0;
+                break;
+        case DAVINCI_KEYSCAN_MATRIX_5X3:
+                matrix_ctrl = (1 << 6);
+                break;
+        default:
+                dev_err(dev->parent, "wrong matrix type\n");
+                return -EINVAL;
+        }
+
+        /* Enable key scan module and set matrix type */
+        __raw_writel(DAVINCI_KEYSCAN_AUTODET | DAVINCI_KEYSCAN_KEYEN |
+                     matrix_ctrl, davinci_ks->base + DAVINCI_KEYSCAN_KEYCTRL);
+
+        return 0;
+}
+
+static irqreturn_t davinci_ks_interrupt(int irq, void *dev_id)
+{
+        struct davinci_ks *davinci_ks = dev_id;
+        struct device *dev = &davinci_ks->input->dev;
+        unsigned short *keymap = davinci_ks->keymap;
+        int keymapsize = davinci_ks->pdata->keymapsize;
+        u32 prev_status, new_status, changed;
+        bool release;
+        int keycode = KEY_UNKNOWN;
+        int i;
+
+        /* Disable interrupt */
+        __raw_writel(0x0, davinci_ks->base + DAVINCI_KEYSCAN_INTENA);
+
+        /* Reading previous and new status of the key scan */
+        prev_status = __raw_readl(davinci_ks->base + DAVINCI_KEYSCAN_PREVSTATE);
+        new_status = __raw_readl(davinci_ks->base + DAVINCI_KEYSCAN_CURRENTST);
+
+        changed = prev_status ^ new_status;
+
+        if (changed) {
+                /*
+                 * It goes through all bits in 'changed' to ensure
+                 * that no key changes are being missed
+                 */
+                for (i = 0 ; i < keymapsize; i++) {
+                        if ((changed>>i) & 0x1) {
+                                keycode = keymap[i];
+                                release = (new_status >> i) & 0x1;
+                                dev_dbg(dev->parent, "key %d %s\n", keycode,
+                                        release ? "released" : "pressed");
+                                input_report_key(davinci_ks->input, keycode,
+                                                 !release);
+                                input_sync(davinci_ks->input);
+                        }
+                }
+                /* Clearing interrupt */
+                __raw_writel(DAVINCI_KEYSCAN_INT_ALL,
+                             davinci_ks->base + DAVINCI_KEYSCAN_INTCLR);
+        }
+
+        /* Enable interrupts */
+        __raw_writel(0x1, davinci_ks->base + DAVINCI_KEYSCAN_INTENA);
+
+        return IRQ_HANDLED;
+}
+
+static int __init davinci_ks_probe(struct platform_device *pdev)
+{
+        struct davinci_ks *davinci_ks;
+        struct input_dev *key_dev;
+        struct resource *res, *mem;
+        struct device *dev = &pdev->dev;
+        struct davinci_ks_platform_data *pdata = pdev->dev.platform_data;
+        int error, i;
+
+        if (!pdata->keymap) {
+                dev_dbg(dev, "no keymap from pdata\n");
+                return -EINVAL;
+        }
+
+        davinci_ks = kzalloc(sizeof(struct davinci_ks) +
+                sizeof(unsigned short) * pdata->keymapsize, GFP_KERNEL);
+        if (!davinci_ks) {
+                dev_dbg(dev, "could not allocate memory for private data\n");
+                return -ENOMEM;
+        }
+
+        memcpy(davinci_ks->keymap, pdata->keymap,
+                sizeof(unsigned short) * pdata->keymapsize);
+
+        key_dev = input_allocate_device();
+        if (!key_dev) {
+                dev_dbg(dev, "could not allocate input device\n");
+                error = -ENOMEM;
+                goto fail1;
+        }
+
+        davinci_ks->input = key_dev;
+
+        davinci_ks->irq = platform_get_irq(pdev, 0);
+        if (davinci_ks->irq < 0) {
+                dev_err(dev, "no key scan irq\n");
+                error = davinci_ks->irq;
+                goto fail2;
+        }
+
+        res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+        if (!res) {
+                dev_err(dev, "no mem resource\n");
+                error = -EINVAL;
+                goto fail2;
+        }
+
+        davinci_ks->pbase = res->start;
+        davinci_ks->base_size = resource_size(res);
+
+        mem = request_mem_region(davinci_ks->pbase, davinci_ks->base_size,
+                                 pdev->name);
+        if (!mem) {
+                dev_err(dev, "key scan registers at %08x are not free\n",
+                        davinci_ks->pbase);
+                error = -EBUSY;
+                goto fail2;
+        }
+
+        davinci_ks->base = ioremap(davinci_ks->pbase, davinci_ks->base_size);
+        if (!davinci_ks->base) {
+                dev_err(dev, "can't ioremap MEM resource.\n");
+                error = -ENOMEM;
+                goto fail3;
+        }
+
+        /* Enable auto repeat feature of Linux input subsystem */
+        if (pdata->rep)
+                __set_bit(EV_REP, key_dev->evbit);
+
+        /* Setup input device */
+        __set_bit(EV_KEY, key_dev->evbit);
+
+        /* Setup the platform data */
+        davinci_ks->pdata = pdata;
+
+        for (i = 0; i < davinci_ks->pdata->keymapsize; i++)
+                __set_bit(davinci_ks->pdata->keymap[i], key_dev->keybit);
+
+        key_dev->name = "davinci_keyscan";
+        key_dev->phys = "davinci_keyscan/input0";
+        key_dev->dev.parent = &pdev->dev;
+        key_dev->id.bustype = BUS_HOST;
+        key_dev->id.vendor = 0x0001;
+        key_dev->id.product = 0x0001;
+        key_dev->id.version = 0x0001;
+        key_dev->keycode = davinci_ks->keymap;
+        key_dev->keycodesize = sizeof(davinci_ks->keymap[0]);
+        key_dev->keycodemax = davinci_ks->pdata->keymapsize;
+
+        error = input_register_device(davinci_ks->input);
+        if (error < 0) {
+                dev_err(dev, "unable to register davinci key scan device\n");
+                goto fail4;
+        }
+
+        error = request_irq(davinci_ks->irq, davinci_ks_interrupt,
+                          IRQF_DISABLED, pdev->name, davinci_ks);
+        if (error < 0) {
+                dev_err(dev, "unable to register davinci key scan interrupt\n");
+                goto fail5;
+        }
+
+        error = davinci_ks_initialize(davinci_ks);
+        if (error < 0) {
+                dev_err(dev, "unable to initialize davinci key scan device\n");
+                goto fail6;
+        }
+
+        platform_set_drvdata(pdev, davinci_ks);
+        return 0;
+
+fail6:
+        free_irq(davinci_ks->irq, davinci_ks);
+fail5:
+        input_unregister_device(davinci_ks->input);
+        key_dev = NULL;
+fail4:
+        iounmap(davinci_ks->base);
+fail3:
+        release_mem_region(davinci_ks->pbase, davinci_ks->base_size);
+fail2:
+        input_free_device(key_dev);
+fail1:
+        kfree(davinci_ks);
+
+        return error;
+}
+
+static int __devexit davinci_ks_remove(struct platform_device *pdev)
+{
+        struct davinci_ks *davinci_ks = platform_get_drvdata(pdev);
+
+        free_irq(davinci_ks->irq, davinci_ks);
+
+        input_unregister_device(davinci_ks->input);
+
+        iounmap(davinci_ks->base);
+        release_mem_region(davinci_ks->pbase, davinci_ks->base_size);
+
+        platform_set_drvdata(pdev, NULL);
+
+        kfree(davinci_ks);
+
+        return 0;
+}
+
+static struct platform_driver davinci_ks_driver = {
+        .driver = {
+                .name = "davinci_keyscan",
+                .owner = THIS_MODULE,
+        },
+        .remove = __devexit_p(davinci_ks_remove),
+};
+
+static int __init davinci_ks_init(void)
+{
+        return platform_driver_probe(&davinci_ks_driver, davinci_ks_probe);
+}
+module_init(davinci_ks_init);
+
+static void __exit davinci_ks_exit(void)
+{
+        platform_driver_unregister(&davinci_ks_driver);
+}
+module_exit(davinci_ks_exit);
+
+MODULE_AUTHOR("Miguel Aguilar");
+MODULE_DESCRIPTION("Texas Instruments DaVinci Key Scan Driver");
+MODULE_LICENSE("GPL");
diff --git a/drivers/input/keyboard/gpio_keys.c b/drivers/input/keyboard/gpio_keys.c
index 77d130914259..1aff3b76effd 100644
--- a/drivers/input/keyboard/gpio_keys.c
+++ b/drivers/input/keyboard/gpio_keys.c
@@ -23,8 +23,7 @@
 #include <linux/input.h>
 #include <linux/gpio_keys.h>
 #include <linux/workqueue.h>
-
-#include <asm/gpio.h>
+#include <linux/gpio.h>
 
 struct gpio_button_data {
         struct gpio_keys_button *button;
@@ -38,10 +37,8 @@ struct gpio_keys_drvdata {
         struct gpio_button_data data[0];
 };
 
-static void gpio_keys_report_event(struct work_struct *work)
+static void gpio_keys_report_event(struct gpio_button_data *bdata)
 {
-        struct gpio_button_data *bdata =
-                container_of(work, struct gpio_button_data, work);
         struct gpio_keys_button *button = bdata->button;
         struct input_dev *input = bdata->input;
         unsigned int type = button->type ?: EV_KEY;
@@ -51,6 +48,14 @@ static void gpio_keys_report_event(struct work_struct *work)
         input_sync(input);
 }
 
+static void gpio_keys_work_func(struct work_struct *work)
+{
+        struct gpio_button_data *bdata =
+                container_of(work, struct gpio_button_data, work);
+
+        gpio_keys_report_event(bdata);
+}
+
 static void gpio_keys_timer(unsigned long _data)
 {
         struct gpio_button_data *data = (struct gpio_button_data *)_data;
@@ -74,10 +79,62 @@ static irqreturn_t gpio_keys_isr(int irq, void *dev_id)
         return IRQ_HANDLED;
 }
 
+static int __devinit gpio_keys_setup_key(struct device *dev,
+                                         struct gpio_button_data *bdata,
+                                         struct gpio_keys_button *button)
+{
+        char *desc = button->desc ? button->desc : "gpio_keys";
+        int irq, error;
+
+        setup_timer(&bdata->timer, gpio_keys_timer, (unsigned long)bdata);
+        INIT_WORK(&bdata->work, gpio_keys_work_func);
+
+        error = gpio_request(button->gpio, desc);
+        if (error < 0) {
+                dev_err(dev, "failed to request GPIO %d, error %d\n",
+                        button->gpio, error);
+                goto fail2;
+        }
+
+        error = gpio_direction_input(button->gpio);
+        if (error < 0) {
+                dev_err(dev, "failed to configure"
+                        " direction for GPIO %d, error %d\n",
+                        button->gpio, error);
+                goto fail3;
+        }
+
+        irq = gpio_to_irq(button->gpio);
+        if (irq < 0) {
+                error = irq;
+                dev_err(dev, "Unable to get irq number for GPIO %d, error %d\n",
+                        button->gpio, error);
+                goto fail3;
+        }
+
+        error = request_irq(irq, gpio_keys_isr,
+                            IRQF_SHARED |
+                            IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING,
+                            desc, bdata);
+        if (error) {
+                dev_err(dev, "Unable to claim irq %d; error %d\n",
+                        irq, error);
+                goto fail3;
+        }
+
+        return 0;
+
+fail3:
+        gpio_free(button->gpio);
+fail2:
+        return error;
+}
+
 static int __devinit gpio_keys_probe(struct platform_device *pdev)
 {
         struct gpio_keys_platform_data *pdata = pdev->dev.platform_data;
         struct gpio_keys_drvdata *ddata;
+        struct device *dev = &pdev->dev;
         struct input_dev *input;
         int i, error;
         int wakeup = 0;
@@ -87,6 +144,7 @@ static int __devinit gpio_keys_probe(struct platform_device *pdev)
                         GFP_KERNEL);
         input = input_allocate_device();
         if (!ddata || !input) {
+                dev_err(dev, "failed to allocate state\n");
                 error = -ENOMEM;
                 goto fail1;
         }
@@ -111,52 +169,14 @@ static int __devinit gpio_keys_probe(struct platform_device *pdev)
         for (i = 0; i < pdata->nbuttons; i++) {
                 struct gpio_keys_button *button = &pdata->buttons[i];
                 struct gpio_button_data *bdata = &ddata->data[i];
-                int irq;
                 unsigned int type = button->type ?: EV_KEY;
 
                 bdata->input = input;
                 bdata->button = button;
-                setup_timer(&bdata->timer,
-                            gpio_keys_timer, (unsigned long)bdata);
-                INIT_WORK(&bdata->work, gpio_keys_report_event);
-
-                error = gpio_request(button->gpio, button->desc ?: "gpio_keys");
-                if (error < 0) {
-                        pr_err("gpio-keys: failed to request GPIO %d,"
-                                " error %d\n", button->gpio, error);
-                        goto fail2;
-                }
-
-                error = gpio_direction_input(button->gpio);
-                if (error < 0) {
-                        pr_err("gpio-keys: failed to configure input"
-                                " direction for GPIO %d, error %d\n",
-                                button->gpio, error);
-                        gpio_free(button->gpio);
-                        goto fail2;
-                }
-
-                irq = gpio_to_irq(button->gpio);
-                if (irq < 0) {
-                        error = irq;
-                        pr_err("gpio-keys: Unable to get irq number"
-                                " for GPIO %d, error %d\n",
-                                button->gpio, error);
-                        gpio_free(button->gpio);
-                        goto fail2;
-                }
 
-                error = request_irq(irq, gpio_keys_isr,
-                                    IRQF_SHARED |
-                                    IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING,
-                                    button->desc ? button->desc : "gpio_keys",
-                                    bdata);
-                if (error) {
-                        pr_err("gpio-keys: Unable to claim irq %d; error %d\n",
-                                irq, error);
-                        gpio_free(button->gpio);
+                error = gpio_keys_setup_key(dev, bdata, button);
+                if (error)
                         goto fail2;
-                }
 
                 if (button->wakeup)
                         wakeup = 1;
@@ -166,11 +186,16 @@ static int __devinit gpio_keys_probe(struct platform_device *pdev)
 
         error = input_register_device(input);
         if (error) {
-                pr_err("gpio-keys: Unable to register input device, "
+                dev_err(dev, "Unable to register input device, "
                         "error: %d\n", error);
                 goto fail2;
         }
 
+        /* get current state of buttons */
+        for (i = 0; i < pdata->nbuttons; i++)
+                gpio_keys_report_event(&ddata->data[i]);
+        input_sync(input);
+
         device_init_wakeup(&pdev->dev, wakeup);
 
         return 0;
@@ -239,18 +264,21 @@ static int gpio_keys_suspend(struct device *dev)
 static int gpio_keys_resume(struct device *dev)
 {
         struct platform_device *pdev = to_platform_device(dev);
+        struct gpio_keys_drvdata *ddata = platform_get_drvdata(pdev);
         struct gpio_keys_platform_data *pdata = pdev->dev.platform_data;
         int i;
 
-        if (device_may_wakeup(&pdev->dev)) {
-                for (i = 0; i < pdata->nbuttons; i++) {
-                        struct gpio_keys_button *button = &pdata->buttons[i];
-                        if (button->wakeup) {
-                                int irq = gpio_to_irq(button->gpio);
-                                disable_irq_wake(irq);
-                        }
+        for (i = 0; i < pdata->nbuttons; i++) {
+
+                struct gpio_keys_button *button = &pdata->buttons[i];
+                if (button->wakeup && device_may_wakeup(&pdev->dev)) {
+                        int irq = gpio_to_irq(button->gpio);
+                        disable_irq_wake(irq);
                 }
+
+                gpio_keys_report_event(&ddata->data[i]);
         }
+        input_sync(ddata->input);
 
         return 0;
 }
diff --git a/drivers/input/keyboard/lkkbd.c b/drivers/input/keyboard/lkkbd.c
index f9847e0fb553..fa9bb6d235e2 100644
--- a/drivers/input/keyboard/lkkbd.c
+++ b/drivers/input/keyboard/lkkbd.c
@@ -72,9 +72,9 @@
 
 #define DRIVER_DESC     "LK keyboard driver"
 
-MODULE_AUTHOR ("Jan-Benedict Glaw <jbglaw@lug-owl.de>");
-MODULE_DESCRIPTION (DRIVER_DESC);
-MODULE_LICENSE ("GPL");
+MODULE_AUTHOR("Jan-Benedict Glaw <jbglaw@lug-owl.de>");
+MODULE_DESCRIPTION(DRIVER_DESC);
+MODULE_LICENSE("GPL");
 
 /*
  * Known parameters:
@@ -85,27 +85,27 @@ MODULE_LICENSE ("GPL");
  * Please notice that there's not yet an API to set these at runtime.
  */
 static int bell_volume = 100; /* % */
-module_param (bell_volume, int, 0);
-MODULE_PARM_DESC (bell_volume, "Bell volume (in %). default is 100%");
+module_param(bell_volume, int, 0);
+MODULE_PARM_DESC(bell_volume, "Bell volume (in %). default is 100%");
 
 static int keyclick_volume = 100; /* % */
-module_param (keyclick_volume, int, 0);
-MODULE_PARM_DESC (keyclick_volume, "Keyclick volume (in %), default is 100%");
+module_param(keyclick_volume, int, 0);
+MODULE_PARM_DESC(keyclick_volume, "Keyclick volume (in %), default is 100%");
 
 static int ctrlclick_volume = 100; /* % */
-module_param (ctrlclick_volume, int, 0);
-MODULE_PARM_DESC (ctrlclick_volume, "Ctrlclick volume (in %), default is 100%");
+module_param(ctrlclick_volume, int, 0);
+MODULE_PARM_DESC(ctrlclick_volume, "Ctrlclick volume (in %), default is 100%");
 
 static int lk201_compose_is_alt;
-module_param (lk201_compose_is_alt, int, 0);
-MODULE_PARM_DESC (lk201_compose_is_alt, "If set non-zero, LK201' Compose key "
-                "will act as an Alt key");
+module_param(lk201_compose_is_alt, int, 0);
+MODULE_PARM_DESC(lk201_compose_is_alt,
+                 "If set non-zero, LK201' Compose key will act as an Alt key");
 
 
 
 #undef LKKBD_DEBUG
 #ifdef LKKBD_DEBUG
-#define DBG(x...) printk (x)
+#define DBG(x...) printk(x)
 #else
 #define DBG(x...) do {} while (0)
 #endif
@@ -122,7 +122,7 @@ MODULE_PARM_DESC (lk201_compose_is_alt, "If set non-zero, LK201' Compose key "
 #define LK_MODE_DOWN            0x80
 #define LK_MODE_AUTODOWN        0x82
 #define LK_MODE_UPDOWN          0x86
-#define LK_CMD_SET_MODE(mode,div)       ((mode) | ((div) << 3))
+#define LK_CMD_SET_MODE(mode, div)      ((mode) | ((div) << 3))
 
 /* Misc commands */
 #define LK_CMD_ENABLE_KEYCLICK  0x1b
@@ -152,11 +152,8 @@ MODULE_PARM_DESC (lk201_compose_is_alt, "If set non-zero, LK201' Compose key "
 
 #define LK_NUM_KEYCODES         256
 #define LK_NUM_IGNORE_BYTES     6
-typedef u_int16_t lk_keycode_t;
 
-
-
-static lk_keycode_t lkkbd_keycode[LK_NUM_KEYCODES] = {
+static unsigned short lkkbd_keycode[LK_NUM_KEYCODES] = {
         [0x56] = KEY_F1,
         [0x57] = KEY_F2,
         [0x58] = KEY_F3,
@@ -268,7 +265,7 @@ static lk_keycode_t lkkbd_keycode[LK_NUM_KEYCODES] = {
 };
 
 #define CHECK_LED(LK, VAR_ON, VAR_OFF, LED, BITS) do {          \
-        if (test_bit (LED, (LK)->dev->led))                     \
+        if (test_bit(LED, (LK)->dev->led))                      \
                 VAR_ON |= BITS;                                 \
         else                                                    \
                 VAR_OFF |= BITS;                                \
@@ -278,7 +275,7 @@ static lk_keycode_t lkkbd_keycode[LK_NUM_KEYCODES] = {
  * Per-keyboard data
  */
 struct lkkbd {
-        lk_keycode_t keycode[LK_NUM_KEYCODES];
+        unsigned short keycode[LK_NUM_KEYCODES];
         int ignore_bytes;
         unsigned char id[LK_NUM_IGNORE_BYTES];
         struct input_dev *dev;
@@ -301,26 +298,25 @@ static struct {
         unsigned char *name;
 } lk_response[] = {
 #define RESPONSE(x) { .value = (x), .name = #x, }
-        RESPONSE (LK_STUCK_KEY),
-        RESPONSE (LK_SELFTEST_FAILED),
-        RESPONSE (LK_ALL_KEYS_UP),
-        RESPONSE (LK_METRONOME),
-        RESPONSE (LK_OUTPUT_ERROR),
-        RESPONSE (LK_INPUT_ERROR),
-        RESPONSE (LK_KBD_LOCKED),
-        RESPONSE (LK_KBD_TEST_MODE_ACK),
-        RESPONSE (LK_PREFIX_KEY_DOWN),
-        RESPONSE (LK_MODE_CHANGE_ACK),
-        RESPONSE (LK_RESPONSE_RESERVED),
+        RESPONSE(LK_STUCK_KEY),
+        RESPONSE(LK_SELFTEST_FAILED),
+        RESPONSE(LK_ALL_KEYS_UP),
+        RESPONSE(LK_METRONOME),
+        RESPONSE(LK_OUTPUT_ERROR),
+        RESPONSE(LK_INPUT_ERROR),
+        RESPONSE(LK_KBD_LOCKED),
+        RESPONSE(LK_KBD_TEST_MODE_ACK),
+        RESPONSE(LK_PREFIX_KEY_DOWN),
+        RESPONSE(LK_MODE_CHANGE_ACK),
+        RESPONSE(LK_RESPONSE_RESERVED),
 #undef RESPONSE
 };
 
-static unsigned char *
-response_name (unsigned char value)
+static unsigned char *response_name(unsigned char value)
 {
         int i;
 
-        for (i = 0; i < ARRAY_SIZE (lk_response); i++)
+        for (i = 0; i < ARRAY_SIZE(lk_response); i++)
                 if (lk_response[i].value == value)
                         return lk_response[i].name;
 
@@ -331,8 +327,7 @@ response_name (unsigned char value)
 /*
  * Calculate volume parameter byte for a given volume.
  */
-static unsigned char
-volume_to_hw (int volume_percent)
+static unsigned char volume_to_hw(int volume_percent)
 {
         unsigned char ret = 0;
 
@@ -363,8 +358,7 @@ volume_to_hw (int volume_percent)
         return ret;
 }
 
-static void
-lkkbd_detection_done (struct lkkbd *lk)
+static void lkkbd_detection_done(struct lkkbd *lk)
 {
         int i;
 
@@ -377,190 +371,202 @@ lkkbd_detection_done (struct lkkbd *lk)
          * Print keyboard name and modify Compose=Alt on user's request.
          */
         switch (lk->id[4]) {
-                case 1:
-                        strlcpy (lk->name, "DEC LK201 keyboard",
-                                 sizeof (lk->name));
-
-                        if (lk201_compose_is_alt)
-                                lk->keycode[0xb1] = KEY_LEFTALT;
-                        break;
-
-                case 2:
-                        strlcpy (lk->name, "DEC LK401 keyboard",
-                                 sizeof (lk->name));
-                        break;
-
-                default:
-                        strlcpy (lk->name, "Unknown DEC keyboard",
-                                 sizeof (lk->name));
-                        printk (KERN_ERR "lkkbd: keyboard on %s is unknown, "
-                                        "please report to Jan-Benedict Glaw "
-                                        "<jbglaw@lug-owl.de>\n", lk->phys);
-                        printk (KERN_ERR "lkkbd: keyboard ID'ed as:");
-                        for (i = 0; i < LK_NUM_IGNORE_BYTES; i++)
-                                printk (" 0x%02x", lk->id[i]);
-                        printk ("\n");
-                        break;
+        case 1:
+                strlcpy(lk->name, "DEC LK201 keyboard", sizeof(lk->name));
+
+                if (lk201_compose_is_alt)
+                        lk->keycode[0xb1] = KEY_LEFTALT;
+                break;
+
+        case 2:
+                strlcpy(lk->name, "DEC LK401 keyboard", sizeof(lk->name));
+                break;
+
+        default:
+                strlcpy(lk->name, "Unknown DEC keyboard", sizeof(lk->name));
+                printk(KERN_ERR
+                        "lkkbd: keyboard on %s is unknown, please report to "
+                        "Jan-Benedict Glaw <jbglaw@lug-owl.de>\n", lk->phys);
+                printk(KERN_ERR "lkkbd: keyboard ID'ed as:");
+                for (i = 0; i < LK_NUM_IGNORE_BYTES; i++)
+                        printk(" 0x%02x", lk->id[i]);
+                printk("\n");
+                break;
         }
-        printk (KERN_INFO "lkkbd: keyboard on %s identified as: %s\n",
-                        lk->phys, lk->name);
+
+        printk(KERN_INFO "lkkbd: keyboard on %s identified as: %s\n",
+                lk->phys, lk->name);
 
         /*
          * Report errors during keyboard boot-up.
          */
         switch (lk->id[2]) {
-                case 0x00:
-                        /* All okay */
-                        break;
-
-                case LK_STUCK_KEY:
-                        printk (KERN_ERR "lkkbd: Stuck key on keyboard at "
-                                        "%s\n", lk->phys);
-                        break;
-
-                case LK_SELFTEST_FAILED:
-                        printk (KERN_ERR "lkkbd: Selftest failed on keyboard "
-                                        "at %s, keyboard may not work "
-                                        "properly\n", lk->phys);
-                        break;
-
-                default:
-                        printk (KERN_ERR "lkkbd: Unknown error %02x on "
-                                        "keyboard at %s\n", lk->id[2],
-                                        lk->phys);
-                        break;
+        case 0x00:
+                /* All okay */
+                break;
+
+        case LK_STUCK_KEY:
+                printk(KERN_ERR "lkkbd: Stuck key on keyboard at %s\n",
+                        lk->phys);
+                break;
+
+        case LK_SELFTEST_FAILED:
+                printk(KERN_ERR
+                        "lkkbd: Selftest failed on keyboard at %s, "
+                        "keyboard may not work properly\n", lk->phys);
+                break;
+
+        default:
+                printk(KERN_ERR
+                        "lkkbd: Unknown error %02x on keyboard at %s\n",
+                        lk->id[2], lk->phys);
+                break;
         }
 
         /*
          * Try to hint user if there's a stuck key.
          */
         if (lk->id[2] == LK_STUCK_KEY && lk->id[3] != 0)
-                printk (KERN_ERR "Scancode of stuck key is 0x%02x, keycode "
-                                "is 0x%04x\n", lk->id[3],
-                                lk->keycode[lk->id[3]]);
-
-        return;
+                printk(KERN_ERR
+                        "Scancode of stuck key is 0x%02x, keycode is 0x%04x\n",
+                        lk->id[3], lk->keycode[lk->id[3]]);
 }
 
 /*
  * lkkbd_interrupt() is called by the low level driver when a character
  * is received.
  */
-static irqreturn_t
-lkkbd_interrupt (struct serio *serio, unsigned char data, unsigned int flags)
+static irqreturn_t lkkbd_interrupt(struct serio *serio,
+                                   unsigned char data, unsigned int flags)
 {
-        struct lkkbd *lk = serio_get_drvdata (serio);
+        struct lkkbd *lk = serio_get_drvdata(serio);
+        struct input_dev *input_dev = lk->dev;
+        unsigned int keycode;
         int i;
 
-        DBG (KERN_INFO "Got byte 0x%02x\n", data);
+        DBG(KERN_INFO "Got byte 0x%02x\n", data);
 
         if (lk->ignore_bytes > 0) {
-                DBG (KERN_INFO "Ignoring a byte on %s\n", lk->name);
+                DBG(KERN_INFO "Ignoring a byte on %s\n", lk->name);
                 lk->id[LK_NUM_IGNORE_BYTES - lk->ignore_bytes--] = data;
 
                 if (lk->ignore_bytes == 0)
-                        lkkbd_detection_done (lk);
+                        lkkbd_detection_done(lk);
 
                 return IRQ_HANDLED;
         }
 
         switch (data) {
-                case LK_ALL_KEYS_UP:
-                        for (i = 0; i < ARRAY_SIZE (lkkbd_keycode); i++)
-                                if (lk->keycode[i] != KEY_RESERVED)
-                                        input_report_key (lk->dev, lk->keycode[i], 0);
-                        input_sync (lk->dev);
-                        break;
-
-                case 0x01:
-                        DBG (KERN_INFO "Got 0x01, scheduling re-initialization\n");
-                        lk->ignore_bytes = LK_NUM_IGNORE_BYTES;
-                        lk->id[LK_NUM_IGNORE_BYTES - lk->ignore_bytes--] = data;
-                        schedule_work (&lk->tq);
-                        break;
-
-                case LK_METRONOME:
-                case LK_OUTPUT_ERROR:
-                case LK_INPUT_ERROR:
-                case LK_KBD_LOCKED:
-                case LK_KBD_TEST_MODE_ACK:
-                case LK_PREFIX_KEY_DOWN:
-                case LK_MODE_CHANGE_ACK:
-                case LK_RESPONSE_RESERVED:
-                        DBG (KERN_INFO "Got %s and don't know how to handle...\n",
-                                        response_name (data));
-                        break;
-
-                default:
-                        if (lk->keycode[data] != KEY_RESERVED) {
-                                if (!test_bit (lk->keycode[data], lk->dev->key))
-                                        input_report_key (lk->dev, lk->keycode[data], 1);
-                                else
-                                        input_report_key (lk->dev, lk->keycode[data], 0);
-                                input_sync (lk->dev);
-                        } else
-                                printk (KERN_WARNING "%s: Unknown key with "
-                                                "scancode 0x%02x on %s.\n",
-                                                __FILE__, data, lk->name);
+        case LK_ALL_KEYS_UP:
+                for (i = 0; i < ARRAY_SIZE(lkkbd_keycode); i++)
+                        input_report_key(input_dev, lk->keycode[i], 0);
+                input_sync(input_dev);
+                break;
+
+        case 0x01:
+                DBG(KERN_INFO "Got 0x01, scheduling re-initialization\n");
+                lk->ignore_bytes = LK_NUM_IGNORE_BYTES;
+                lk->id[LK_NUM_IGNORE_BYTES - lk->ignore_bytes--] = data;
+                schedule_work(&lk->tq);
+                break;
+
+        case LK_METRONOME:
+        case LK_OUTPUT_ERROR:
+        case LK_INPUT_ERROR:
+        case LK_KBD_LOCKED:
+        case LK_KBD_TEST_MODE_ACK:
+        case LK_PREFIX_KEY_DOWN:
+        case LK_MODE_CHANGE_ACK:
+        case LK_RESPONSE_RESERVED:
+                DBG(KERN_INFO "Got %s and don't know how to handle...\n",
+                        response_name(data));
+                break;
+
+        default:
+                keycode = lk->keycode[data];
+                if (keycode != KEY_RESERVED) {
+                        input_report_key(input_dev, keycode,
+                                         !test_bit(keycode, input_dev->key));
+                        input_sync(input_dev);
+                } else {
+                        printk(KERN_WARNING
+                                "%s: Unknown key with scancode 0x%02x on %s.\n",
+                                __FILE__, data, lk->name);
+                }
         }
 
         return IRQ_HANDLED;
 }
 
+static void lkkbd_toggle_leds(struct lkkbd *lk)
+{
+        struct serio *serio = lk->serio;
+        unsigned char leds_on = 0;
+        unsigned char leds_off = 0;
+
+        CHECK_LED(lk, leds_on, leds_off, LED_CAPSL, LK_LED_SHIFTLOCK);
+        CHECK_LED(lk, leds_on, leds_off, LED_COMPOSE, LK_LED_COMPOSE);
+        CHECK_LED(lk, leds_on, leds_off, LED_SCROLLL, LK_LED_SCROLLLOCK);
+        CHECK_LED(lk, leds_on, leds_off, LED_SLEEP, LK_LED_WAIT);
+        if (leds_on != 0) {
+                serio_write(serio, LK_CMD_LED_ON);
+                serio_write(serio, leds_on);
+        }
+        if (leds_off != 0) {
+                serio_write(serio, LK_CMD_LED_OFF);
+                serio_write(serio, leds_off);
+        }
+}
+
+static void lkkbd_toggle_keyclick(struct lkkbd *lk, bool on)
+{
+        struct serio *serio = lk->serio;
+
+        if (on) {
+                DBG("%s: Activating key clicks\n", __func__);
+                serio_write(serio, LK_CMD_ENABLE_KEYCLICK);
+                serio_write(serio, volume_to_hw(lk->keyclick_volume));
+                serio_write(serio, LK_CMD_ENABLE_CTRCLICK);
+                serio_write(serio, volume_to_hw(lk->ctrlclick_volume));
+        } else {
+                DBG("%s: Deactivating key clicks\n", __func__);
+                serio_write(serio, LK_CMD_DISABLE_KEYCLICK);
+                serio_write(serio, LK_CMD_DISABLE_CTRCLICK);
+        }
+
+}
+
 /*
  * lkkbd_event() handles events from the input module.
  */
-static int
-lkkbd_event (struct input_dev *dev, unsigned int type, unsigned int code,
-                int value)
+static int lkkbd_event(struct input_dev *dev,
+                        unsigned int type, unsigned int code, int value)
 {
-        struct lkkbd *lk = input_get_drvdata (dev);
-        unsigned char leds_on = 0;
-        unsigned char leds_off = 0;
+        struct lkkbd *lk = input_get_drvdata(dev);
 
         switch (type) {
-                case EV_LED:
-                        CHECK_LED (lk, leds_on, leds_off, LED_CAPSL, LK_LED_SHIFTLOCK);
-                        CHECK_LED (lk, leds_on, leds_off, LED_COMPOSE, LK_LED_COMPOSE);
-                        CHECK_LED (lk, leds_on, leds_off, LED_SCROLLL, LK_LED_SCROLLLOCK);
-                        CHECK_LED (lk, leds_on, leds_off, LED_SLEEP, LK_LED_WAIT);
-                        if (leds_on != 0) {
-                                serio_write (lk->serio, LK_CMD_LED_ON);
-                                serio_write (lk->serio, leds_on);
-                        }
-                        if (leds_off != 0) {
-                                serio_write (lk->serio, LK_CMD_LED_OFF);
-                                serio_write (lk->serio, leds_off);
-                        }
+        case EV_LED:
+                lkkbd_toggle_leds(lk);
+                return 0;
+
+        case EV_SND:
+                switch (code) {
+                case SND_CLICK:
+                        lkkbd_toggle_keyclick(lk, value);
                         return 0;
 
-                case EV_SND:
-                        switch (code) {
-                                case SND_CLICK:
-                                        if (value == 0) {
-                                                DBG ("%s: Deactivating key clicks\n", __func__);
-                                                serio_write (lk->serio, LK_CMD_DISABLE_KEYCLICK);
-                                                serio_write (lk->serio, LK_CMD_DISABLE_CTRCLICK);
-                                        } else {
-                                                DBG ("%s: Activating key clicks\n", __func__);
-                                                serio_write (lk->serio, LK_CMD_ENABLE_KEYCLICK);
-                                                serio_write (lk->serio, volume_to_hw (lk->keyclick_volume));
-                                                serio_write (lk->serio, LK_CMD_ENABLE_CTRCLICK);
-                                                serio_write (lk->serio, volume_to_hw (lk->ctrlclick_volume));
-                                        }
-                                        return 0;
-
-                                case SND_BELL:
-                                        if (value != 0)
-                                                serio_write (lk->serio, LK_CMD_SOUND_BELL);
-
-                                        return 0;
-                        }
-                        break;
-
-                default:
-                        printk (KERN_ERR "%s (): Got unknown type %d, code %d, value %d\n",
-                                        __func__, type, code, value);
+                case SND_BELL:
+                        if (value != 0)
+                                serio_write(lk->serio, LK_CMD_SOUND_BELL);
+
+                        return 0;
+                }
+
+                break;
+
+        default:
+                printk(KERN_ERR "%s(): Got unknown type %d, code %d, value %d\n",
+                        __func__, type, code, value);
         }
 
         return -1;
@@ -570,79 +576,56 @@ lkkbd_event (struct input_dev *dev, unsigned int type, unsigned int code,
  * lkkbd_reinit() sets leds and beeps to a state the computer remembers they
  * were in.
  */
-static void
-lkkbd_reinit (struct work_struct *work)
+static void lkkbd_reinit(struct work_struct *work)
 {
         struct lkkbd *lk = container_of(work, struct lkkbd, tq);
         int division;
-        unsigned char leds_on = 0;
-        unsigned char leds_off = 0;
 
         /* Ask for ID */
-        serio_write (lk->serio, LK_CMD_REQUEST_ID);
+        serio_write(lk->serio, LK_CMD_REQUEST_ID);
 
         /* Reset parameters */
-        serio_write (lk->serio, LK_CMD_SET_DEFAULTS);
+        serio_write(lk->serio, LK_CMD_SET_DEFAULTS);
 
         /* Set LEDs */
-        CHECK_LED (lk, leds_on, leds_off, LED_CAPSL, LK_LED_SHIFTLOCK);
-        CHECK_LED (lk, leds_on, leds_off, LED_COMPOSE, LK_LED_COMPOSE);
-        CHECK_LED (lk, leds_on, leds_off, LED_SCROLLL, LK_LED_SCROLLLOCK);
-        CHECK_LED (lk, leds_on, leds_off, LED_SLEEP, LK_LED_WAIT);
-        if (leds_on != 0) {
-                serio_write (lk->serio, LK_CMD_LED_ON);
-                serio_write (lk->serio, leds_on);
-        }
-        if (leds_off != 0) {
-                serio_write (lk->serio, LK_CMD_LED_OFF);
-                serio_write (lk->serio, leds_off);
-        }
+        lkkbd_toggle_leds(lk);
 
         /*
          * Try to activate extended LK401 mode. This command will
          * only work with a LK401 keyboard and grants access to
          * LAlt, RAlt, RCompose and RShift.
          */
-        serio_write (lk->serio, LK_CMD_ENABLE_LK401);
+        serio_write(lk->serio, LK_CMD_ENABLE_LK401);
 
         /* Set all keys to UPDOWN mode */
         for (division = 1; division <= 14; division++)
-                serio_write (lk->serio, LK_CMD_SET_MODE (LK_MODE_UPDOWN,
-                                        division));
+                serio_write(lk->serio,
+                            LK_CMD_SET_MODE(LK_MODE_UPDOWN, division));
 
         /* Enable bell and set volume */
-        serio_write (lk->serio, LK_CMD_ENABLE_BELL);
-        serio_write (lk->serio, volume_to_hw (lk->bell_volume));
+        serio_write(lk->serio, LK_CMD_ENABLE_BELL);
+        serio_write(lk->serio, volume_to_hw(lk->bell_volume));
 
         /* Enable/disable keyclick (and possibly set volume) */
-        if (test_bit (SND_CLICK, lk->dev->snd)) {
-                serio_write (lk->serio, LK_CMD_ENABLE_KEYCLICK);
-                serio_write (lk->serio, volume_to_hw (lk->keyclick_volume));
-                serio_write (lk->serio, LK_CMD_ENABLE_CTRCLICK);
-                serio_write (lk->serio, volume_to_hw (lk->ctrlclick_volume));
-        } else {
-                serio_write (lk->serio, LK_CMD_DISABLE_KEYCLICK);
-                serio_write (lk->serio, LK_CMD_DISABLE_CTRCLICK);
-        }
+        lkkbd_toggle_keyclick(lk, test_bit(SND_CLICK, lk->dev->snd));
 
         /* Sound the bell if needed */
-        if (test_bit (SND_BELL, lk->dev->snd))
-                serio_write (lk->serio, LK_CMD_SOUND_BELL);
+        if (test_bit(SND_BELL, lk->dev->snd))
+                serio_write(lk->serio, LK_CMD_SOUND_BELL);
 }
 
 /*
  * lkkbd_connect() probes for a LK keyboard and fills the necessary structures.
  */
-static int
-lkkbd_connect (struct serio *serio, struct serio_driver *drv)
+static int lkkbd_connect(struct serio *serio, struct serio_driver *drv)
 {
         struct lkkbd *lk;
         struct input_dev *input_dev;
         int i;
         int err;
 
-        lk = kzalloc (sizeof (struct lkkbd), GFP_KERNEL);
-        input_dev = input_allocate_device ();
+        lk = kzalloc(sizeof(struct lkkbd), GFP_KERNEL);
+        input_dev = input_allocate_device();
         if (!lk || !input_dev) {
                 err = -ENOMEM;
                 goto fail1;
@@ -650,14 +633,14 @@ lkkbd_connect (struct serio *serio, struct serio_driver *drv)
 
         lk->serio = serio;
         lk->dev = input_dev;
-        INIT_WORK (&lk->tq, lkkbd_reinit);
+        INIT_WORK(&lk->tq, lkkbd_reinit);
         lk->bell_volume = bell_volume;
         lk->keyclick_volume = keyclick_volume;
         lk->ctrlclick_volume = ctrlclick_volume;
-        memcpy (lk->keycode, lkkbd_keycode, sizeof (lk_keycode_t) * LK_NUM_KEYCODES);
+        memcpy(lk->keycode, lkkbd_keycode, sizeof(lk->keycode));
 
-        strlcpy (lk->name, "DEC LK keyboard", sizeof(lk->name));
-        snprintf (lk->phys, sizeof(lk->phys), "%s/input0", serio->phys);
+        strlcpy(lk->name, "DEC LK keyboard", sizeof(lk->name));
+        snprintf(lk->phys, sizeof(lk->phys), "%s/input0", serio->phys);
 
         input_dev->name = lk->name;
         input_dev->phys = lk->phys;
@@ -668,62 +651,61 @@ lkkbd_connect (struct serio *serio, struct serio_driver *drv)
         input_dev->dev.parent = &serio->dev;
         input_dev->event = lkkbd_event;
 
-        input_set_drvdata (input_dev, lk);
+        input_set_drvdata(input_dev, lk);
 
-        set_bit (EV_KEY, input_dev->evbit);
-        set_bit (EV_LED, input_dev->evbit);
-        set_bit (EV_SND, input_dev->evbit);
-        set_bit (EV_REP, input_dev->evbit);
-        set_bit (LED_CAPSL, input_dev->ledbit);
-        set_bit (LED_SLEEP, input_dev->ledbit);
-        set_bit (LED_COMPOSE, input_dev->ledbit);
-        set_bit (LED_SCROLLL, input_dev->ledbit);
-        set_bit (SND_BELL, input_dev->sndbit);
-        set_bit (SND_CLICK, input_dev->sndbit);
+        __set_bit(EV_KEY, input_dev->evbit);
+        __set_bit(EV_LED, input_dev->evbit);
+        __set_bit(EV_SND, input_dev->evbit);
+        __set_bit(EV_REP, input_dev->evbit);
+        __set_bit(LED_CAPSL, input_dev->ledbit);
+        __set_bit(LED_SLEEP, input_dev->ledbit);
+        __set_bit(LED_COMPOSE, input_dev->ledbit);
+        __set_bit(LED_SCROLLL, input_dev->ledbit);
+        __set_bit(SND_BELL, input_dev->sndbit);
+        __set_bit(SND_CLICK, input_dev->sndbit);
 
         input_dev->keycode = lk->keycode;
-        input_dev->keycodesize = sizeof (lk_keycode_t);
-        input_dev->keycodemax = LK_NUM_KEYCODES;
+        input_dev->keycodesize = sizeof(lk->keycode[0]);
+        input_dev->keycodemax = ARRAY_SIZE(lk->keycode);
 
         for (i = 0; i < LK_NUM_KEYCODES; i++)
-                __set_bit (lk->keycode[i], input_dev->keybit);
+                __set_bit(lk->keycode[i], input_dev->keybit);
         __clear_bit(KEY_RESERVED, input_dev->keybit);
 
-        serio_set_drvdata (serio, lk);
+        serio_set_drvdata(serio, lk);
 
-        err = serio_open (serio, drv);
+        err = serio_open(serio, drv);
         if (err)
                 goto fail2;
 
-        err = input_register_device (lk->dev);
+        err = input_register_device(lk->dev);
         if (err)
                 goto fail3;
 
-        serio_write (lk->serio, LK_CMD_POWERCYCLE_RESET);
+        serio_write(lk->serio, LK_CMD_POWERCYCLE_RESET);
 
         return 0;
 
- fail3: serio_close (serio);
- fail2: serio_set_drvdata (serio, NULL);
- fail1: input_free_device (input_dev);
-        kfree (lk);
+ fail3: serio_close(serio);
+ fail2: serio_set_drvdata(serio, NULL);
+ fail1: input_free_device(input_dev);
+        kfree(lk);
         return err;
 }
 
 /*
  * lkkbd_disconnect() unregisters and closes behind us.
  */
-static void
-lkkbd_disconnect (struct serio *serio)
+static void lkkbd_disconnect(struct serio *serio)
 {
-        struct lkkbd *lk = serio_get_drvdata (serio);
-
-        input_get_device (lk->dev);
-        input_unregister_device (lk->dev);
-        serio_close (serio);
-        serio_set_drvdata (serio, NULL);
-        input_put_device (lk->dev);
-        kfree (lk);
+        struct lkkbd *lk = serio_get_drvdata(serio);
+
+        input_get_device(lk->dev);
+        input_unregister_device(lk->dev);
+        serio_close(serio);
+        serio_set_drvdata(serio, NULL);
+        input_put_device(lk->dev);
+        kfree(lk);
 }
 
 static struct serio_device_id lkkbd_serio_ids[] = {
@@ -752,18 +734,16 @@ static struct serio_driver lkkbd_drv = {
 /*
  * The functions for insering/removing us as a module.
  */
-static int __init
-lkkbd_init (void)
+static int __init lkkbd_init(void)
 {
         return serio_register_driver(&lkkbd_drv);
 }
 
-static void __exit
-lkkbd_exit (void)
+static void __exit lkkbd_exit(void)
 {
         serio_unregister_driver(&lkkbd_drv);
 }
 
-module_init (lkkbd_init);
-module_exit (lkkbd_exit);
+module_init(lkkbd_init);
+module_exit(lkkbd_exit);
 
diff --git a/drivers/input/keyboard/matrix_keypad.c b/drivers/input/keyboard/matrix_keypad.c
index 91cfe5170265..34f4a29d4973 100644
--- a/drivers/input/keyboard/matrix_keypad.c
+++ b/drivers/input/keyboard/matrix_keypad.c
@@ -213,8 +213,9 @@ static void matrix_keypad_stop(struct input_dev *dev)
 }
 
 #ifdef CONFIG_PM
-static int matrix_keypad_suspend(struct platform_device *pdev, pm_message_t state)
+static int matrix_keypad_suspend(struct device *dev)
 {
+        struct platform_device *pdev = to_platform_device(dev);
         struct matrix_keypad *keypad = platform_get_drvdata(pdev);
         const struct matrix_keypad_platform_data *pdata = keypad->pdata;
         int i;
@@ -228,8 +229,9 @@ static int matrix_keypad_suspend(struct platform_device *pdev, pm_message_t stat
         return 0;
 }
 
-static int matrix_keypad_resume(struct platform_device *pdev)
+static int matrix_keypad_resume(struct device *dev)
 {
+        struct platform_device *pdev = to_platform_device(dev);
         struct matrix_keypad *keypad = platform_get_drvdata(pdev);
         const struct matrix_keypad_platform_data *pdata = keypad->pdata;
         int i;
@@ -242,9 +244,9 @@ static int matrix_keypad_resume(struct platform_device *pdev)
 
         return 0;
 }
-#else
-#define matrix_keypad_suspend   NULL
-#define matrix_keypad_resume    NULL
+
+static const SIMPLE_DEV_PM_OPS(matrix_keypad_pm_ops,
+                                matrix_keypad_suspend, matrix_keypad_resume);
 #endif
 
 static int __devinit init_matrix_gpio(struct platform_device *pdev,
@@ -417,11 +419,12 @@ static int __devexit matrix_keypad_remove(struct platform_device *pdev)
 static struct platform_driver matrix_keypad_driver = {
         .probe          = matrix_keypad_probe,
         .remove         = __devexit_p(matrix_keypad_remove),
-        .suspend        = matrix_keypad_suspend,
-        .resume         = matrix_keypad_resume,
         .driver         = {
                 .name   = "matrix-keypad",
                 .owner  = THIS_MODULE,
+#ifdef CONFIG_PM
+                .pm     = &matrix_keypad_pm_ops,
+#endif
         },
 };