USB: remove warn() macro from usb input drivers

USB should not be having it's own printk macros, so remove warn() and
use the system-wide standard of dev_warn() wherever possible.  In the
few places that will not work out, use a basic printk().

Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

4 files changed, 37 insertions, 23 deletions

diff --git a/drivers/input/joystick/iforce/iforce-ff.c b/drivers/input/joystick/iforce/iforce-ff.c
index 7839b7b6fa96..0de9a0943a9e 100644
--- a/drivers/input/joystick/iforce/iforce-ff.c
+++ b/drivers/input/joystick/iforce/iforce-ff.c
@@ -197,13 +197,16 @@ static unsigned char find_button(struct iforce *iforce, signed short button)
  * Analyse the changes in an effect, and tell if we need to send an condition
  * parameter packet
  */
-static int need_condition_modifier(struct ff_effect *old, struct ff_effect *new)
+static int need_condition_modifier(struct iforce *iforce,
+                                   struct ff_effect *old,
+                                   struct ff_effect *new)
 {
         int ret = 0;
         int i;
 
         if (new->type != FF_SPRING && new->type != FF_FRICTION) {
-                warn("bad effect type in need_condition_modifier");
+                dev_warn(&iforce->dev->dev, "bad effect type in %s\n",
+                         __func__);
                 return 0;
         }
 
@@ -222,10 +225,13 @@ static int need_condition_modifier(struct ff_effect *old, struct ff_effect *new)
  * Analyse the changes in an effect, and tell if we need to send a magnitude
  * parameter packet
  */
-static int need_magnitude_modifier(struct ff_effect *old, struct ff_effect *effect)
+static int need_magnitude_modifier(struct iforce *iforce,
+                                   struct ff_effect *old,
+                                   struct ff_effect *effect)
 {
         if (effect->type != FF_CONSTANT) {
-                warn("bad effect type in need_envelope_modifier");
+                dev_warn(&iforce->dev->dev, "bad effect type in %s\n",
+                         __func__);
                 return 0;
         }
 
@@ -236,7 +242,8 @@ static int need_magnitude_modifier(struct ff_effect *old, struct ff_effect *effe
  * Analyse the changes in an effect, and tell if we need to send an envelope
  * parameter packet
  */
-static int need_envelope_modifier(struct ff_effect *old, struct ff_effect *effect)
+static int need_envelope_modifier(struct iforce *iforce, struct ff_effect *old,
+                                  struct ff_effect *effect)
 {
         switch (effect->type) {
         case FF_CONSTANT:
@@ -256,7 +263,8 @@ static int need_envelope_modifier(struct ff_effect *old, struct ff_effect *effec
                 break;
 
         default:
-                warn("bad effect type in need_envelope_modifier");
+                dev_warn(&iforce->dev->dev, "bad effect type in %s\n",
+                         __func__);
         }
 
         return 0;
@@ -266,10 +274,12 @@ static int need_envelope_modifier(struct ff_effect *old, struct ff_effect *effec
  * Analyse the changes in an effect, and tell if we need to send a periodic
  * parameter effect
  */
-static int need_period_modifier(struct ff_effect *old, struct ff_effect *new)
+static int need_period_modifier(struct iforce *iforce, struct ff_effect *old,
+                                struct ff_effect *new)
 {
         if (new->type != FF_PERIODIC) {
-                warn("bad effect type in need_period_modifier");
+                dev_warn(&iforce->dev->dev, "bad effect type in %s\n",
+                         __func__);
                 return 0;
         }
         return (old->u.periodic.period != new->u.periodic.period
@@ -355,7 +365,7 @@ int iforce_upload_periodic(struct iforce *iforce, struct ff_effect *effect, stru
         int param2_err = 1;
         int core_err = 0;
 
-        if (!old || need_period_modifier(old, effect)) {
+        if (!old || need_period_modifier(iforce, old, effect)) {
                 param1_err = make_period_modifier(iforce, mod1_chunk,
                         old != NULL,
                         effect->u.periodic.magnitude, effect->u.periodic.offset,
@@ -365,7 +375,7 @@ int iforce_upload_periodic(struct iforce *iforce, struct ff_effect *effect, stru
                 set_bit(FF_MOD1_IS_USED, core_effect->flags);
         }
 
-        if (!old || need_envelope_modifier(old, effect)) {
+        if (!old || need_envelope_modifier(iforce, old, effect)) {
                 param2_err = make_envelope_modifier(iforce, mod2_chunk,
                         old !=NULL,
                         effect->u.periodic.envelope.attack_length,
@@ -425,7 +435,7 @@ int iforce_upload_constant(struct iforce *iforce, struct ff_effect *effect, stru
         int param2_err = 1;
         int core_err = 0;
 
-        if (!old || need_magnitude_modifier(old, effect)) {
+        if (!old || need_magnitude_modifier(iforce, old, effect)) {
                 param1_err = make_magnitude_modifier(iforce, mod1_chunk,
                         old != NULL,
                         effect->u.constant.level);
@@ -434,7 +444,7 @@ int iforce_upload_constant(struct iforce *iforce, struct ff_effect *effect, stru
                 set_bit(FF_MOD1_IS_USED, core_effect->flags);
         }
 
-        if (!old || need_envelope_modifier(old, effect)) {
+        if (!old || need_envelope_modifier(iforce, old, effect)) {
                 param2_err = make_envelope_modifier(iforce, mod2_chunk,
                         old != NULL,
                         effect->u.constant.envelope.attack_length,
@@ -487,7 +497,7 @@ int iforce_upload_condition(struct iforce *iforce, struct ff_effect *effect, str
                 default: return -1;
         }
 
-        if (!old || need_condition_modifier(old, effect)) {
+        if (!old || need_condition_modifier(iforce, old, effect)) {
                 param_err = make_condition_modifier(iforce, mod1_chunk,
                         old != NULL,
                         effect->u.condition[0].right_saturation,
diff --git a/drivers/input/joystick/iforce/iforce-main.c b/drivers/input/joystick/iforce/iforce-main.c
index 61ee6e38739d..baabf8302645 100644
--- a/drivers/input/joystick/iforce/iforce-main.c
+++ b/drivers/input/joystick/iforce/iforce-main.c
@@ -218,7 +218,9 @@ static void iforce_release(struct input_dev *dev)
                 /* Check: no effects should be present in memory */
                 for (i = 0; i < dev->ff->max_effects; i++) {
                         if (test_bit(FF_CORE_IS_USED, iforce->core_effects[i].flags)) {
-                                warn("iforce_release: Device still owns effects");
+                                dev_warn(&dev->dev,
+                                        "%s: Device still owns effects\n",
+                                        __func__);
                                 break;
                         }
                 }
@@ -335,26 +337,26 @@ int iforce_init_device(struct iforce *iforce)
         if (!iforce_get_id_packet(iforce, "M"))
                 input_dev->id.vendor = (iforce->edata[2] << 8) | iforce->edata[1];
         else
-                warn("Device does not respond to id packet M");
+                dev_warn(&iforce->dev->dev, "Device does not respond to id packet M\n");
 
         if (!iforce_get_id_packet(iforce, "P"))
                 input_dev->id.product = (iforce->edata[2] << 8) | iforce->edata[1];
         else
-                warn("Device does not respond to id packet P");
+                dev_warn(&iforce->dev->dev, "Device does not respond to id packet P\n");
 
         if (!iforce_get_id_packet(iforce, "B"))
                 iforce->device_memory.end = (iforce->edata[2] << 8) | iforce->edata[1];
         else
-                warn("Device does not respond to id packet B");
+                dev_warn(&iforce->dev->dev, "Device does not respond to id packet B\n");
 
         if (!iforce_get_id_packet(iforce, "N"))
                 ff_effects = iforce->edata[1];
         else
-                warn("Device does not respond to id packet N");
+                dev_warn(&iforce->dev->dev, "Device does not respond to id packet N\n");
 
         /* Check if the device can store more effects than the driver can really handle */
         if (ff_effects > IFORCE_EFFECTS_MAX) {
-                warn("Limiting number of effects to %d (device reports %d)",
+                dev_warn(&iforce->dev->dev, "Limiting number of effects to %d (device reports %d)\n",
                        IFORCE_EFFECTS_MAX, ff_effects);
                 ff_effects = IFORCE_EFFECTS_MAX;
         }
diff --git a/drivers/input/joystick/iforce/iforce-packets.c b/drivers/input/joystick/iforce/iforce-packets.c
index 015b50aa76fc..a17b50016009 100644
--- a/drivers/input/joystick/iforce/iforce-packets.c
+++ b/drivers/input/joystick/iforce/iforce-packets.c
@@ -65,7 +65,8 @@ int iforce_send_packet(struct iforce *iforce, u16 cmd, unsigned char* data)
 
 
         if (CIRC_SPACE(head, tail, XMIT_SIZE) < n+2) {
-                warn("not enough space in xmit buffer to send new packet");
+                dev_warn(&iforce->dev->dev,
+                         "not enough space in xmit buffer to send new packet\n");
                 spin_unlock_irqrestore(&iforce->xmit_lock, flags);
                 return -1;
         }
@@ -148,7 +149,7 @@ static int mark_core_as_ready(struct iforce *iforce, unsigned short addr)
                         return 0;
                 }
         }
-        warn("unused effect %04x updated !!!", addr);
+        dev_warn(&iforce->dev->dev, "unused effect %04x updated !!!\n", addr);
         return -1;
 }
 
@@ -159,7 +160,8 @@ void iforce_process_packet(struct iforce *iforce, u16 cmd, unsigned char *data)
         static int being_used = 0;
 
         if (being_used)
-                warn("re-entrant call to iforce_process %d", being_used);
+                dev_warn(&iforce->dev->dev,
+                         "re-entrant call to iforce_process %d\n", being_used);
         being_used++;
 
 #ifdef CONFIG_JOYSTICK_IFORCE_232
diff --git a/drivers/input/joystick/iforce/iforce-usb.c b/drivers/input/joystick/iforce/iforce-usb.c
index 851cc4087c2f..f83185aeb511 100644
--- a/drivers/input/joystick/iforce/iforce-usb.c
+++ b/drivers/input/joystick/iforce/iforce-usb.c
@@ -64,7 +64,7 @@ void iforce_usb_xmit(struct iforce *iforce)
 
         if ( (n=usb_submit_urb(iforce->out, GFP_ATOMIC)) ) {
                 clear_bit(IFORCE_XMIT_RUNNING, iforce->xmit_flags);
-                warn("usb_submit_urb failed %d\n", n);
+                dev_warn(&iforce->dev->dev, "usb_submit_urb failed %d\n", n);
         }
 
         /* The IFORCE_XMIT_RUNNING bit is not cleared here. That's intended.