diff options
author | Linus Torvalds <torvalds@linux-foundation.org> | 2008-12-28 15:49:40 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2008-12-28 15:49:40 -0500 |
commit | 0191b625ca5a46206d2fb862bb08f36f2fcb3b31 (patch) | |
tree | 454d1842b1833d976da62abcbd5c47521ebe9bd7 /drivers/infiniband | |
parent | 54a696bd07c14d3b1192d03ce7269bc59b45209a (diff) | |
parent | eb56092fc168bf5af199d47af50c0d84a96db898 (diff) |
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next-2.6
* git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next-2.6: (1429 commits)
net: Allow dependancies of FDDI & Tokenring to be modular.
igb: Fix build warning when DCA is disabled.
net: Fix warning fallout from recent NAPI interface changes.
gro: Fix potential use after free
sfc: If AN is enabled, always read speed/duplex from the AN advertising bits
sfc: When disabling the NIC, close the device rather than unregistering it
sfc: SFT9001: Add cable diagnostics
sfc: Add support for multiple PHY self-tests
sfc: Merge top-level functions for self-tests
sfc: Clean up PHY mode management in loopback self-test
sfc: Fix unreliable link detection in some loopback modes
sfc: Generate unique names for per-NIC workqueues
802.3ad: use standard ethhdr instead of ad_header
802.3ad: generalize out mac address initializer
802.3ad: initialize ports LACPDU from const initializer
802.3ad: remove typedef around ad_system
802.3ad: turn ports is_individual into a bool
802.3ad: turn ports is_enabled into a bool
802.3ad: make ntt bool
ixgbe: Fix set_ringparam in ixgbe to use the same memory pools.
...
Fixed trivial IPv4/6 address printing conflicts in fs/cifs/connect.c due
to the conversion to %pI (in this networking merge) and the addition of
doing IPv6 addresses (from the earlier merge of CIFS).
Diffstat (limited to 'drivers/infiniband')
-rw-r--r-- | drivers/infiniband/core/sysfs.c | 10 | ||||
-rw-r--r-- | drivers/infiniband/hw/amso1100/c2_provider.c | 8 | ||||
-rw-r--r-- | drivers/infiniband/hw/mthca/mthca_mcg.c | 23 | ||||
-rw-r--r-- | drivers/infiniband/hw/nes/nes.c | 17 | ||||
-rw-r--r-- | drivers/infiniband/hw/nes/nes_cm.c | 31 | ||||
-rw-r--r-- | drivers/infiniband/hw/nes/nes_hw.c | 2 | ||||
-rw-r--r-- | drivers/infiniband/hw/nes/nes_nic.c | 13 | ||||
-rw-r--r-- | drivers/infiniband/hw/nes/nes_utils.c | 5 | ||||
-rw-r--r-- | drivers/infiniband/ulp/ipoib/ipoib.h | 23 | ||||
-rw-r--r-- | drivers/infiniband/ulp/ipoib/ipoib_cm.c | 8 | ||||
-rw-r--r-- | drivers/infiniband/ulp/ipoib/ipoib_ib.c | 6 | ||||
-rw-r--r-- | drivers/infiniband/ulp/ipoib/ipoib_main.c | 25 | ||||
-rw-r--r-- | drivers/infiniband/ulp/ipoib/ipoib_multicast.c | 70 | ||||
-rw-r--r-- | drivers/infiniband/ulp/iser/iser_verbs.c | 8 | ||||
-rw-r--r-- | drivers/infiniband/ulp/srp/ib_srp.c | 31 |
15 files changed, 89 insertions, 191 deletions
diff --git a/drivers/infiniband/core/sysfs.c b/drivers/infiniband/core/sysfs.c index 4d1042115598..4f4d1bb9f069 100644 --- a/drivers/infiniband/core/sysfs.c +++ b/drivers/infiniband/core/sysfs.c | |||
@@ -262,15 +262,7 @@ static ssize_t show_port_gid(struct ib_port *p, struct port_attribute *attr, | |||
262 | if (ret) | 262 | if (ret) |
263 | return ret; | 263 | return ret; |
264 | 264 | ||
265 | return sprintf(buf, "%04x:%04x:%04x:%04x:%04x:%04x:%04x:%04x\n", | 265 | return sprintf(buf, "%pI6\n", gid.raw); |
266 | be16_to_cpu(((__be16 *) gid.raw)[0]), | ||
267 | be16_to_cpu(((__be16 *) gid.raw)[1]), | ||
268 | be16_to_cpu(((__be16 *) gid.raw)[2]), | ||
269 | be16_to_cpu(((__be16 *) gid.raw)[3]), | ||
270 | be16_to_cpu(((__be16 *) gid.raw)[4]), | ||
271 | be16_to_cpu(((__be16 *) gid.raw)[5]), | ||
272 | be16_to_cpu(((__be16 *) gid.raw)[6]), | ||
273 | be16_to_cpu(((__be16 *) gid.raw)[7])); | ||
274 | } | 266 | } |
275 | 267 | ||
276 | static ssize_t show_port_pkey(struct ib_port *p, struct port_attribute *attr, | 268 | static ssize_t show_port_pkey(struct ib_port *p, struct port_attribute *attr, |
diff --git a/drivers/infiniband/hw/amso1100/c2_provider.c b/drivers/infiniband/hw/amso1100/c2_provider.c index 69580e282af0..5119d6508181 100644 --- a/drivers/infiniband/hw/amso1100/c2_provider.c +++ b/drivers/infiniband/hw/amso1100/c2_provider.c | |||
@@ -653,7 +653,7 @@ static int c2_service_destroy(struct iw_cm_id *cm_id) | |||
653 | static int c2_pseudo_up(struct net_device *netdev) | 653 | static int c2_pseudo_up(struct net_device *netdev) |
654 | { | 654 | { |
655 | struct in_device *ind; | 655 | struct in_device *ind; |
656 | struct c2_dev *c2dev = netdev->priv; | 656 | struct c2_dev *c2dev = netdev->ml_priv; |
657 | 657 | ||
658 | ind = in_dev_get(netdev); | 658 | ind = in_dev_get(netdev); |
659 | if (!ind) | 659 | if (!ind) |
@@ -678,7 +678,7 @@ static int c2_pseudo_up(struct net_device *netdev) | |||
678 | static int c2_pseudo_down(struct net_device *netdev) | 678 | static int c2_pseudo_down(struct net_device *netdev) |
679 | { | 679 | { |
680 | struct in_device *ind; | 680 | struct in_device *ind; |
681 | struct c2_dev *c2dev = netdev->priv; | 681 | struct c2_dev *c2dev = netdev->ml_priv; |
682 | 682 | ||
683 | ind = in_dev_get(netdev); | 683 | ind = in_dev_get(netdev); |
684 | if (!ind) | 684 | if (!ind) |
@@ -746,14 +746,14 @@ static struct net_device *c2_pseudo_netdev_init(struct c2_dev *c2dev) | |||
746 | /* change ethxxx to iwxxx */ | 746 | /* change ethxxx to iwxxx */ |
747 | strcpy(name, "iw"); | 747 | strcpy(name, "iw"); |
748 | strcat(name, &c2dev->netdev->name[3]); | 748 | strcat(name, &c2dev->netdev->name[3]); |
749 | netdev = alloc_netdev(sizeof(*netdev), name, setup); | 749 | netdev = alloc_netdev(0, name, setup); |
750 | if (!netdev) { | 750 | if (!netdev) { |
751 | printk(KERN_ERR PFX "%s - etherdev alloc failed", | 751 | printk(KERN_ERR PFX "%s - etherdev alloc failed", |
752 | __func__); | 752 | __func__); |
753 | return NULL; | 753 | return NULL; |
754 | } | 754 | } |
755 | 755 | ||
756 | netdev->priv = c2dev; | 756 | netdev->ml_priv = c2dev; |
757 | 757 | ||
758 | SET_NETDEV_DEV(netdev, &c2dev->pcidev->dev); | 758 | SET_NETDEV_DEV(netdev, &c2dev->pcidev->dev); |
759 | 759 | ||
diff --git a/drivers/infiniband/hw/mthca/mthca_mcg.c b/drivers/infiniband/hw/mthca/mthca_mcg.c index 3f5f94879208..d4c81053e439 100644 --- a/drivers/infiniband/hw/mthca/mthca_mcg.c +++ b/drivers/infiniband/hw/mthca/mthca_mcg.c | |||
@@ -87,17 +87,7 @@ static int find_mgm(struct mthca_dev *dev, | |||
87 | } | 87 | } |
88 | 88 | ||
89 | if (0) | 89 | if (0) |
90 | mthca_dbg(dev, "Hash for %04x:%04x:%04x:%04x:" | 90 | mthca_dbg(dev, "Hash for %pI6 is %04x\n", gid, *hash); |
91 | "%04x:%04x:%04x:%04x is %04x\n", | ||
92 | be16_to_cpu(((__be16 *) gid)[0]), | ||
93 | be16_to_cpu(((__be16 *) gid)[1]), | ||
94 | be16_to_cpu(((__be16 *) gid)[2]), | ||
95 | be16_to_cpu(((__be16 *) gid)[3]), | ||
96 | be16_to_cpu(((__be16 *) gid)[4]), | ||
97 | be16_to_cpu(((__be16 *) gid)[5]), | ||
98 | be16_to_cpu(((__be16 *) gid)[6]), | ||
99 | be16_to_cpu(((__be16 *) gid)[7]), | ||
100 | *hash); | ||
101 | 91 | ||
102 | *index = *hash; | 92 | *index = *hash; |
103 | *prev = -1; | 93 | *prev = -1; |
@@ -264,16 +254,7 @@ int mthca_multicast_detach(struct ib_qp *ibqp, union ib_gid *gid, u16 lid) | |||
264 | goto out; | 254 | goto out; |
265 | 255 | ||
266 | if (index == -1) { | 256 | if (index == -1) { |
267 | mthca_err(dev, "MGID %04x:%04x:%04x:%04x:%04x:%04x:%04x:%04x " | 257 | mthca_err(dev, "MGID %pI6 not found\n", gid->raw); |
268 | "not found\n", | ||
269 | be16_to_cpu(((__be16 *) gid->raw)[0]), | ||
270 | be16_to_cpu(((__be16 *) gid->raw)[1]), | ||
271 | be16_to_cpu(((__be16 *) gid->raw)[2]), | ||
272 | be16_to_cpu(((__be16 *) gid->raw)[3]), | ||
273 | be16_to_cpu(((__be16 *) gid->raw)[4]), | ||
274 | be16_to_cpu(((__be16 *) gid->raw)[5]), | ||
275 | be16_to_cpu(((__be16 *) gid->raw)[6]), | ||
276 | be16_to_cpu(((__be16 *) gid->raw)[7])); | ||
277 | err = -EINVAL; | 258 | err = -EINVAL; |
278 | goto out; | 259 | goto out; |
279 | } | 260 | } |
diff --git a/drivers/infiniband/hw/nes/nes.c b/drivers/infiniband/hw/nes/nes.c index aa1dc41f04c8..b9611ade9eab 100644 --- a/drivers/infiniband/hw/nes/nes.c +++ b/drivers/infiniband/hw/nes/nes.c | |||
@@ -142,14 +142,9 @@ static int nes_inetaddr_event(struct notifier_block *notifier, | |||
142 | struct nes_device *nesdev; | 142 | struct nes_device *nesdev; |
143 | struct net_device *netdev; | 143 | struct net_device *netdev; |
144 | struct nes_vnic *nesvnic; | 144 | struct nes_vnic *nesvnic; |
145 | unsigned int addr; | 145 | |
146 | unsigned int mask; | 146 | nes_debug(NES_DBG_NETDEV, "nes_inetaddr_event: ip address %pI4, netmask %pI4.\n", |
147 | 147 | &ifa->ifa_address, &ifa->ifa_mask); | |
148 | addr = ntohl(ifa->ifa_address); | ||
149 | mask = ntohl(ifa->ifa_mask); | ||
150 | nes_debug(NES_DBG_NETDEV, "nes_inetaddr_event: ip address " NIPQUAD_FMT | ||
151 | ", netmask " NIPQUAD_FMT ".\n", | ||
152 | HIPQUAD(addr), HIPQUAD(mask)); | ||
153 | list_for_each_entry(nesdev, &nes_dev_list, list) { | 148 | list_for_each_entry(nesdev, &nes_dev_list, list) { |
154 | nes_debug(NES_DBG_NETDEV, "Nesdev list entry = 0x%p. (%s)\n", | 149 | nes_debug(NES_DBG_NETDEV, "Nesdev list entry = 0x%p. (%s)\n", |
155 | nesdev, nesdev->netdev[0]->name); | 150 | nesdev, nesdev->netdev[0]->name); |
@@ -360,10 +355,8 @@ struct ib_qp *nes_get_qp(struct ib_device *device, int qpn) | |||
360 | */ | 355 | */ |
361 | static void nes_print_macaddr(struct net_device *netdev) | 356 | static void nes_print_macaddr(struct net_device *netdev) |
362 | { | 357 | { |
363 | DECLARE_MAC_BUF(mac); | 358 | nes_debug(NES_DBG_INIT, "%s: %pM, IRQ %u\n", |
364 | 359 | netdev->name, netdev->dev_addr, netdev->irq); | |
365 | nes_debug(NES_DBG_INIT, "%s: %s, IRQ %u\n", | ||
366 | netdev->name, print_mac(mac, netdev->dev_addr), netdev->irq); | ||
367 | } | 360 | } |
368 | 361 | ||
369 | /** | 362 | /** |
diff --git a/drivers/infiniband/hw/nes/nes_cm.c b/drivers/infiniband/hw/nes/nes_cm.c index cb48041bed69..a812db243477 100644 --- a/drivers/infiniband/hw/nes/nes_cm.c +++ b/drivers/infiniband/hw/nes/nes_cm.c | |||
@@ -782,8 +782,8 @@ static struct nes_cm_node *find_node(struct nes_cm_core *cm_core, | |||
782 | /* get a handle on the hte */ | 782 | /* get a handle on the hte */ |
783 | hte = &cm_core->connected_nodes; | 783 | hte = &cm_core->connected_nodes; |
784 | 784 | ||
785 | nes_debug(NES_DBG_CM, "Searching for an owner node: " NIPQUAD_FMT ":%x from core %p->%p\n", | 785 | nes_debug(NES_DBG_CM, "Searching for an owner node: %pI4:%x from core %p->%p\n", |
786 | HIPQUAD(loc_addr), loc_port, cm_core, hte); | 786 | &loc_addr, loc_port, cm_core, hte); |
787 | 787 | ||
788 | /* walk list and find cm_node associated with this session ID */ | 788 | /* walk list and find cm_node associated with this session ID */ |
789 | spin_lock_irqsave(&cm_core->ht_lock, flags); | 789 | spin_lock_irqsave(&cm_core->ht_lock, flags); |
@@ -832,8 +832,8 @@ static struct nes_cm_listener *find_listener(struct nes_cm_core *cm_core, | |||
832 | } | 832 | } |
833 | spin_unlock_irqrestore(&cm_core->listen_list_lock, flags); | 833 | spin_unlock_irqrestore(&cm_core->listen_list_lock, flags); |
834 | 834 | ||
835 | nes_debug(NES_DBG_CM, "Unable to find listener for " NIPQUAD_FMT ":%x\n", | 835 | nes_debug(NES_DBG_CM, "Unable to find listener for %pI4:%x\n", |
836 | HIPQUAD(dst_addr), dst_port); | 836 | &dst_addr, dst_port); |
837 | 837 | ||
838 | /* no listener */ | 838 | /* no listener */ |
839 | return NULL; | 839 | return NULL; |
@@ -988,7 +988,6 @@ static int nes_addr_resolve_neigh(struct nes_vnic *nesvnic, u32 dst_ip) | |||
988 | struct flowi fl; | 988 | struct flowi fl; |
989 | struct neighbour *neigh; | 989 | struct neighbour *neigh; |
990 | int rc = -1; | 990 | int rc = -1; |
991 | DECLARE_MAC_BUF(mac); | ||
992 | 991 | ||
993 | memset(&fl, 0, sizeof fl); | 992 | memset(&fl, 0, sizeof fl); |
994 | fl.nl_u.ip4_u.daddr = htonl(dst_ip); | 993 | fl.nl_u.ip4_u.daddr = htonl(dst_ip); |
@@ -1002,8 +1001,8 @@ static int nes_addr_resolve_neigh(struct nes_vnic *nesvnic, u32 dst_ip) | |||
1002 | if (neigh) { | 1001 | if (neigh) { |
1003 | if (neigh->nud_state & NUD_VALID) { | 1002 | if (neigh->nud_state & NUD_VALID) { |
1004 | nes_debug(NES_DBG_CM, "Neighbor MAC address for 0x%08X" | 1003 | nes_debug(NES_DBG_CM, "Neighbor MAC address for 0x%08X" |
1005 | " is %s, Gateway is 0x%08X \n", dst_ip, | 1004 | " is %pM, Gateway is 0x%08X \n", dst_ip, |
1006 | print_mac(mac, neigh->ha), ntohl(rt->rt_gateway)); | 1005 | neigh->ha, ntohl(rt->rt_gateway)); |
1007 | nes_manage_arp_cache(nesvnic->netdev, neigh->ha, | 1006 | nes_manage_arp_cache(nesvnic->netdev, neigh->ha, |
1008 | dst_ip, NES_ARP_ADD); | 1007 | dst_ip, NES_ARP_ADD); |
1009 | rc = nes_arp_table(nesvnic->nesdev, dst_ip, NULL, | 1008 | rc = nes_arp_table(nesvnic->nesdev, dst_ip, NULL, |
@@ -1032,7 +1031,6 @@ static struct nes_cm_node *make_cm_node(struct nes_cm_core *cm_core, | |||
1032 | int arpindex = 0; | 1031 | int arpindex = 0; |
1033 | struct nes_device *nesdev; | 1032 | struct nes_device *nesdev; |
1034 | struct nes_adapter *nesadapter; | 1033 | struct nes_adapter *nesadapter; |
1035 | DECLARE_MAC_BUF(mac); | ||
1036 | 1034 | ||
1037 | /* create an hte and cm_node for this instance */ | 1035 | /* create an hte and cm_node for this instance */ |
1038 | cm_node = kzalloc(sizeof(*cm_node), GFP_ATOMIC); | 1036 | cm_node = kzalloc(sizeof(*cm_node), GFP_ATOMIC); |
@@ -1045,10 +1043,9 @@ static struct nes_cm_node *make_cm_node(struct nes_cm_core *cm_core, | |||
1045 | cm_node->loc_port = cm_info->loc_port; | 1043 | cm_node->loc_port = cm_info->loc_port; |
1046 | cm_node->rem_port = cm_info->rem_port; | 1044 | cm_node->rem_port = cm_info->rem_port; |
1047 | cm_node->send_write0 = send_first; | 1045 | cm_node->send_write0 = send_first; |
1048 | nes_debug(NES_DBG_CM, "Make node addresses : loc = " NIPQUAD_FMT | 1046 | nes_debug(NES_DBG_CM, "Make node addresses : loc = %pI4:%x, rem = %pI4:%x\n", |
1049 | ":%x, rem = " NIPQUAD_FMT ":%x\n", | 1047 | &cm_node->loc_addr, cm_node->loc_port, |
1050 | HIPQUAD(cm_node->loc_addr), cm_node->loc_port, | 1048 | &cm_node->rem_addr, cm_node->rem_port); |
1051 | HIPQUAD(cm_node->rem_addr), cm_node->rem_port); | ||
1052 | cm_node->listener = listener; | 1049 | cm_node->listener = listener; |
1053 | cm_node->netdev = nesvnic->netdev; | 1050 | cm_node->netdev = nesvnic->netdev; |
1054 | cm_node->cm_id = cm_info->cm_id; | 1051 | cm_node->cm_id = cm_info->cm_id; |
@@ -1101,8 +1098,8 @@ static struct nes_cm_node *make_cm_node(struct nes_cm_core *cm_core, | |||
1101 | 1098 | ||
1102 | /* copy the mac addr to node context */ | 1099 | /* copy the mac addr to node context */ |
1103 | memcpy(cm_node->rem_mac, nesadapter->arp_table[arpindex].mac_addr, ETH_ALEN); | 1100 | memcpy(cm_node->rem_mac, nesadapter->arp_table[arpindex].mac_addr, ETH_ALEN); |
1104 | nes_debug(NES_DBG_CM, "Remote mac addr from arp table: %s\n", | 1101 | nes_debug(NES_DBG_CM, "Remote mac addr from arp table: %pM\n", |
1105 | print_mac(mac, cm_node->rem_mac)); | 1102 | cm_node->rem_mac); |
1106 | 1103 | ||
1107 | add_hte_node(cm_core, cm_node); | 1104 | add_hte_node(cm_core, cm_node); |
1108 | atomic_inc(&cm_nodes_created); | 1105 | atomic_inc(&cm_nodes_created); |
@@ -2077,10 +2074,8 @@ static int mini_cm_recv_pkt(struct nes_cm_core *cm_core, | |||
2077 | nfo.rem_addr = ntohl(iph->saddr); | 2074 | nfo.rem_addr = ntohl(iph->saddr); |
2078 | nfo.rem_port = ntohs(tcph->source); | 2075 | nfo.rem_port = ntohs(tcph->source); |
2079 | 2076 | ||
2080 | nes_debug(NES_DBG_CM, "Received packet: dest=" NIPQUAD_FMT | 2077 | nes_debug(NES_DBG_CM, "Received packet: dest=%pI4:0x%04X src=%pI4:0x%04X\n", |
2081 | ":0x%04X src=" NIPQUAD_FMT ":0x%04X\n", | 2078 | &iph->daddr, tcph->dest, &iph->saddr, tcph->source); |
2082 | NIPQUAD(iph->daddr), tcph->dest, | ||
2083 | NIPQUAD(iph->saddr), tcph->source); | ||
2084 | 2079 | ||
2085 | do { | 2080 | do { |
2086 | cm_node = find_node(cm_core, | 2081 | cm_node = find_node(cm_core, |
diff --git a/drivers/infiniband/hw/nes/nes_hw.c b/drivers/infiniband/hw/nes/nes_hw.c index 8f70ff2dcc58..5d139db1b771 100644 --- a/drivers/infiniband/hw/nes/nes_hw.c +++ b/drivers/infiniband/hw/nes/nes_hw.c | |||
@@ -2541,7 +2541,7 @@ static void nes_nic_napi_ce_handler(struct nes_device *nesdev, struct nes_hw_nic | |||
2541 | { | 2541 | { |
2542 | struct nes_vnic *nesvnic = container_of(cq, struct nes_vnic, nic_cq); | 2542 | struct nes_vnic *nesvnic = container_of(cq, struct nes_vnic, nic_cq); |
2543 | 2543 | ||
2544 | netif_rx_schedule(nesdev->netdev[nesvnic->netdev_index], &nesvnic->napi); | 2544 | netif_rx_schedule(&nesvnic->napi); |
2545 | } | 2545 | } |
2546 | 2546 | ||
2547 | 2547 | ||
diff --git a/drivers/infiniband/hw/nes/nes_nic.c b/drivers/infiniband/hw/nes/nes_nic.c index 730358637bb6..57a47cf7e513 100644 --- a/drivers/infiniband/hw/nes/nes_nic.c +++ b/drivers/infiniband/hw/nes/nes_nic.c | |||
@@ -99,7 +99,6 @@ static int nics_per_function = 1; | |||
99 | static int nes_netdev_poll(struct napi_struct *napi, int budget) | 99 | static int nes_netdev_poll(struct napi_struct *napi, int budget) |
100 | { | 100 | { |
101 | struct nes_vnic *nesvnic = container_of(napi, struct nes_vnic, napi); | 101 | struct nes_vnic *nesvnic = container_of(napi, struct nes_vnic, napi); |
102 | struct net_device *netdev = nesvnic->netdev; | ||
103 | struct nes_device *nesdev = nesvnic->nesdev; | 102 | struct nes_device *nesdev = nesvnic->nesdev; |
104 | struct nes_hw_nic_cq *nescq = &nesvnic->nic_cq; | 103 | struct nes_hw_nic_cq *nescq = &nesvnic->nic_cq; |
105 | 104 | ||
@@ -112,7 +111,7 @@ static int nes_netdev_poll(struct napi_struct *napi, int budget) | |||
112 | nes_nic_ce_handler(nesdev, nescq); | 111 | nes_nic_ce_handler(nesdev, nescq); |
113 | 112 | ||
114 | if (nescq->cqes_pending == 0) { | 113 | if (nescq->cqes_pending == 0) { |
115 | netif_rx_complete(netdev, napi); | 114 | netif_rx_complete(napi); |
116 | /* clear out completed cqes and arm */ | 115 | /* clear out completed cqes and arm */ |
117 | nes_write32(nesdev->regs+NES_CQE_ALLOC, NES_CQE_ALLOC_NOTIFY_NEXT | | 116 | nes_write32(nesdev->regs+NES_CQE_ALLOC, NES_CQE_ALLOC_NOTIFY_NEXT | |
118 | nescq->cq_number | (nescq->cqe_allocs_pending << 16)); | 117 | nescq->cq_number | (nescq->cqe_allocs_pending << 16)); |
@@ -797,14 +796,13 @@ static int nes_netdev_set_mac_address(struct net_device *netdev, void *p) | |||
797 | int i; | 796 | int i; |
798 | u32 macaddr_low; | 797 | u32 macaddr_low; |
799 | u16 macaddr_high; | 798 | u16 macaddr_high; |
800 | DECLARE_MAC_BUF(mac); | ||
801 | 799 | ||
802 | if (!is_valid_ether_addr(mac_addr->sa_data)) | 800 | if (!is_valid_ether_addr(mac_addr->sa_data)) |
803 | return -EADDRNOTAVAIL; | 801 | return -EADDRNOTAVAIL; |
804 | 802 | ||
805 | memcpy(netdev->dev_addr, mac_addr->sa_data, netdev->addr_len); | 803 | memcpy(netdev->dev_addr, mac_addr->sa_data, netdev->addr_len); |
806 | printk(PFX "%s: Address length = %d, Address = %s\n", | 804 | printk(PFX "%s: Address length = %d, Address = %pM\n", |
807 | __func__, netdev->addr_len, print_mac(mac, mac_addr->sa_data)); | 805 | __func__, netdev->addr_len, mac_addr->sa_data); |
808 | macaddr_high = ((u16)netdev->dev_addr[0]) << 8; | 806 | macaddr_high = ((u16)netdev->dev_addr[0]) << 8; |
809 | macaddr_high += (u16)netdev->dev_addr[1]; | 807 | macaddr_high += (u16)netdev->dev_addr[1]; |
810 | macaddr_low = ((u32)netdev->dev_addr[2]) << 24; | 808 | macaddr_low = ((u32)netdev->dev_addr[2]) << 24; |
@@ -909,9 +907,8 @@ static void nes_netdev_set_multicast_list(struct net_device *netdev) | |||
909 | if (mc_index >= max_pft_entries_avaiable) | 907 | if (mc_index >= max_pft_entries_avaiable) |
910 | break; | 908 | break; |
911 | if (multicast_addr) { | 909 | if (multicast_addr) { |
912 | DECLARE_MAC_BUF(mac); | 910 | nes_debug(NES_DBG_NIC_RX, "Assigning MC Address %pM to register 0x%04X nic_idx=%d\n", |
913 | nes_debug(NES_DBG_NIC_RX, "Assigning MC Address %s to register 0x%04X nic_idx=%d\n", | 911 | multicast_addr->dmi_addr, |
914 | print_mac(mac, multicast_addr->dmi_addr), | ||
915 | perfect_filter_register_address+(mc_index * 8), | 912 | perfect_filter_register_address+(mc_index * 8), |
916 | mc_nic_index); | 913 | mc_nic_index); |
917 | macaddr_high = ((u16)multicast_addr->dmi_addr[0]) << 8; | 914 | macaddr_high = ((u16)multicast_addr->dmi_addr[0]) << 8; |
diff --git a/drivers/infiniband/hw/nes/nes_utils.c b/drivers/infiniband/hw/nes/nes_utils.c index 5611a73d5831..aa9b7348c728 100644 --- a/drivers/infiniband/hw/nes/nes_utils.c +++ b/drivers/infiniband/hw/nes/nes_utils.c | |||
@@ -682,9 +682,8 @@ int nes_arp_table(struct nes_device *nesdev, u32 ip_addr, u8 *mac_addr, u32 acti | |||
682 | 682 | ||
683 | /* DELETE or RESOLVE */ | 683 | /* DELETE or RESOLVE */ |
684 | if (arp_index == nesadapter->arp_table_size) { | 684 | if (arp_index == nesadapter->arp_table_size) { |
685 | nes_debug(NES_DBG_NETDEV, "MAC for " NIPQUAD_FMT " not in ARP table - cannot %s\n", | 685 | nes_debug(NES_DBG_NETDEV, "MAC for %pI4 not in ARP table - cannot %s\n", |
686 | HIPQUAD(ip_addr), | 686 | &ip_addr, action == NES_ARP_RESOLVE ? "resolve" : "delete"); |
687 | action == NES_ARP_RESOLVE ? "resolve" : "delete"); | ||
688 | return -1; | 687 | return -1; |
689 | } | 688 | } |
690 | 689 | ||
diff --git a/drivers/infiniband/ulp/ipoib/ipoib.h b/drivers/infiniband/ulp/ipoib/ipoib.h index e0c7dfabf2b4..753a983a5fdc 100644 --- a/drivers/infiniband/ulp/ipoib/ipoib.h +++ b/drivers/infiniband/ulp/ipoib/ipoib.h | |||
@@ -732,29 +732,6 @@ extern int ipoib_debug_level; | |||
732 | do { (void) (priv); } while (0) | 732 | do { (void) (priv); } while (0) |
733 | #endif /* CONFIG_INFINIBAND_IPOIB_DEBUG_DATA */ | 733 | #endif /* CONFIG_INFINIBAND_IPOIB_DEBUG_DATA */ |
734 | 734 | ||
735 | |||
736 | #define IPOIB_GID_FMT "%2.2x%2.2x:%2.2x%2.2x:%2.2x%2.2x:%2.2x%2.2x:" \ | ||
737 | "%2.2x%2.2x:%2.2x%2.2x:%2.2x%2.2x:%2.2x%2.2x" | ||
738 | |||
739 | #define IPOIB_GID_RAW_ARG(gid) ((u8 *)(gid))[0], \ | ||
740 | ((u8 *)(gid))[1], \ | ||
741 | ((u8 *)(gid))[2], \ | ||
742 | ((u8 *)(gid))[3], \ | ||
743 | ((u8 *)(gid))[4], \ | ||
744 | ((u8 *)(gid))[5], \ | ||
745 | ((u8 *)(gid))[6], \ | ||
746 | ((u8 *)(gid))[7], \ | ||
747 | ((u8 *)(gid))[8], \ | ||
748 | ((u8 *)(gid))[9], \ | ||
749 | ((u8 *)(gid))[10],\ | ||
750 | ((u8 *)(gid))[11],\ | ||
751 | ((u8 *)(gid))[12],\ | ||
752 | ((u8 *)(gid))[13],\ | ||
753 | ((u8 *)(gid))[14],\ | ||
754 | ((u8 *)(gid))[15] | ||
755 | |||
756 | #define IPOIB_GID_ARG(gid) IPOIB_GID_RAW_ARG((gid).raw) | ||
757 | |||
758 | #define IPOIB_QPN(ha) (be32_to_cpup((__be32 *) ha) & 0xffffff) | 735 | #define IPOIB_QPN(ha) (be32_to_cpup((__be32 *) ha) & 0xffffff) |
759 | 736 | ||
760 | #endif /* _IPOIB_H */ | 737 | #endif /* _IPOIB_H */ |
diff --git a/drivers/infiniband/ulp/ipoib/ipoib_cm.c b/drivers/infiniband/ulp/ipoib/ipoib_cm.c index 7b14c2c39500..47d588ba2a7f 100644 --- a/drivers/infiniband/ulp/ipoib/ipoib_cm.c +++ b/drivers/infiniband/ulp/ipoib/ipoib_cm.c | |||
@@ -1128,8 +1128,8 @@ static int ipoib_cm_tx_init(struct ipoib_cm_tx *p, u32 qpn, | |||
1128 | goto err_send_cm; | 1128 | goto err_send_cm; |
1129 | } | 1129 | } |
1130 | 1130 | ||
1131 | ipoib_dbg(priv, "Request connection 0x%x for gid " IPOIB_GID_FMT " qpn 0x%x\n", | 1131 | ipoib_dbg(priv, "Request connection 0x%x for gid %pI6 qpn 0x%x\n", |
1132 | p->qp->qp_num, IPOIB_GID_ARG(pathrec->dgid), qpn); | 1132 | p->qp->qp_num, pathrec->dgid.raw, qpn); |
1133 | 1133 | ||
1134 | return 0; | 1134 | return 0; |
1135 | 1135 | ||
@@ -1276,8 +1276,8 @@ void ipoib_cm_destroy_tx(struct ipoib_cm_tx *tx) | |||
1276 | if (test_and_clear_bit(IPOIB_FLAG_INITIALIZED, &tx->flags)) { | 1276 | if (test_and_clear_bit(IPOIB_FLAG_INITIALIZED, &tx->flags)) { |
1277 | list_move(&tx->list, &priv->cm.reap_list); | 1277 | list_move(&tx->list, &priv->cm.reap_list); |
1278 | queue_work(ipoib_workqueue, &priv->cm.reap_task); | 1278 | queue_work(ipoib_workqueue, &priv->cm.reap_task); |
1279 | ipoib_dbg(priv, "Reap connection for gid " IPOIB_GID_FMT "\n", | 1279 | ipoib_dbg(priv, "Reap connection for gid %pI6\n", |
1280 | IPOIB_GID_ARG(tx->neigh->dgid)); | 1280 | tx->neigh->dgid.raw); |
1281 | tx->neigh = NULL; | 1281 | tx->neigh = NULL; |
1282 | } | 1282 | } |
1283 | } | 1283 | } |
diff --git a/drivers/infiniband/ulp/ipoib/ipoib_ib.c b/drivers/infiniband/ulp/ipoib/ipoib_ib.c index 28eb6f03c588..a1925810be3c 100644 --- a/drivers/infiniband/ulp/ipoib/ipoib_ib.c +++ b/drivers/infiniband/ulp/ipoib/ipoib_ib.c | |||
@@ -446,11 +446,11 @@ poll_more: | |||
446 | if (dev->features & NETIF_F_LRO) | 446 | if (dev->features & NETIF_F_LRO) |
447 | lro_flush_all(&priv->lro.lro_mgr); | 447 | lro_flush_all(&priv->lro.lro_mgr); |
448 | 448 | ||
449 | netif_rx_complete(dev, napi); | 449 | netif_rx_complete(napi); |
450 | if (unlikely(ib_req_notify_cq(priv->recv_cq, | 450 | if (unlikely(ib_req_notify_cq(priv->recv_cq, |
451 | IB_CQ_NEXT_COMP | | 451 | IB_CQ_NEXT_COMP | |
452 | IB_CQ_REPORT_MISSED_EVENTS)) && | 452 | IB_CQ_REPORT_MISSED_EVENTS)) && |
453 | netif_rx_reschedule(dev, napi)) | 453 | netif_rx_reschedule(napi)) |
454 | goto poll_more; | 454 | goto poll_more; |
455 | } | 455 | } |
456 | 456 | ||
@@ -462,7 +462,7 @@ void ipoib_ib_completion(struct ib_cq *cq, void *dev_ptr) | |||
462 | struct net_device *dev = dev_ptr; | 462 | struct net_device *dev = dev_ptr; |
463 | struct ipoib_dev_priv *priv = netdev_priv(dev); | 463 | struct ipoib_dev_priv *priv = netdev_priv(dev); |
464 | 464 | ||
465 | netif_rx_schedule(dev, &priv->napi); | 465 | netif_rx_schedule(&priv->napi); |
466 | } | 466 | } |
467 | 467 | ||
468 | static void drain_tx_cq(struct net_device *dev) | 468 | static void drain_tx_cq(struct net_device *dev) |
diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c b/drivers/infiniband/ulp/ipoib/ipoib_main.c index 85257f6b9576..19e06bc38b39 100644 --- a/drivers/infiniband/ulp/ipoib/ipoib_main.c +++ b/drivers/infiniband/ulp/ipoib/ipoib_main.c | |||
@@ -360,9 +360,9 @@ void ipoib_mark_paths_invalid(struct net_device *dev) | |||
360 | spin_lock_irq(&priv->lock); | 360 | spin_lock_irq(&priv->lock); |
361 | 361 | ||
362 | list_for_each_entry_safe(path, tp, &priv->path_list, list) { | 362 | list_for_each_entry_safe(path, tp, &priv->path_list, list) { |
363 | ipoib_dbg(priv, "mark path LID 0x%04x GID " IPOIB_GID_FMT " invalid\n", | 363 | ipoib_dbg(priv, "mark path LID 0x%04x GID %pI6 invalid\n", |
364 | be16_to_cpu(path->pathrec.dlid), | 364 | be16_to_cpu(path->pathrec.dlid), |
365 | IPOIB_GID_ARG(path->pathrec.dgid)); | 365 | path->pathrec.dgid.raw); |
366 | path->valid = 0; | 366 | path->valid = 0; |
367 | } | 367 | } |
368 | 368 | ||
@@ -414,11 +414,11 @@ static void path_rec_completion(int status, | |||
414 | unsigned long flags; | 414 | unsigned long flags; |
415 | 415 | ||
416 | if (!status) | 416 | if (!status) |
417 | ipoib_dbg(priv, "PathRec LID 0x%04x for GID " IPOIB_GID_FMT "\n", | 417 | ipoib_dbg(priv, "PathRec LID 0x%04x for GID %pI6\n", |
418 | be16_to_cpu(pathrec->dlid), IPOIB_GID_ARG(pathrec->dgid)); | 418 | be16_to_cpu(pathrec->dlid), pathrec->dgid.raw); |
419 | else | 419 | else |
420 | ipoib_dbg(priv, "PathRec status %d for GID " IPOIB_GID_FMT "\n", | 420 | ipoib_dbg(priv, "PathRec status %d for GID %pI6\n", |
421 | status, IPOIB_GID_ARG(path->pathrec.dgid)); | 421 | status, path->pathrec.dgid.raw); |
422 | 422 | ||
423 | skb_queue_head_init(&skqueue); | 423 | skb_queue_head_init(&skqueue); |
424 | 424 | ||
@@ -528,8 +528,8 @@ static int path_rec_start(struct net_device *dev, | |||
528 | { | 528 | { |
529 | struct ipoib_dev_priv *priv = netdev_priv(dev); | 529 | struct ipoib_dev_priv *priv = netdev_priv(dev); |
530 | 530 | ||
531 | ipoib_dbg(priv, "Start path record lookup for " IPOIB_GID_FMT "\n", | 531 | ipoib_dbg(priv, "Start path record lookup for %pI6\n", |
532 | IPOIB_GID_ARG(path->pathrec.dgid)); | 532 | path->pathrec.dgid.raw); |
533 | 533 | ||
534 | init_completion(&path->done); | 534 | init_completion(&path->done); |
535 | 535 | ||
@@ -766,12 +766,11 @@ static int ipoib_start_xmit(struct sk_buff *skb, struct net_device *dev) | |||
766 | 766 | ||
767 | if ((be16_to_cpup((__be16 *) skb->data) != ETH_P_ARP) && | 767 | if ((be16_to_cpup((__be16 *) skb->data) != ETH_P_ARP) && |
768 | (be16_to_cpup((__be16 *) skb->data) != ETH_P_RARP)) { | 768 | (be16_to_cpup((__be16 *) skb->data) != ETH_P_RARP)) { |
769 | ipoib_warn(priv, "Unicast, no %s: type %04x, QPN %06x " | 769 | ipoib_warn(priv, "Unicast, no %s: type %04x, QPN %06x %pI6\n", |
770 | IPOIB_GID_FMT "\n", | ||
771 | skb->dst ? "neigh" : "dst", | 770 | skb->dst ? "neigh" : "dst", |
772 | be16_to_cpup((__be16 *) skb->data), | 771 | be16_to_cpup((__be16 *) skb->data), |
773 | IPOIB_QPN(phdr->hwaddr), | 772 | IPOIB_QPN(phdr->hwaddr), |
774 | IPOIB_GID_RAW_ARG(phdr->hwaddr + 4)); | 773 | phdr->hwaddr + 4); |
775 | dev_kfree_skb_any(skb); | 774 | dev_kfree_skb_any(skb); |
776 | ++dev->stats.tx_dropped; | 775 | ++dev->stats.tx_dropped; |
777 | return NETDEV_TX_OK; | 776 | return NETDEV_TX_OK; |
@@ -847,9 +846,9 @@ static void ipoib_neigh_cleanup(struct neighbour *n) | |||
847 | else | 846 | else |
848 | return; | 847 | return; |
849 | ipoib_dbg(priv, | 848 | ipoib_dbg(priv, |
850 | "neigh_cleanup for %06x " IPOIB_GID_FMT "\n", | 849 | "neigh_cleanup for %06x %pI6\n", |
851 | IPOIB_QPN(n->ha), | 850 | IPOIB_QPN(n->ha), |
852 | IPOIB_GID_RAW_ARG(n->ha + 4)); | 851 | n->ha + 4); |
853 | 852 | ||
854 | spin_lock_irqsave(&priv->lock, flags); | 853 | spin_lock_irqsave(&priv->lock, flags); |
855 | 854 | ||
diff --git a/drivers/infiniband/ulp/ipoib/ipoib_multicast.c b/drivers/infiniband/ulp/ipoib/ipoib_multicast.c index d9d1223c3fd5..a2eb3b9789eb 100644 --- a/drivers/infiniband/ulp/ipoib/ipoib_multicast.c +++ b/drivers/infiniband/ulp/ipoib/ipoib_multicast.c | |||
@@ -71,9 +71,8 @@ static void ipoib_mcast_free(struct ipoib_mcast *mcast) | |||
71 | struct ipoib_neigh *neigh, *tmp; | 71 | struct ipoib_neigh *neigh, *tmp; |
72 | int tx_dropped = 0; | 72 | int tx_dropped = 0; |
73 | 73 | ||
74 | ipoib_dbg_mcast(netdev_priv(dev), | 74 | ipoib_dbg_mcast(netdev_priv(dev), "deleting multicast group %pI6\n", |
75 | "deleting multicast group " IPOIB_GID_FMT "\n", | 75 | mcast->mcmember.mgid.raw); |
76 | IPOIB_GID_ARG(mcast->mcmember.mgid)); | ||
77 | 76 | ||
78 | spin_lock_irq(&priv->lock); | 77 | spin_lock_irq(&priv->lock); |
79 | 78 | ||
@@ -205,9 +204,8 @@ static int ipoib_mcast_join_finish(struct ipoib_mcast *mcast, | |||
205 | 204 | ||
206 | if (!test_bit(IPOIB_MCAST_FLAG_SENDONLY, &mcast->flags)) { | 205 | if (!test_bit(IPOIB_MCAST_FLAG_SENDONLY, &mcast->flags)) { |
207 | if (test_and_set_bit(IPOIB_MCAST_FLAG_ATTACHED, &mcast->flags)) { | 206 | if (test_and_set_bit(IPOIB_MCAST_FLAG_ATTACHED, &mcast->flags)) { |
208 | ipoib_warn(priv, "multicast group " IPOIB_GID_FMT | 207 | ipoib_warn(priv, "multicast group %pI6 already attached\n", |
209 | " already attached\n", | 208 | mcast->mcmember.mgid.raw); |
210 | IPOIB_GID_ARG(mcast->mcmember.mgid)); | ||
211 | 209 | ||
212 | return 0; | 210 | return 0; |
213 | } | 211 | } |
@@ -215,9 +213,8 @@ static int ipoib_mcast_join_finish(struct ipoib_mcast *mcast, | |||
215 | ret = ipoib_mcast_attach(dev, be16_to_cpu(mcast->mcmember.mlid), | 213 | ret = ipoib_mcast_attach(dev, be16_to_cpu(mcast->mcmember.mlid), |
216 | &mcast->mcmember.mgid, set_qkey); | 214 | &mcast->mcmember.mgid, set_qkey); |
217 | if (ret < 0) { | 215 | if (ret < 0) { |
218 | ipoib_warn(priv, "couldn't attach QP to multicast group " | 216 | ipoib_warn(priv, "couldn't attach QP to multicast group %pI6\n", |
219 | IPOIB_GID_FMT "\n", | 217 | mcast->mcmember.mgid.raw); |
220 | IPOIB_GID_ARG(mcast->mcmember.mgid)); | ||
221 | 218 | ||
222 | clear_bit(IPOIB_MCAST_FLAG_ATTACHED, &mcast->flags); | 219 | clear_bit(IPOIB_MCAST_FLAG_ATTACHED, &mcast->flags); |
223 | return ret; | 220 | return ret; |
@@ -248,9 +245,8 @@ static int ipoib_mcast_join_finish(struct ipoib_mcast *mcast, | |||
248 | mcast->ah = ah; | 245 | mcast->ah = ah; |
249 | spin_unlock_irq(&priv->lock); | 246 | spin_unlock_irq(&priv->lock); |
250 | 247 | ||
251 | ipoib_dbg_mcast(priv, "MGID " IPOIB_GID_FMT | 248 | ipoib_dbg_mcast(priv, "MGID %pI6 AV %p, LID 0x%04x, SL %d\n", |
252 | " AV %p, LID 0x%04x, SL %d\n", | 249 | mcast->mcmember.mgid.raw, |
253 | IPOIB_GID_ARG(mcast->mcmember.mgid), | ||
254 | mcast->ah->ah, | 250 | mcast->ah->ah, |
255 | be16_to_cpu(mcast->mcmember.mlid), | 251 | be16_to_cpu(mcast->mcmember.mlid), |
256 | mcast->mcmember.sl); | 252 | mcast->mcmember.sl); |
@@ -295,9 +291,8 @@ ipoib_mcast_sendonly_join_complete(int status, | |||
295 | 291 | ||
296 | if (status) { | 292 | if (status) { |
297 | if (mcast->logcount++ < 20) | 293 | if (mcast->logcount++ < 20) |
298 | ipoib_dbg_mcast(netdev_priv(dev), "multicast join failed for " | 294 | ipoib_dbg_mcast(netdev_priv(dev), "multicast join failed for %pI6, status %d\n", |
299 | IPOIB_GID_FMT ", status %d\n", | 295 | mcast->mcmember.mgid.raw, status); |
300 | IPOIB_GID_ARG(mcast->mcmember.mgid), status); | ||
301 | 296 | ||
302 | /* Flush out any queued packets */ | 297 | /* Flush out any queued packets */ |
303 | netif_tx_lock_bh(dev); | 298 | netif_tx_lock_bh(dev); |
@@ -356,9 +351,8 @@ static int ipoib_mcast_sendonly_join(struct ipoib_mcast *mcast) | |||
356 | ipoib_warn(priv, "ib_sa_join_multicast failed (ret = %d)\n", | 351 | ipoib_warn(priv, "ib_sa_join_multicast failed (ret = %d)\n", |
357 | ret); | 352 | ret); |
358 | } else { | 353 | } else { |
359 | ipoib_dbg_mcast(priv, "no multicast record for " IPOIB_GID_FMT | 354 | ipoib_dbg_mcast(priv, "no multicast record for %pI6, starting join\n", |
360 | ", starting join\n", | 355 | mcast->mcmember.mgid.raw); |
361 | IPOIB_GID_ARG(mcast->mcmember.mgid)); | ||
362 | } | 356 | } |
363 | 357 | ||
364 | return ret; | 358 | return ret; |
@@ -386,9 +380,8 @@ static int ipoib_mcast_join_complete(int status, | |||
386 | struct net_device *dev = mcast->dev; | 380 | struct net_device *dev = mcast->dev; |
387 | struct ipoib_dev_priv *priv = netdev_priv(dev); | 381 | struct ipoib_dev_priv *priv = netdev_priv(dev); |
388 | 382 | ||
389 | ipoib_dbg_mcast(priv, "join completion for " IPOIB_GID_FMT | 383 | ipoib_dbg_mcast(priv, "join completion for %pI6 (status %d)\n", |
390 | " (status %d)\n", | 384 | mcast->mcmember.mgid.raw, status); |
391 | IPOIB_GID_ARG(mcast->mcmember.mgid), status); | ||
392 | 385 | ||
393 | /* We trap for port events ourselves. */ | 386 | /* We trap for port events ourselves. */ |
394 | if (status == -ENETRESET) | 387 | if (status == -ENETRESET) |
@@ -417,15 +410,11 @@ static int ipoib_mcast_join_complete(int status, | |||
417 | 410 | ||
418 | if (mcast->logcount++ < 20) { | 411 | if (mcast->logcount++ < 20) { |
419 | if (status == -ETIMEDOUT) { | 412 | if (status == -ETIMEDOUT) { |
420 | ipoib_dbg_mcast(priv, "multicast join failed for " IPOIB_GID_FMT | 413 | ipoib_dbg_mcast(priv, "multicast join failed for %pI6, status %d\n", |
421 | ", status %d\n", | 414 | mcast->mcmember.mgid.raw, status); |
422 | IPOIB_GID_ARG(mcast->mcmember.mgid), | ||
423 | status); | ||
424 | } else { | 415 | } else { |
425 | ipoib_warn(priv, "multicast join failed for " | 416 | ipoib_warn(priv, "multicast join failed for %pI6, status %d\n", |
426 | IPOIB_GID_FMT ", status %d\n", | 417 | mcast->mcmember.mgid.raw, status); |
427 | IPOIB_GID_ARG(mcast->mcmember.mgid), | ||
428 | status); | ||
429 | } | 418 | } |
430 | } | 419 | } |
431 | 420 | ||
@@ -457,8 +446,7 @@ static void ipoib_mcast_join(struct net_device *dev, struct ipoib_mcast *mcast, | |||
457 | ib_sa_comp_mask comp_mask; | 446 | ib_sa_comp_mask comp_mask; |
458 | int ret = 0; | 447 | int ret = 0; |
459 | 448 | ||
460 | ipoib_dbg_mcast(priv, "joining MGID " IPOIB_GID_FMT "\n", | 449 | ipoib_dbg_mcast(priv, "joining MGID %pI6\n", mcast->mcmember.mgid.raw); |
461 | IPOIB_GID_ARG(mcast->mcmember.mgid)); | ||
462 | 450 | ||
463 | rec.mgid = mcast->mcmember.mgid; | 451 | rec.mgid = mcast->mcmember.mgid; |
464 | rec.port_gid = priv->local_gid; | 452 | rec.port_gid = priv->local_gid; |
@@ -643,8 +631,8 @@ static int ipoib_mcast_leave(struct net_device *dev, struct ipoib_mcast *mcast) | |||
643 | ib_sa_free_multicast(mcast->mc); | 631 | ib_sa_free_multicast(mcast->mc); |
644 | 632 | ||
645 | if (test_and_clear_bit(IPOIB_MCAST_FLAG_ATTACHED, &mcast->flags)) { | 633 | if (test_and_clear_bit(IPOIB_MCAST_FLAG_ATTACHED, &mcast->flags)) { |
646 | ipoib_dbg_mcast(priv, "leaving MGID " IPOIB_GID_FMT "\n", | 634 | ipoib_dbg_mcast(priv, "leaving MGID %pI6\n", |
647 | IPOIB_GID_ARG(mcast->mcmember.mgid)); | 635 | mcast->mcmember.mgid.raw); |
648 | 636 | ||
649 | /* Remove ourselves from the multicast group */ | 637 | /* Remove ourselves from the multicast group */ |
650 | ret = ib_detach_mcast(priv->qp, &mcast->mcmember.mgid, | 638 | ret = ib_detach_mcast(priv->qp, &mcast->mcmember.mgid, |
@@ -675,8 +663,8 @@ void ipoib_mcast_send(struct net_device *dev, void *mgid, struct sk_buff *skb) | |||
675 | mcast = __ipoib_mcast_find(dev, mgid); | 663 | mcast = __ipoib_mcast_find(dev, mgid); |
676 | if (!mcast) { | 664 | if (!mcast) { |
677 | /* Let's create a new send only group now */ | 665 | /* Let's create a new send only group now */ |
678 | ipoib_dbg_mcast(priv, "setting up send only multicast group for " | 666 | ipoib_dbg_mcast(priv, "setting up send only multicast group for %pI6\n", |
679 | IPOIB_GID_FMT "\n", IPOIB_GID_RAW_ARG(mgid)); | 667 | mgid); |
680 | 668 | ||
681 | mcast = ipoib_mcast_alloc(dev, 0); | 669 | mcast = ipoib_mcast_alloc(dev, 0); |
682 | if (!mcast) { | 670 | if (!mcast) { |
@@ -809,14 +797,14 @@ void ipoib_mcast_restart_task(struct work_struct *work) | |||
809 | /* ignore group which is directly joined by userspace */ | 797 | /* ignore group which is directly joined by userspace */ |
810 | if (test_bit(IPOIB_FLAG_UMCAST, &priv->flags) && | 798 | if (test_bit(IPOIB_FLAG_UMCAST, &priv->flags) && |
811 | !ib_sa_get_mcmember_rec(priv->ca, priv->port, &mgid, &rec)) { | 799 | !ib_sa_get_mcmember_rec(priv->ca, priv->port, &mgid, &rec)) { |
812 | ipoib_dbg_mcast(priv, "ignoring multicast entry for mgid " | 800 | ipoib_dbg_mcast(priv, "ignoring multicast entry for mgid %pI6\n", |
813 | IPOIB_GID_FMT "\n", IPOIB_GID_ARG(mgid)); | 801 | mgid.raw); |
814 | continue; | 802 | continue; |
815 | } | 803 | } |
816 | 804 | ||
817 | /* Not found or send-only group, let's add a new entry */ | 805 | /* Not found or send-only group, let's add a new entry */ |
818 | ipoib_dbg_mcast(priv, "adding multicast entry for mgid " | 806 | ipoib_dbg_mcast(priv, "adding multicast entry for mgid %pI6\n", |
819 | IPOIB_GID_FMT "\n", IPOIB_GID_ARG(mgid)); | 807 | mgid.raw); |
820 | 808 | ||
821 | nmcast = ipoib_mcast_alloc(dev, 0); | 809 | nmcast = ipoib_mcast_alloc(dev, 0); |
822 | if (!nmcast) { | 810 | if (!nmcast) { |
@@ -849,8 +837,8 @@ void ipoib_mcast_restart_task(struct work_struct *work) | |||
849 | list_for_each_entry_safe(mcast, tmcast, &priv->multicast_list, list) { | 837 | list_for_each_entry_safe(mcast, tmcast, &priv->multicast_list, list) { |
850 | if (!test_bit(IPOIB_MCAST_FLAG_FOUND, &mcast->flags) && | 838 | if (!test_bit(IPOIB_MCAST_FLAG_FOUND, &mcast->flags) && |
851 | !test_bit(IPOIB_MCAST_FLAG_SENDONLY, &mcast->flags)) { | 839 | !test_bit(IPOIB_MCAST_FLAG_SENDONLY, &mcast->flags)) { |
852 | ipoib_dbg_mcast(priv, "deleting multicast group " IPOIB_GID_FMT "\n", | 840 | ipoib_dbg_mcast(priv, "deleting multicast group %pI6\n", |
853 | IPOIB_GID_ARG(mcast->mcmember.mgid)); | 841 | mcast->mcmember.mgid.raw); |
854 | 842 | ||
855 | rb_erase(&mcast->rb_node, &priv->multicast_tree); | 843 | rb_erase(&mcast->rb_node, &priv->multicast_tree); |
856 | 844 | ||
diff --git a/drivers/infiniband/ulp/iser/iser_verbs.c b/drivers/infiniband/ulp/iser/iser_verbs.c index 6dc6b174cdd4..319b188145be 100644 --- a/drivers/infiniband/ulp/iser/iser_verbs.c +++ b/drivers/infiniband/ulp/iser/iser_verbs.c | |||
@@ -516,14 +516,14 @@ int iser_connect(struct iser_conn *ib_conn, | |||
516 | struct sockaddr *src, *dst; | 516 | struct sockaddr *src, *dst; |
517 | int err = 0; | 517 | int err = 0; |
518 | 518 | ||
519 | sprintf(ib_conn->name,"%d.%d.%d.%d:%d", | 519 | sprintf(ib_conn->name, "%pI4:%d", |
520 | NIPQUAD(dst_addr->sin_addr.s_addr), dst_addr->sin_port); | 520 | &dst_addr->sin_addr.s_addr, dst_addr->sin_port); |
521 | 521 | ||
522 | /* the device is known only --after-- address resolution */ | 522 | /* the device is known only --after-- address resolution */ |
523 | ib_conn->device = NULL; | 523 | ib_conn->device = NULL; |
524 | 524 | ||
525 | iser_err("connecting to: %d.%d.%d.%d, port 0x%x\n", | 525 | iser_err("connecting to: %pI4, port 0x%x\n", |
526 | NIPQUAD(dst_addr->sin_addr), dst_addr->sin_port); | 526 | &dst_addr->sin_addr, dst_addr->sin_port); |
527 | 527 | ||
528 | ib_conn->state = ISER_CONN_PENDING; | 528 | ib_conn->state = ISER_CONN_PENDING; |
529 | 529 | ||
diff --git a/drivers/infiniband/ulp/srp/ib_srp.c b/drivers/infiniband/ulp/srp/ib_srp.c index 5b8b533f2908..7c13db885bf6 100644 --- a/drivers/infiniband/ulp/srp/ib_srp.c +++ b/drivers/infiniband/ulp/srp/ib_srp.c | |||
@@ -1514,15 +1514,7 @@ static ssize_t show_dgid(struct device *dev, struct device_attribute *attr, | |||
1514 | target->state == SRP_TARGET_REMOVED) | 1514 | target->state == SRP_TARGET_REMOVED) |
1515 | return -ENODEV; | 1515 | return -ENODEV; |
1516 | 1516 | ||
1517 | return sprintf(buf, "%04x:%04x:%04x:%04x:%04x:%04x:%04x:%04x\n", | 1517 | return sprintf(buf, "%pI6\n", target->path.dgid.raw); |
1518 | be16_to_cpu(((__be16 *) target->path.dgid.raw)[0]), | ||
1519 | be16_to_cpu(((__be16 *) target->path.dgid.raw)[1]), | ||
1520 | be16_to_cpu(((__be16 *) target->path.dgid.raw)[2]), | ||
1521 | be16_to_cpu(((__be16 *) target->path.dgid.raw)[3]), | ||
1522 | be16_to_cpu(((__be16 *) target->path.dgid.raw)[4]), | ||
1523 | be16_to_cpu(((__be16 *) target->path.dgid.raw)[5]), | ||
1524 | be16_to_cpu(((__be16 *) target->path.dgid.raw)[6]), | ||
1525 | be16_to_cpu(((__be16 *) target->path.dgid.raw)[7])); | ||
1526 | } | 1518 | } |
1527 | 1519 | ||
1528 | static ssize_t show_orig_dgid(struct device *dev, | 1520 | static ssize_t show_orig_dgid(struct device *dev, |
@@ -1534,15 +1526,7 @@ static ssize_t show_orig_dgid(struct device *dev, | |||
1534 | target->state == SRP_TARGET_REMOVED) | 1526 | target->state == SRP_TARGET_REMOVED) |
1535 | return -ENODEV; | 1527 | return -ENODEV; |
1536 | 1528 | ||
1537 | return sprintf(buf, "%04x:%04x:%04x:%04x:%04x:%04x:%04x:%04x\n", | 1529 | return sprintf(buf, "%pI6\n", target->orig_dgid); |
1538 | be16_to_cpu(target->orig_dgid[0]), | ||
1539 | be16_to_cpu(target->orig_dgid[1]), | ||
1540 | be16_to_cpu(target->orig_dgid[2]), | ||
1541 | be16_to_cpu(target->orig_dgid[3]), | ||
1542 | be16_to_cpu(target->orig_dgid[4]), | ||
1543 | be16_to_cpu(target->orig_dgid[5]), | ||
1544 | be16_to_cpu(target->orig_dgid[6]), | ||
1545 | be16_to_cpu(target->orig_dgid[7])); | ||
1546 | } | 1530 | } |
1547 | 1531 | ||
1548 | static ssize_t show_zero_req_lim(struct device *dev, | 1532 | static ssize_t show_zero_req_lim(struct device *dev, |
@@ -1883,19 +1867,12 @@ static ssize_t srp_create_target(struct device *dev, | |||
1883 | 1867 | ||
1884 | shost_printk(KERN_DEBUG, target->scsi_host, PFX | 1868 | shost_printk(KERN_DEBUG, target->scsi_host, PFX |
1885 | "new target: id_ext %016llx ioc_guid %016llx pkey %04x " | 1869 | "new target: id_ext %016llx ioc_guid %016llx pkey %04x " |
1886 | "service_id %016llx dgid %04x:%04x:%04x:%04x:%04x:%04x:%04x:%04x\n", | 1870 | "service_id %016llx dgid %pI6\n", |
1887 | (unsigned long long) be64_to_cpu(target->id_ext), | 1871 | (unsigned long long) be64_to_cpu(target->id_ext), |
1888 | (unsigned long long) be64_to_cpu(target->ioc_guid), | 1872 | (unsigned long long) be64_to_cpu(target->ioc_guid), |
1889 | be16_to_cpu(target->path.pkey), | 1873 | be16_to_cpu(target->path.pkey), |
1890 | (unsigned long long) be64_to_cpu(target->service_id), | 1874 | (unsigned long long) be64_to_cpu(target->service_id), |
1891 | (int) be16_to_cpu(*(__be16 *) &target->path.dgid.raw[0]), | 1875 | target->path.dgid.raw); |
1892 | (int) be16_to_cpu(*(__be16 *) &target->path.dgid.raw[2]), | ||
1893 | (int) be16_to_cpu(*(__be16 *) &target->path.dgid.raw[4]), | ||
1894 | (int) be16_to_cpu(*(__be16 *) &target->path.dgid.raw[6]), | ||
1895 | (int) be16_to_cpu(*(__be16 *) &target->path.dgid.raw[8]), | ||
1896 | (int) be16_to_cpu(*(__be16 *) &target->path.dgid.raw[10]), | ||
1897 | (int) be16_to_cpu(*(__be16 *) &target->path.dgid.raw[12]), | ||
1898 | (int) be16_to_cpu(*(__be16 *) &target->path.dgid.raw[14])); | ||
1899 | 1876 | ||
1900 | ret = srp_create_target_ib(target); | 1877 | ret = srp_create_target_ib(target); |
1901 | if (ret) | 1878 | if (ret) |