aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/infiniband
diff options
context:
space:
mode:
authorAlexander Schmidt <alexs@linux.vnet.ibm.com>2008-08-12 09:46:27 -0400
committerRoland Dreier <rolandd@cisco.com>2008-08-12 14:34:59 -0400
commit129a10fb81309f455eeb444560ec38657d29c46f (patch)
tree544d44f33452e74b86a0869d5d5c64a503ba872b /drivers/infiniband
parent17c2b53adbf1ebd7a8b6a63e2597199676426dbf (diff)
IB/ehca: Check idr_find() return value
The idr_find() function may fail when trying to get the QP that is associated with a CQE, e.g. when a QP has been destroyed between the generation of a CQE and the poll request for it. In consequence, the return value of idr_find() must be checked and the CQE must be discarded when the QP cannot be found. Signed-off-by: Alexander Schmidt <alexs@linux.vnet.ibm.com> Signed-off-by: Roland Dreier <rolandd@cisco.com>
Diffstat (limited to 'drivers/infiniband')
-rw-r--r--drivers/infiniband/hw/ehca/ehca_reqs.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/infiniband/hw/ehca/ehca_reqs.c b/drivers/infiniband/hw/ehca/ehca_reqs.c
index acb8649151e0..cea3eba9c83e 100644
--- a/drivers/infiniband/hw/ehca/ehca_reqs.c
+++ b/drivers/infiniband/hw/ehca/ehca_reqs.c
@@ -680,8 +680,10 @@ repoll:
680 680
681 read_lock(&ehca_qp_idr_lock); 681 read_lock(&ehca_qp_idr_lock);
682 my_qp = idr_find(&ehca_qp_idr, cqe->qp_token); 682 my_qp = idr_find(&ehca_qp_idr, cqe->qp_token);
683 wc->qp = &my_qp->ib_qp;
684 read_unlock(&ehca_qp_idr_lock); 683 read_unlock(&ehca_qp_idr_lock);
684 if (!my_qp)
685 goto repoll;
686 wc->qp = &my_qp->ib_qp;
685 687
686 wc->byte_len = cqe->nr_bytes_transferred; 688 wc->byte_len = cqe->nr_bytes_transferred;
687 wc->pkey_index = cqe->pkey_index; 689 wc->pkey_index = cqe->pkey_index;