diff options
author | Bernhard Fischer <berny.f@aon.at> | 2005-06-27 17:36:39 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@ppc970.osdl.org> | 2005-06-27 18:11:44 -0400 |
commit | 177214af2946e86ce89324f379720ec0dc8d4a9e (patch) | |
tree | 42155f32096cd37a991e53cd0aa13de39dbe2091 /drivers/infiniband | |
parent | cd4e8fb49d2326364971a56f5a4b664a976f3712 (diff) |
[PATCH] IB/mthca: Clean up error messages
- Fix incorrect cut-n-paste in error messages.
- Add missing newlines in error messages.
- Use DRV_NAME instead of "ib_mthca" in a couple of places.
Signed-off-by: Roland Dreier <roland@topspin.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'drivers/infiniband')
-rw-r--r-- | drivers/infiniband/hw/mthca/mthca_eq.c | 9 | ||||
-rw-r--r-- | drivers/infiniband/hw/mthca/mthca_main.c | 8 |
2 files changed, 7 insertions, 10 deletions
diff --git a/drivers/infiniband/hw/mthca/mthca_eq.c b/drivers/infiniband/hw/mthca/mthca_eq.c index f46d615d396f..7500ebc23f36 100644 --- a/drivers/infiniband/hw/mthca/mthca_eq.c +++ b/drivers/infiniband/hw/mthca/mthca_eq.c | |||
@@ -615,8 +615,7 @@ static void mthca_free_eq(struct mthca_dev *dev, | |||
615 | if (err) | 615 | if (err) |
616 | mthca_warn(dev, "HW2SW_EQ failed (%d)\n", err); | 616 | mthca_warn(dev, "HW2SW_EQ failed (%d)\n", err); |
617 | if (status) | 617 | if (status) |
618 | mthca_warn(dev, "HW2SW_EQ returned status 0x%02x\n", | 618 | mthca_warn(dev, "HW2SW_EQ returned status 0x%02x\n", status); |
619 | status); | ||
620 | 619 | ||
621 | dev->eq_table.arm_mask &= ~eq->eqn_mask; | 620 | dev->eq_table.arm_mask &= ~eq->eqn_mask; |
622 | 621 | ||
@@ -709,8 +708,7 @@ static int __devinit mthca_map_eq_regs(struct mthca_dev *dev) | |||
709 | if (mthca_map_reg(dev, ((pci_resource_len(dev->pdev, 0) - 1) & | 708 | if (mthca_map_reg(dev, ((pci_resource_len(dev->pdev, 0) - 1) & |
710 | dev->fw.arbel.eq_arm_base) + 4, 4, | 709 | dev->fw.arbel.eq_arm_base) + 4, 4, |
711 | &dev->eq_regs.arbel.eq_arm)) { | 710 | &dev->eq_regs.arbel.eq_arm)) { |
712 | mthca_err(dev, "Couldn't map interrupt clear register, " | 711 | mthca_err(dev, "Couldn't map EQ arm register, aborting.\n"); |
713 | "aborting.\n"); | ||
714 | mthca_unmap_reg(dev, (pci_resource_len(dev->pdev, 0) - 1) & | 712 | mthca_unmap_reg(dev, (pci_resource_len(dev->pdev, 0) - 1) & |
715 | dev->fw.arbel.clr_int_base, MTHCA_CLR_INT_SIZE, | 713 | dev->fw.arbel.clr_int_base, MTHCA_CLR_INT_SIZE, |
716 | dev->clr_base); | 714 | dev->clr_base); |
@@ -721,8 +719,7 @@ static int __devinit mthca_map_eq_regs(struct mthca_dev *dev) | |||
721 | dev->fw.arbel.eq_set_ci_base, | 719 | dev->fw.arbel.eq_set_ci_base, |
722 | MTHCA_EQ_SET_CI_SIZE, | 720 | MTHCA_EQ_SET_CI_SIZE, |
723 | &dev->eq_regs.arbel.eq_set_ci_base)) { | 721 | &dev->eq_regs.arbel.eq_set_ci_base)) { |
724 | mthca_err(dev, "Couldn't map interrupt clear register, " | 722 | mthca_err(dev, "Couldn't map EQ CI register, aborting.\n"); |
725 | "aborting.\n"); | ||
726 | mthca_unmap_reg(dev, ((pci_resource_len(dev->pdev, 0) - 1) & | 723 | mthca_unmap_reg(dev, ((pci_resource_len(dev->pdev, 0) - 1) & |
727 | dev->fw.arbel.eq_arm_base) + 4, 4, | 724 | dev->fw.arbel.eq_arm_base) + 4, 4, |
728 | dev->eq_regs.arbel.eq_arm); | 725 | dev->eq_regs.arbel.eq_arm); |
diff --git a/drivers/infiniband/hw/mthca/mthca_main.c b/drivers/infiniband/hw/mthca/mthca_main.c index b7a57194ad25..7f8106a0f2b0 100644 --- a/drivers/infiniband/hw/mthca/mthca_main.c +++ b/drivers/infiniband/hw/mthca/mthca_main.c | |||
@@ -70,7 +70,7 @@ MODULE_PARM_DESC(msi, "attempt to use MSI if nonzero"); | |||
70 | #endif /* CONFIG_PCI_MSI */ | 70 | #endif /* CONFIG_PCI_MSI */ |
71 | 71 | ||
72 | static const char mthca_version[] __devinitdata = | 72 | static const char mthca_version[] __devinitdata = |
73 | "ib_mthca: Mellanox InfiniBand HCA driver v" | 73 | DRV_NAME ": Mellanox InfiniBand HCA driver v" |
74 | DRV_VERSION " (" DRV_RELDATE ")\n"; | 74 | DRV_VERSION " (" DRV_RELDATE ")\n"; |
75 | 75 | ||
76 | static struct mthca_profile default_profile = { | 76 | static struct mthca_profile default_profile = { |
@@ -928,13 +928,13 @@ static int __devinit mthca_init_one(struct pci_dev *pdev, | |||
928 | */ | 928 | */ |
929 | if (!(pci_resource_flags(pdev, 0) & IORESOURCE_MEM) || | 929 | if (!(pci_resource_flags(pdev, 0) & IORESOURCE_MEM) || |
930 | pci_resource_len(pdev, 0) != 1 << 20) { | 930 | pci_resource_len(pdev, 0) != 1 << 20) { |
931 | dev_err(&pdev->dev, "Missing DCS, aborting."); | 931 | dev_err(&pdev->dev, "Missing DCS, aborting.\n"); |
932 | err = -ENODEV; | 932 | err = -ENODEV; |
933 | goto err_disable_pdev; | 933 | goto err_disable_pdev; |
934 | } | 934 | } |
935 | if (!(pci_resource_flags(pdev, 2) & IORESOURCE_MEM) || | 935 | if (!(pci_resource_flags(pdev, 2) & IORESOURCE_MEM) || |
936 | pci_resource_len(pdev, 2) != 1 << 23) { | 936 | pci_resource_len(pdev, 2) != 1 << 23) { |
937 | dev_err(&pdev->dev, "Missing UAR, aborting."); | 937 | dev_err(&pdev->dev, "Missing UAR, aborting.\n"); |
938 | err = -ENODEV; | 938 | err = -ENODEV; |
939 | goto err_disable_pdev; | 939 | goto err_disable_pdev; |
940 | } | 940 | } |
@@ -1164,7 +1164,7 @@ static struct pci_device_id mthca_pci_table[] = { | |||
1164 | MODULE_DEVICE_TABLE(pci, mthca_pci_table); | 1164 | MODULE_DEVICE_TABLE(pci, mthca_pci_table); |
1165 | 1165 | ||
1166 | static struct pci_driver mthca_driver = { | 1166 | static struct pci_driver mthca_driver = { |
1167 | .name = "ib_mthca", | 1167 | .name = DRV_NAME, |
1168 | .id_table = mthca_pci_table, | 1168 | .id_table = mthca_pci_table, |
1169 | .probe = mthca_init_one, | 1169 | .probe = mthca_init_one, |
1170 | .remove = __devexit_p(mthca_remove_one) | 1170 | .remove = __devexit_p(mthca_remove_one) |