diff options
author | Sean Hefty <sean.hefty@intel.com> | 2007-07-02 19:14:14 -0400 |
---|---|---|
committer | Roland Dreier <rolandd@cisco.com> | 2007-07-11 00:52:28 -0400 |
commit | 6164c8cd1333403a28202f7c7e64ff9086d8f1aa (patch) | |
tree | 13f7156734c73a7f456572b252b8a8de87a65217 /drivers/infiniband | |
parent | 29c2731cbfa9d5b560a73461775f2be03b46dd4c (diff) |
IB/cm: Send no match if a SIDR REQ does not match a listen
If a SIDR REQ does not match a listen, we should reply with status
value 1 (service ID not supported), rather than dropping through to
the default case of status 2 (rejected by service provider).
Doing this also fixes a bug where the cm_id_priv is removed from the
remote_sidr_table twice.
Signed-off-by: Sean Hefty <sean.hefty@intel.com>
Signed-off-by: Roland Dreier <rolandd@cisco.com>
Diffstat (limited to 'drivers/infiniband')
-rw-r--r-- | drivers/infiniband/core/cm.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/infiniband/core/cm.c b/drivers/infiniband/core/cm.c index 9135a8c1d4ac..9820c67ba47d 100644 --- a/drivers/infiniband/core/cm.c +++ b/drivers/infiniband/core/cm.c | |||
@@ -2808,9 +2808,8 @@ static int cm_sidr_req_handler(struct cm_work *work) | |||
2808 | sidr_req_msg->service_id, | 2808 | sidr_req_msg->service_id, |
2809 | sidr_req_msg->private_data); | 2809 | sidr_req_msg->private_data); |
2810 | if (!cur_cm_id_priv) { | 2810 | if (!cur_cm_id_priv) { |
2811 | rb_erase(&cm_id_priv->sidr_id_node, &cm.remote_sidr_table); | ||
2812 | spin_unlock_irq(&cm.lock); | 2811 | spin_unlock_irq(&cm.lock); |
2813 | /* todo: reply with no match */ | 2812 | cm_reject_sidr_req(cm_id_priv, IB_SIDR_UNSUPPORTED); |
2814 | goto out; /* No match. */ | 2813 | goto out; /* No match. */ |
2815 | } | 2814 | } |
2816 | atomic_inc(&cur_cm_id_priv->refcount); | 2815 | atomic_inc(&cur_cm_id_priv->refcount); |