diff options
author | Sean Hefty <sean.hefty@intel.com> | 2007-06-05 12:57:31 -0400 |
---|---|---|
committer | Roland Dreier <rolandd@cisco.com> | 2007-06-08 02:24:38 -0400 |
commit | bf2944bd56c7a48cc3962a860dbc4ceee6b1ace8 (patch) | |
tree | b6255f3830965ddc615a0b872bd3c4bbfa1bf492 /drivers/infiniband | |
parent | 57f01b53398baebd809e7efd49fc10c10174b46d (diff) |
RDMA/cma: Fix initialization of next_port
next_port should be between sysctl_local_port_range[0] and [1].
However, it is initially set to a random value with get_random_bytes().
If the value is negative when treated as a signed integer, next_port
can end up outside the expected range because of the result of the %
operator being negative.
Signed-off-by: Sean Hefty <sean.hefty@intel.com>
Signed-off-by: Roland Dreier <rolandd@cisco.com>
Diffstat (limited to 'drivers/infiniband')
-rw-r--r-- | drivers/infiniband/core/cma.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c index 2eb52b7a71da..32a0e66d2a23 100644 --- a/drivers/infiniband/core/cma.c +++ b/drivers/infiniband/core/cma.c | |||
@@ -2773,8 +2773,8 @@ static int cma_init(void) | |||
2773 | int ret; | 2773 | int ret; |
2774 | 2774 | ||
2775 | get_random_bytes(&next_port, sizeof next_port); | 2775 | get_random_bytes(&next_port, sizeof next_port); |
2776 | next_port = (next_port % (sysctl_local_port_range[1] - | 2776 | next_port = ((unsigned int) next_port % |
2777 | sysctl_local_port_range[0])) + | 2777 | (sysctl_local_port_range[1] - sysctl_local_port_range[0])) + |
2778 | sysctl_local_port_range[0]; | 2778 | sysctl_local_port_range[0]; |
2779 | cma_wq = create_singlethread_workqueue("rdma_cm"); | 2779 | cma_wq = create_singlethread_workqueue("rdma_cm"); |
2780 | if (!cma_wq) | 2780 | if (!cma_wq) |