[PATCH] IB: sparse endianness cleanup

Fix sparse warnings.  Use __be* where appropriate.

Signed-off-by: Sean Hefty <sean.hefty@intel.com>
Signed-off-by: Roland Dreier <rolandd@cisco.com>

8 files changed, 100 insertions, 103 deletions

diff --git a/drivers/infiniband/include/ib_cm.h b/drivers/infiniband/include/ib_cm.h
index da650115e79a..8202ad2e6435 100644
--- a/drivers/infiniband/include/ib_cm.h
+++ b/drivers/infiniband/include/ib_cm.h
@@ -115,7 +115,7 @@ struct ib_cm_req_event_param {
         struct ib_sa_path_rec   *primary_path;
         struct ib_sa_path_rec   *alternate_path;
 
-        u64                     remote_ca_guid;
+        __be64                  remote_ca_guid;
         u32                     remote_qkey;
         u32                     remote_qpn;
         enum ib_qp_type         qp_type;
@@ -132,7 +132,7 @@ struct ib_cm_req_event_param {
 };
 
 struct ib_cm_rep_event_param {
-        u64                     remote_ca_guid;
+        __be64                  remote_ca_guid;
         u32                     remote_qkey;
         u32                     remote_qpn;
         u32                     starting_psn;
@@ -146,39 +146,39 @@ struct ib_cm_rep_event_param {
 };
 
 enum ib_cm_rej_reason {
-        IB_CM_REJ_NO_QP                         = __constant_htons(1),
-        IB_CM_REJ_NO_EEC                        = __constant_htons(2),
-        IB_CM_REJ_NO_RESOURCES                  = __constant_htons(3),
-        IB_CM_REJ_TIMEOUT                       = __constant_htons(4),
-        IB_CM_REJ_UNSUPPORTED                   = __constant_htons(5),
-        IB_CM_REJ_INVALID_COMM_ID               = __constant_htons(6),
-        IB_CM_REJ_INVALID_COMM_INSTANCE         = __constant_htons(7),
-        IB_CM_REJ_INVALID_SERVICE_ID            = __constant_htons(8),
-        IB_CM_REJ_INVALID_TRANSPORT_TYPE        = __constant_htons(9),
-        IB_CM_REJ_STALE_CONN                    = __constant_htons(10),
-        IB_CM_REJ_RDC_NOT_EXIST                 = __constant_htons(11),
-        IB_CM_REJ_INVALID_GID                   = __constant_htons(12),
-        IB_CM_REJ_INVALID_LID                   = __constant_htons(13),
-        IB_CM_REJ_INVALID_SL                    = __constant_htons(14),
-        IB_CM_REJ_INVALID_TRAFFIC_CLASS         = __constant_htons(15),
-        IB_CM_REJ_INVALID_HOP_LIMIT             = __constant_htons(16),
-        IB_CM_REJ_INVALID_PACKET_RATE           = __constant_htons(17),
-        IB_CM_REJ_INVALID_ALT_GID               = __constant_htons(18),
-        IB_CM_REJ_INVALID_ALT_LID               = __constant_htons(19),
-        IB_CM_REJ_INVALID_ALT_SL                = __constant_htons(20),
-        IB_CM_REJ_INVALID_ALT_TRAFFIC_CLASS     = __constant_htons(21),
-        IB_CM_REJ_INVALID_ALT_HOP_LIMIT         = __constant_htons(22),
-        IB_CM_REJ_INVALID_ALT_PACKET_RATE       = __constant_htons(23),
-        IB_CM_REJ_PORT_CM_REDIRECT              = __constant_htons(24),
-        IB_CM_REJ_PORT_REDIRECT                 = __constant_htons(25),
-        IB_CM_REJ_INVALID_MTU                   = __constant_htons(26),
-        IB_CM_REJ_INSUFFICIENT_RESP_RESOURCES   = __constant_htons(27),
-        IB_CM_REJ_CONSUMER_DEFINED              = __constant_htons(28),
-        IB_CM_REJ_INVALID_RNR_RETRY             = __constant_htons(29),
-        IB_CM_REJ_DUPLICATE_LOCAL_COMM_ID       = __constant_htons(30),
-        IB_CM_REJ_INVALID_CLASS_VERSION         = __constant_htons(31),
-        IB_CM_REJ_INVALID_FLOW_LABEL            = __constant_htons(32),
-        IB_CM_REJ_INVALID_ALT_FLOW_LABEL        = __constant_htons(33)
+        IB_CM_REJ_NO_QP                         = 1,
+        IB_CM_REJ_NO_EEC                        = 2,
+        IB_CM_REJ_NO_RESOURCES                  = 3,
+        IB_CM_REJ_TIMEOUT                       = 4,
+        IB_CM_REJ_UNSUPPORTED                   = 5,
+        IB_CM_REJ_INVALID_COMM_ID               = 6,
+        IB_CM_REJ_INVALID_COMM_INSTANCE         = 7,
+        IB_CM_REJ_INVALID_SERVICE_ID            = 8,
+        IB_CM_REJ_INVALID_TRANSPORT_TYPE        = 9,
+        IB_CM_REJ_STALE_CONN                    = 10,
+        IB_CM_REJ_RDC_NOT_EXIST                 = 11,
+        IB_CM_REJ_INVALID_GID                   = 12,
+        IB_CM_REJ_INVALID_LID                   = 13,
+        IB_CM_REJ_INVALID_SL                    = 14,
+        IB_CM_REJ_INVALID_TRAFFIC_CLASS         = 15,
+        IB_CM_REJ_INVALID_HOP_LIMIT             = 16,
+        IB_CM_REJ_INVALID_PACKET_RATE           = 17,
+        IB_CM_REJ_INVALID_ALT_GID               = 18,
+        IB_CM_REJ_INVALID_ALT_LID               = 19,
+        IB_CM_REJ_INVALID_ALT_SL                = 20,
+        IB_CM_REJ_INVALID_ALT_TRAFFIC_CLASS     = 21,
+        IB_CM_REJ_INVALID_ALT_HOP_LIMIT         = 22,
+        IB_CM_REJ_INVALID_ALT_PACKET_RATE       = 23,
+        IB_CM_REJ_PORT_CM_REDIRECT              = 24,
+        IB_CM_REJ_PORT_REDIRECT                 = 25,
+        IB_CM_REJ_INVALID_MTU                   = 26,
+        IB_CM_REJ_INSUFFICIENT_RESP_RESOURCES   = 27,
+        IB_CM_REJ_CONSUMER_DEFINED              = 28,
+        IB_CM_REJ_INVALID_RNR_RETRY             = 29,
+        IB_CM_REJ_DUPLICATE_LOCAL_COMM_ID       = 30,
+        IB_CM_REJ_INVALID_CLASS_VERSION         = 31,
+        IB_CM_REJ_INVALID_FLOW_LABEL            = 32,
+        IB_CM_REJ_INVALID_ALT_FLOW_LABEL        = 33
 };
 
 struct ib_cm_rej_event_param {
@@ -222,8 +222,7 @@ struct ib_cm_sidr_req_event_param {
         struct ib_cm_id         *listen_id;
         struct ib_device        *device;
         u8                      port;
-
-        u16     pkey;
+        u16                     pkey;
 };
 
 enum ib_cm_sidr_status {
@@ -285,12 +284,12 @@ typedef int (*ib_cm_handler)(struct ib_cm_id *cm_id,
 struct ib_cm_id {
         ib_cm_handler           cm_handler;
         void                    *context;
-        u64                     service_id;
-        u64                     service_mask;
+        __be64                  service_id;
+        __be64                  service_mask;
         enum ib_cm_state        state;          /* internal CM/debug use */
         enum ib_cm_lap_state    lap_state;      /* internal CM/debug use */
-        u32                     local_id;
-        u32                     remote_id;
+        __be32                  local_id;
+        __be32                  remote_id;
 };
 
 /**
@@ -330,13 +329,13 @@ void ib_destroy_cm_id(struct ib_cm_id *cm_id);
  *   IB_CM_ASSIGN_SERVICE_ID.
  */
 int ib_cm_listen(struct ib_cm_id *cm_id,
-                 u64 service_id,
-                 u64 service_mask);
+                 __be64 service_id,
+                 __be64 service_mask);
 
 struct ib_cm_req_param {
         struct ib_sa_path_rec   *primary_path;
         struct ib_sa_path_rec   *alternate_path;
-        u64                     service_id;
+        __be64                  service_id;
         u32                     qp_num;
         enum ib_qp_type         qp_type;
         u32                     starting_psn;
@@ -528,7 +527,7 @@ int ib_send_cm_apr(struct ib_cm_id *cm_id,
 
 struct ib_cm_sidr_req_param {
         struct ib_sa_path_rec   *path;
-        u64                     service_id;
+        __be64                  service_id;
         int                     timeout_ms;
         const void              *private_data;
         u8                      private_data_len;
diff --git a/drivers/infiniband/include/ib_mad.h b/drivers/infiniband/include/ib_mad.h
index 491b6f25b3b8..63237805d6af 100644
--- a/drivers/infiniband/include/ib_mad.h
+++ b/drivers/infiniband/include/ib_mad.h
@@ -111,12 +111,12 @@ struct ib_mad_hdr {
         u8      mgmt_class;
         u8      class_version;
         u8      method;
-        u16     status;
-        u16     class_specific;
-        u64     tid;
-        u16     attr_id;
-        u16     resv;
-        u32     attr_mod;
+        __be16  status;
+        __be16  class_specific;
+        __be64  tid;
+        __be16  attr_id;
+        __be16  resv;
+        __be32  attr_mod;
 };
 
 struct ib_rmpp_hdr {
@@ -124,8 +124,8 @@ struct ib_rmpp_hdr {
         u8      rmpp_type;
         u8      rmpp_rtime_flags;
         u8      rmpp_status;
-        u32     seg_num;
-        u32     paylen_newwin;
+        __be32  seg_num;
+        __be32  paylen_newwin;
 };
 
 typedef u64 __bitwise ib_sa_comp_mask;
@@ -139,9 +139,9 @@ typedef u64 __bitwise ib_sa_comp_mask;
  * the wire so we can't change the layout)
  */
 struct ib_sa_hdr {
-        u64                     sm_key;
-        u16                     attr_offset;
-        u16                     reserved;
+        __be64                  sm_key;
+        __be16                  attr_offset;
+        __be16                  reserved;
         ib_sa_comp_mask         comp_mask;
 } __attribute__ ((packed));
 
diff --git a/drivers/infiniband/include/ib_sa.h b/drivers/infiniband/include/ib_sa.h
index 6d999f7b5d93..326159c04aca 100644
--- a/drivers/infiniband/include/ib_sa.h
+++ b/drivers/infiniband/include/ib_sa.h
@@ -133,16 +133,16 @@ struct ib_sa_path_rec {
         /* reserved */
         union ib_gid dgid;
         union ib_gid sgid;
-        u16          dlid;
-        u16          slid;
+        __be16       dlid;
+        __be16       slid;
         int          raw_traffic;
         /* reserved */
-        u32          flow_label;
+        __be32       flow_label;
         u8           hop_limit;
         u8           traffic_class;
         int          reversible;
         u8           numb_path;
-        u16          pkey;
+        __be16       pkey;
         /* reserved */
         u8           sl;
         u8           mtu_selector;
@@ -176,18 +176,18 @@ struct ib_sa_path_rec {
 struct ib_sa_mcmember_rec {
         union ib_gid mgid;
         union ib_gid port_gid;
-        u32          qkey;
-        u16          mlid;
+        __be32       qkey;
+        __be16       mlid;
         u8           mtu_selector;
         u8           mtu;
         u8           traffic_class;
-        u16          pkey;
+        __be16       pkey;
         u8           rate_selector;
         u8           rate;
         u8           packet_life_time_selector;
         u8           packet_life_time;
         u8           sl;
-        u32          flow_label;
+        __be32       flow_label;
         u8           hop_limit;
         u8           scope;
         u8           join_state;
@@ -238,7 +238,7 @@ struct ib_sa_mcmember_rec {
 struct ib_sa_service_rec {
         u64             id;
         union ib_gid    gid;
-        u16             pkey;
+        __be16          pkey;
         /* reserved */
         u32             lease;
         u8              key[16];
diff --git a/drivers/infiniband/include/ib_smi.h b/drivers/infiniband/include/ib_smi.h
index ca8216514963..c07b31cb9499 100644
--- a/drivers/infiniband/include/ib_smi.h
+++ b/drivers/infiniband/include/ib_smi.h
@@ -41,8 +41,6 @@
 
 #include <ib_mad.h>
 
-#define IB_LID_PERMISSIVE                       0xFFFF
-
 #define IB_SMP_DATA_SIZE                        64
 #define IB_SMP_MAX_PATH_HOPS                    64
 
@@ -51,16 +49,16 @@ struct ib_smp {
         u8      mgmt_class;
         u8      class_version;
         u8      method;
-        u16     status;
+        __be16  status;
         u8      hop_ptr;
         u8      hop_cnt;
-        u64     tid;
-        u16     attr_id;
-        u16     resv;
-        u32     attr_mod;
-        u64     mkey;
-        u16     dr_slid;
-        u16     dr_dlid;
+        __be64  tid;
+        __be16  attr_id;
+        __be16  resv;
+        __be32  attr_mod;
+        __be64  mkey;
+        __be16  dr_slid;
+        __be16  dr_dlid;
         u8      reserved[28];
         u8      data[IB_SMP_DATA_SIZE];
         u8      initial_path[IB_SMP_MAX_PATH_HOPS];
diff --git a/drivers/infiniband/include/ib_user_cm.h b/drivers/infiniband/include/ib_user_cm.h
index 500b1af6ff77..72182d16778b 100644
--- a/drivers/infiniband/include/ib_user_cm.h
+++ b/drivers/infiniband/include/ib_user_cm.h
@@ -88,15 +88,15 @@ struct ib_ucm_attr_id {
 };
 
 struct ib_ucm_attr_id_resp {
-        __u64 service_id;
-        __u64 service_mask;
-        __u32 local_id;
-        __u32 remote_id;
+        __be64 service_id;
+        __be64 service_mask;
+        __be32 local_id;
+        __be32 remote_id;
 };
 
 struct ib_ucm_listen {
-        __u64 service_id;
-        __u64 service_mask;
+        __be64 service_id;
+        __be64 service_mask;
         __u32 id;
 };
 
@@ -114,13 +114,13 @@ struct ib_ucm_private_data {
 struct ib_ucm_path_rec {
         __u8  dgid[16];
         __u8  sgid[16];
-        __u16 dlid;
-        __u16 slid;
+        __be16 dlid;
+        __be16 slid;
         __u32 raw_traffic;
-        __u32 flow_label;
+        __be32 flow_label;
         __u32 reversible;
         __u32 mtu;
-        __u16 pkey;
+        __be16 pkey;
         __u8  hop_limit;
         __u8  traffic_class;
         __u8  numb_path;
@@ -138,7 +138,7 @@ struct ib_ucm_req {
         __u32 qpn;
         __u32 qp_type;
         __u32 psn;
-        __u64 sid;
+        __be64 sid;
         __u64 data;
         __u64 primary_path;
         __u64 alternate_path;
@@ -200,7 +200,7 @@ struct ib_ucm_lap {
 struct ib_ucm_sidr_req {
         __u32 id;
         __u32 timeout;
-        __u64 sid;
+        __be64 sid;
         __u64 data;
         __u64 path;
         __u16 pkey;
@@ -237,7 +237,7 @@ struct ib_ucm_req_event_resp {
         /* port */
         struct ib_ucm_path_rec primary_path;
         struct ib_ucm_path_rec alternate_path;
-        __u64                  remote_ca_guid;
+        __be64                 remote_ca_guid;
         __u32                  remote_qkey;
         __u32                  remote_qpn;
         __u32                  qp_type;
@@ -253,7 +253,7 @@ struct ib_ucm_req_event_resp {
 };
 
 struct ib_ucm_rep_event_resp {
-        __u64 remote_ca_guid;
+        __be64 remote_ca_guid;
         __u32 remote_qkey;
         __u32 remote_qpn;
         __u32 starting_psn;
diff --git a/drivers/infiniband/include/ib_user_mad.h b/drivers/infiniband/include/ib_user_mad.h
index a9a56b50aacc..44537aa32e62 100644
--- a/drivers/infiniband/include/ib_user_mad.h
+++ b/drivers/infiniband/include/ib_user_mad.h
@@ -70,8 +70,6 @@
  * @traffic_class - Traffic class in GRH
  * @gid - Remote GID in GRH
  * @flow_label - Flow label in GRH
- *
- * All multi-byte quantities are stored in network (big endian) byte order.
  */
 struct ib_user_mad_hdr {
         __u32   id;
@@ -79,9 +77,9 @@ struct ib_user_mad_hdr {
         __u32   timeout_ms;
         __u32   retries;
         __u32   length;
-        __u32   qpn;
-        __u32   qkey;
-        __u16   lid;
+        __be32  qpn;
+        __be32  qkey;
+        __be16  lid;
         __u8    sl;
         __u8    path_bits;
         __u8    grh_present;
@@ -89,7 +87,7 @@ struct ib_user_mad_hdr {
         __u8    hop_limit;
         __u8    traffic_class;
         __u8    gid[16];
-        __u32   flow_label;
+        __be32  flow_label;
 };
 
 /**
diff --git a/drivers/infiniband/include/ib_user_verbs.h b/drivers/infiniband/include/ib_user_verbs.h
index 7c613706af72..35857857aa3e 100644
--- a/drivers/infiniband/include/ib_user_verbs.h
+++ b/drivers/infiniband/include/ib_user_verbs.h
@@ -143,8 +143,8 @@ struct ib_uverbs_query_device {
 
 struct ib_uverbs_query_device_resp {
         __u64 fw_ver;
-        __u64 node_guid;
-        __u64 sys_image_guid;
+        __be64 node_guid;
+        __be64 sys_image_guid;
         __u64 max_mr_size;
         __u64 page_size_cap;
         __u32 vendor_id;
diff --git a/drivers/infiniband/include/ib_verbs.h b/drivers/infiniband/include/ib_verbs.h
index 8d5ea9568337..042a7d11fbcc 100644
--- a/drivers/infiniband/include/ib_verbs.h
+++ b/drivers/infiniband/include/ib_verbs.h
@@ -51,8 +51,8 @@
 union ib_gid {
         u8      raw[16];
         struct {
-                u64     subnet_prefix;
-                u64     interface_id;
+                __be64  subnet_prefix;
+                __be64  interface_id;
         } global;
 };
 
@@ -88,8 +88,8 @@ enum ib_atomic_cap {
 
 struct ib_device_attr {
         u64                     fw_ver;
-        u64                     node_guid;
-        u64                     sys_image_guid;
+        __be64                  node_guid;
+        __be64                  sys_image_guid;
         u64                     max_mr_size;
         u64                     page_size_cap;
         u32                     vendor_id;
@@ -291,8 +291,8 @@ struct ib_global_route {
 };
 
 struct ib_grh {
-        u32             version_tclass_flow;
-        u16             paylen;
+        __be32          version_tclass_flow;
+        __be16          paylen;
         u8              next_hdr;
         u8              hop_limit;
         union ib_gid    sgid;
@@ -303,6 +303,8 @@ enum {
         IB_MULTICAST_QPN = 0xffffff
 };
 
+#define IB_LID_PERMISSIVE       __constant_htons(0xFFFF)
+
 enum ib_ah_flags {
         IB_AH_GRH       = 1
 };