IB/qib: Remove s_lock around header validation

Review of qib_ruc_check_hdr() shows that the s_lock is not required in
the normal case.  The r_lock is held in all cases, and protects the qp
fields that are read.

The s_lock will be needed to around the call to qib_migrate_qp() to
insure that the send engine sees a consistent set of fields.

Signed-off-by: Mike Marciniszyn <mike.marciniszyn@qlogic.com>
Signed-off-by: Roland Dreier <roland@purestorage.com>

1 files changed, 1 insertions, 3 deletions

diff --git a/drivers/infiniband/hw/qib/qib_rc.c b/drivers/infiniband/hw/qib/qib_rc.c
index ecfa087ad45e..afaf4ac79f42 100644
--- a/drivers/infiniband/hw/qib/qib_rc.c
+++ b/drivers/infiniband/hw/qib/qib_rc.c
@@ -1889,10 +1889,8 @@ void qib_rc_rcv(struct qib_ctxtdata *rcd, struct qib_ib_header *hdr,
         }
 
         opcode = be32_to_cpu(ohdr->bth[0]);
-        spin_lock_irqsave(&qp->s_lock, flags);
         if (qib_ruc_check_hdr(ibp, hdr, has_grh, qp, opcode))
-                goto sunlock;
-        spin_unlock_irqrestore(&qp->s_lock, flags);
+                return;
 
         psn = be32_to_cpu(ohdr->bth[2]);
         opcode >>= 24;