aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/infiniband/hw/mthca
diff options
context:
space:
mode:
authorRoland Dreier <rolandd@cisco.com>2007-07-17 22:30:51 -0400
committerRoland Dreier <rolandd@cisco.com>2007-07-17 22:30:51 -0400
commit6d7d080e9f7cd535a8821efd3835c5cfa5223ab6 (patch)
tree62221b14658a7eeb9a34f258bfc91ec7e5079de2 /drivers/infiniband/hw/mthca
parent454a01e7f486279b0bf8979d94203ab7a503e053 (diff)
IB/mthca: Use uninitialized_var() for f0
Commit 9db48926 ("drivers/infiniband/hw/mthca/mthca_qp: kill uninit'd var warning") added "= 0" to the declarations of f0 to shut up gcc warnings. However, there's no point in making the code bigger by initializing f0 to a random value just to get rid of a warning; setting f0 to 0 is no safer than just using uninitialized_var(), which documents the situation better and gives smaller code too. For example, on x86_64: add/remove: 0/0 grow/shrink: 0/2 up/down: 0/-16 (-16) function old new delta mthca_tavor_post_send 1352 1344 -8 mthca_arbel_post_send 1489 1481 -8 Signed-off-by: Roland Dreier <rolandd@cisco.com>
Diffstat (limited to 'drivers/infiniband/hw/mthca')
-rw-r--r--drivers/infiniband/hw/mthca/mthca_qp.c16
1 files changed, 14 insertions, 2 deletions
diff --git a/drivers/infiniband/hw/mthca/mthca_qp.c b/drivers/infiniband/hw/mthca/mthca_qp.c
index 11f1d99db40b..0e9ef24f6638 100644
--- a/drivers/infiniband/hw/mthca/mthca_qp.c
+++ b/drivers/infiniband/hw/mthca/mthca_qp.c
@@ -1591,7 +1591,13 @@ int mthca_tavor_post_send(struct ib_qp *ibqp, struct ib_send_wr *wr,
1591 int i; 1591 int i;
1592 int size; 1592 int size;
1593 int size0 = 0; 1593 int size0 = 0;
1594 u32 f0 = 0; 1594 /*
1595 * f0 is only used if nreq != 0, and f0 will be initialized
1596 * the first time through the main loop, since size0 == 0 the
1597 * first time through. So nreq cannot become non-zero without
1598 * initializing f0, and f0 is in fact never used uninitialized.
1599 */
1600 u32 uninitialized_var(f0);
1595 int ind; 1601 int ind;
1596 u8 op0 = 0; 1602 u8 op0 = 0;
1597 1603
@@ -1946,7 +1952,13 @@ int mthca_arbel_post_send(struct ib_qp *ibqp, struct ib_send_wr *wr,
1946 int i; 1952 int i;
1947 int size; 1953 int size;
1948 int size0 = 0; 1954 int size0 = 0;
1949 u32 f0 = 0; 1955 /*
1956 * f0 is only used if nreq != 0, and f0 will be initialized
1957 * the first time through the main loop, since size0 == 0 the
1958 * first time through. So nreq cannot become non-zero without
1959 * initializing f0, and f0 is in fact never used uninitialized.
1960 */
1961 u32 uninitialized_var(f0);
1950 int ind; 1962 int ind;
1951 u8 op0 = 0; 1963 u8 op0 = 0;
1952 1964