aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/infiniband/hw/mthca/mthca_mr.c
diff options
context:
space:
mode:
authorRoland Dreier <rolandd@cisco.com>2006-02-01 00:14:18 -0500
committerRoland Dreier <rolandd@cisco.com>2006-03-20 13:08:07 -0500
commit399d7921299fc4f146bd62bfa6312382a5429bcc (patch)
treef7ddfa33ef532e887b3028fd5259b2ce5e26188e /drivers/infiniband/hw/mthca/mthca_mr.c
parentd9b98b0f11ee7dd39429001ba289f095b9d66917 (diff)
IB/mthca: Get rid of might_sleep() annotations
The might_sleep() annotations in mthca are silly -- they all occur shortly before calls that will end up in core functions like kmalloc() that will print the same warning in an unsafe context anyway. In fact, beyond cluttering the source, we're actually bloating text with CONFIG_DEBUG_SPINLOCK_SLEEP and/or CONFIG_PREEMPT_VOLUNTARY set. With both options set, getting rid of the might_sleep()s saves a lot: add/remove: 0/0 grow/shrink: 0/7 up/down: 0/-171 (-171) function old new delta mthca_pd_alloc 132 109 -23 mthca_init_cq 969 946 -23 mthca_mr_alloc 592 568 -24 mthca_pd_free 67 42 -25 mthca_free_mr 219 194 -25 mthca_free_cq 570 545 -25 mthca_fmr_alloc 742 716 -26 Signed-off-by: Roland Dreier <rolandd@cisco.com>
Diffstat (limited to 'drivers/infiniband/hw/mthca/mthca_mr.c')
-rw-r--r--drivers/infiniband/hw/mthca/mthca_mr.c6
1 files changed, 0 insertions, 6 deletions
diff --git a/drivers/infiniband/hw/mthca/mthca_mr.c b/drivers/infiniband/hw/mthca/mthca_mr.c
index e995e2aa016d..551320fdc9c5 100644
--- a/drivers/infiniband/hw/mthca/mthca_mr.c
+++ b/drivers/infiniband/hw/mthca/mthca_mr.c
@@ -340,8 +340,6 @@ int mthca_mr_alloc(struct mthca_dev *dev, u32 pd, int buffer_size_shift,
340 int err; 340 int err;
341 u8 status; 341 u8 status;
342 342
343 might_sleep();
344
345 WARN_ON(buffer_size_shift >= 32); 343 WARN_ON(buffer_size_shift >= 32);
346 344
347 key = mthca_alloc(&dev->mr_table.mpt_alloc); 345 key = mthca_alloc(&dev->mr_table.mpt_alloc);
@@ -467,8 +465,6 @@ void mthca_free_mr(struct mthca_dev *dev, struct mthca_mr *mr)
467 int err; 465 int err;
468 u8 status; 466 u8 status;
469 467
470 might_sleep();
471
472 err = mthca_HW2SW_MPT(dev, NULL, 468 err = mthca_HW2SW_MPT(dev, NULL,
473 key_to_hw_index(dev, mr->ibmr.lkey) & 469 key_to_hw_index(dev, mr->ibmr.lkey) &
474 (dev->limits.num_mpts - 1), 470 (dev->limits.num_mpts - 1),
@@ -495,8 +491,6 @@ int mthca_fmr_alloc(struct mthca_dev *dev, u32 pd,
495 int err = -ENOMEM; 491 int err = -ENOMEM;
496 int i; 492 int i;
497 493
498 might_sleep();
499
500 if (mr->attr.page_size < 12 || mr->attr.page_size >= 32) 494 if (mr->attr.page_size < 12 || mr->attr.page_size >= 32)
501 return -EINVAL; 495 return -EINVAL;
502 496